[Okular-devel] [okular] [Bug 351156] Add "Trim page to selection" feature

2015-08-10 Thread JakeLinder
https://bugs.kde.org/show_bug.cgi?id=351156 --- Comment #9 from jakelin...@mail.com --- True. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/list

Re: [Okular-devel] Review Request 123427: Save view information per file

2015-08-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123427/#review83684 --- How does this code play with the other code that remembers thi

[Okular-devel] [okular] [Bug 351156] Add "Trim page to selection" feature

2015-08-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=351156 --- Comment #8 from Albert Astals Cid --- If you're going to dump some code that i'm have to going to maintain for the next 10 years, you may as well help me a bit with it, no? -- You are receiving this mail because: You are the assignee for the bug.

Re: [Okular-devel] Review Request 124651: Implement reading mode functionality.

2015-08-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124651/#review83683 --- Please update documentation. I haven't tried it, does it reme

[Okular-devel] [okular] [Bug 351156] Add "Trim page to selection" feature

2015-08-10 Thread JakeLinder
https://bugs.kde.org/show_bug.cgi?id=351156 --- Comment #7 from jakelin...@mail.com --- Tests! The bane of driveby code contributions grrr -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okula

Re: [Okular-devel] Review Request 124276: Separated bookmarks.xml so that every document have its own bookmarks file

2015-08-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124276/#review83682 --- core/bookmarkmanager.h

[Okular-devel] [okular] [Bug 351156] Add "Trim page to selection" feature

2015-08-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=351156 --- Comment #6 from Albert Astals Cid --- Let's see the code, and then we can talk about it. If it has tests, the chances for merging increase :) -- You are receiving this mail because: You are the assignee for the bug. ___

[Okular-devel] [okular] [Bug 350798] Okular opens large PDFs very slowly

2015-08-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=350798 --- Comment #20 from Albert Astals Cid --- (In reply to Ruslan Kabatsayev from comment #18) > If I'm not mistaken, 0.33 should be newer than 0.24. Am I wrong? No, you're correct. (In reply to Ruslan Kabatsayev from comment #19) > @Albert > What time

[Okular-devel] [okular] [Bug 351156] Add "Trim page to selection" feature

2015-08-10 Thread JakeLinder
https://bugs.kde.org/show_bug.cgi?id=351156 --- Comment #5 from jakelin...@mail.com --- 3. Fair enough, that can wait anyway. Assuming the code is reasonably unobtrusive, is there a fair chance this'll be merged if I get it ready? if yes, I'll make the necessary changes and put up the code for you

[Okular-devel] [okular] [Bug 351156] Add "Trim page to selection" feature

2015-08-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=351156 --- Comment #4 from Albert Astals Cid --- 1. right 2. so maybe make the trim margins a submenu with two items that are mutually exclusive and that you can uncheck? 3. If you don't need to save it, why store it in the settings? (and no i'm not going to b

[Okular-devel] [okular] [Bug 351156] Add "Trim page to selection" feature

2015-08-10 Thread JakeLinder
https://bugs.kde.org/show_bug.cgi?id=351156 --- Comment #3 from jakelin...@mail.com --- Here's an example file for which "Trim Margins" is insufficient: http://ajcn.nutrition.org/content/82/1/69.full.pdf -- You are receiving this mail because: You are the assignee for the bug. _

[Okular-devel] [okular] [Bug 351156] Add "Trim page to selection" feature

2015-08-10 Thread JakeLinder
https://bugs.kde.org/show_bug.cgi?id=351156 --- Comment #2 from jakelin...@mail.com --- 1. Unlike other tools, it is also modal -- applying it changes the view, and deselecting it shouldn't disable it. You may want to trim an article to read it, then annotate as you read. 2. Show that the mode is

Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124612/#review83677 --- core/annotations.h (line 1658)

Re: [Okular-devel] Review Request 124687: Implement drawing quick selection tool for presentation mode

2015-08-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124687/#review83676 --- What's the difference between this and https://git.reviewboar

Re: [Okular-devel] Review Request 124689: Implement eraser tool for presentation view

2015-08-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124689/#review83675 --- Does this really depend on 124687 ? - Albert Astals Cid On

[Okular-devel] [okular] [Bug 351156] Add "Trim page to selection" feature

2015-08-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=351156 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #1 from Albert As

[Okular-devel] [okular] [Bug 351053] Okular Memory leak

2015-08-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=351053 Albert Astals Cid changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC|

[Okular-devel] [okular] [Bug 351156] New: Add "Trim page to selection" feature

2015-08-10 Thread JakeLinder
https://bugs.kde.org/show_bug.cgi?id=351156 Bug ID: 351156 Summary: Add "Trim page to selection" feature Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: wishlis

[Okular-devel] Review Request 124689: Implement eraser tool for presentation view

2015-08-10 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124689/ --- Review request for Okular, Albert Astals Cid and Laurent Montel. Bugs: 34

Re: [Okular-devel] Review Request 124681: Implement "allow quick selection of several colors for drawing in presentation mode" bug 345269

2015-08-10 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124681/ --- (Updated Aug. 10, 2015, 11:40 a.m.) Status -- This change has been d

[Okular-devel] Review Request 124687: Implement drawing quick selection tool for presentation mode

2015-08-10 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124687/ --- Review request for Okular, Albert Astals Cid and Laurent Montel. Reposito

Re: [Okular-devel] Review Request 124651: Implement reading mode functionality.

2015-08-10 Thread Anton Ermolenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124651/ --- (Updated Авг. 10, 2015, 1:07 п.п.) Review request for Okular and Albert A

[Okular-devel] Review Request 124681: Implement "allow quick selection of several colors for drawing in presentation mode" bug 345269

2015-08-10 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124681/ --- Review request for Okular, Albert Astals Cid and Tobias Koenig. Bugs: 345