----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124651/#review83683 -----------------------------------------------------------
Please update documentation. I haven't tried it, does it remember the state between restarts? Should it? part.cpp (line 302) <https://git.reviewboard.kde.org/r/124651/#comment57924> Please don't change the style of the code, makes it harder to review the patch because i have to check if what you did is an stylistic change or is there any real change in it. part.rc (line 2) <https://git.reviewboard.kde.org/r/124651/#comment57922> Increase the version number. part.rc (line 86) <https://git.reviewboard.kde.org/r/124651/#comment57923> Hmmm, do we really need a menu option for this? Maybe just a shortcut + documentation entry? ui/readmodemanager.h (line 2) <https://git.reviewboard.kde.org/r/124651/#comment57925> your * is too far away! - Albert Astals Cid On ago. 10, 2015, 10:07 a.m., Anton Ermolenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124651/ > ----------------------------------------------------------- > > (Updated ago. 10, 2015, 10:07 a.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 325190 > http://bugs.kde.org/show_bug.cgi?id=325190 > > > Repository: okular > > > Description > ------- > > Adds functionality to hide all elements with one action. > > > Diffs > ----- > > CMakeLists.txt 27a88dd > part.h 9eebdb2 > part.cpp d461ebe > part.rc 60f86e5 > ui/readmodemanager.h PRE-CREATION > ui/readmodemanager.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124651/diff/ > > > Testing > ------- > > Checked if it properly restores elements which was visible before enabling > reading mode and do not makes visible elements which wasn't. > > > Thanks, > > Anton Ermolenko > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
