Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-14 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123314/#review78939 --- Ship it! With this I can build Kile, so I'd say Ship it - Al

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-14 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123314/ --- (Updated April 14, 2015, 7:48 nachm.) Review request for Okular, Albert A

[Okular-devel] Jenkins build is still unstable: okular_master_qt5 #6

2015-04-14 Thread KDE CI System
See ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 123363: Fix the export header not being found in interfaces/*.h

2015-04-14 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123363/ --- Review request for Okular. Repository: okular Description --- Fix

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-14 Thread Alex Richardson
> On April 10, 2015, 6:59 p.m., Eugene Shalygin wrote: > > I cann't say that it fixes the issue. Maybe it does, but I just can not > > make it working. > > > > I'm testing with Kile. Kile needs access to > > okular/interfaces/viewerinterface.h. However, this file contains `#include > > "okula

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-14 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123314/#review78932 --- I have now managed to get Kile to compile after applying the f

[Okular-devel] [okular] [Bug 341318] Save for every document whether it is viewed in continuous mode or not

2015-04-14 Thread t0mplar
https://bugs.kde.org/show_bug.cgi?id=341318 --- Comment #5 from t0mp...@gmx.de --- That sounds like you got a lot farther than I did :-) I looked into the code a bit but didn't find the right spot to jump in (probably due to my incompetence when it comes to C++). At the moment I don't have time t

[Okular-devel] [okular] [Bug 341318] Save for every document whether it is viewed in continuous mode or not

2015-04-14 Thread felix_mauch
https://bugs.kde.org/show_bug.cgi?id=341318 --- Comment #4 from felix_ma...@web.de --- After some code browsing, I guess the following solution should work: DocumentPrivate::loadViewsInfo seems to be a good starting point as it's the xml parser. Following the function calls you end up in PageView

[Okular-devel] [okular] [Bug 341318] Save for every document whether it is viewed in continuous mode or not

2015-04-14 Thread felix_mauch
https://bugs.kde.org/show_bug.cgi?id=341318 felix_ma...@web.de changed: What|Removed |Added CC||felix_ma...@web.de --- Comment #3 from feli