Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 18, 2013, 8:41 p.m., Albert Astals Cid wrote: > > part.cpp, line 838 > > > > > > This looks a bit weird, you never initialize nor use m_dbusObjectName > > for anything other than for calling unregisterO

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/ --- (Updated Aug. 18, 2013, 11:37 p.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 18, 2013, 8:41 p.m., Albert Astals Cid wrote: > > shell/main.cpp, line 53 > > > > > > Just commenting here, but please try to review all your code. It's good > > if you can try to make all the variables

Re: [Okular-devel] Review Request 111782: Okular active: Do not position pages on non-exact pixel boundaries

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111782/ --- (Updated Aug. 18, 2013, 9:07 p.m.) Status -- This change has been mar

Re: [Okular-devel] Review Request 111782: Okular active: Do not position pages on non-exact pixel boundaries

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111782/#review38088 --- This review has been submitted with commit f852fa0958dab1a07b5

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 14, 2013, 10:29 p.m., Albert Astals Cid wrote: > > shell/shell.h, line 49 > > > > > > Why are you changing the dbus names? This will break whatever scripts > > people where using. > > Jonathan Doman wro

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/#review38086 --- part.cpp

Re: [Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

> On Aug. 18, 2013, 3:28 p.m., Albert Astals Cid wrote: > > Nice, still haven't had a look at the code, will try find some time for it > > next week. > > > > What would be awesome is if you could add some autotests (we are trying to > > get more and more of those) to make sure that we don't br

Re: [Okular-devel] Review Request 111410: Selection tool: copy/extract as vector graphic by calling "pdftocairo"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111410/#review38084 --- generators/poppler/generator_pdf.cpp

[Okular-devel] [okular] [Bug 323669] okular crashed while annotating

https://bugs.kde.org/show_bug.cgi?id=323669 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO CC|

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don

Re: [Okular-devel] Dt. 9th August - status

El Diumenge, 18 d'agost de 2013, a les 02:13:50, Jaydeep Solanki va escriure: > On Sat, Aug 17, 2013 at 2:06 AM, Albert Astals Cid wrote: > > El Divendres, 16 d'agost de 2013, a les 22:29:38, Jaydeep Solanki va > > > > escriure: > > > How it occurs : > > > > > > 1) Open an ePub > > > 2) As soon

Re: [Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112135/#review38076 --- Nice, still haven't had a look at the code, will try find some

Re: [Okular-devel] Review Request 110003: Best-fit zoom

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110003/ --- (Updated Aug. 18, 2013, 3:20 p.m.) Status -- This change has been mar

Re: [Okular-devel] Review Request 110003: Best-fit zoom

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110003/#review38075 --- This review has been submitted with commit e4aa8317b5d49ad1129

[Okular-devel] [okular] [Bug 249364] PATCH: Fit best (best-fit) zoom

https://bugs.kde.org/show_bug.cgi?id=249364 Albert Astals Cid changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

[Okular-devel] [okular] [Bug 323669] New: okular crashed while annotating

https://bugs.kde.org/show_bug.cgi?id=323669 Bug ID: 323669 Summary: okular crashed while annotating Classification: Unclassified Product: okular Version: 0.17.60 Platform: Compiled Sources OS: Linux Status: UNCO