----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112135/#review38076 -----------------------------------------------------------
Nice, still haven't had a look at the code, will try find some time for it next week. What would be awesome is if you could add some autotests (we are trying to get more and more of those) to make sure that we don't break stuff in the future when changing some other things. In this case should not be too hard creating some TextPagePrivates and calling setWordList on them and then checking that findTextInternalForward/findTextInternalBackward return the correct values. Can you try to do that? - Albert Astals Cid On Aug. 17, 2013, 7:48 p.m., Jaan Vajakas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112135/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2013, 7:48 p.m.) > > > Review request for Okular. > > > Description > ------- > > This patch solves Bug 323262 and Bug 323263. I also refactored and simplified > the code a little. By removing unnecessary calls to toLower in > TextPagePrivate::findTextInternalForward and > TextPagePrivate::findTextInternalBackward I also fixed a small bug: the > letter capital I with dot above (U+0130) did not match itself in > case-insensitive mode on Qt 4.8.4 (U+0130 still does not match lowercase i > (U+0069), which can be considered another bug, that I didn't fix (although > this behavior conforms to the Unicode case folding rules)). > > (I did not implement the Knuth-Morris-Pratt algorithm that I promised in a > comment of Bug 323263 because on second thought I find that the win, if any, > would probably be negligible except for some very special documents and > special query strings.) > > > This addresses bugs 323262 and 323263. > http://bugs.kde.org/show_bug.cgi?id=323262 > http://bugs.kde.org/show_bug.cgi?id=323263 > > > Diffs > ----- > > core/textpage.cpp 855942d > core/textpage_p.h 8ecf0c9 > > Diff: http://git.reviewboard.kde.org/r/112135/diff/ > > > Testing > ------- > > > Thanks, > > Jaan Vajakas > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
