[Okular-devel] [Bug 151614] store annotations with documents

2012-10-22 Thread Adam Porter
https://bugs.kde.org/show_bug.cgi?id=151614 Adam Porter changed: What|Removed |Added CC||a...@alphapapa.net -- You are receiving this mai

[Okular-devel] [Bug 301774] Wish: New option to save embedded annotation upon change/document close

2012-10-22 Thread Adam Porter
https://bugs.kde.org/show_bug.cgi?id=301774 Adam Porter changed: What|Removed |Added CC||a...@alphapapa.net -- You are receiving this mai

[Okular-devel] Another issue with tiled rendering

2012-10-22 Thread Albert Astals Cid
Hi Mailson, another issue i found with tiled rendering branch. In this branch you raised the max zoom level from 400% to 1600% this is all fine for the PDF backend that does support tiles, but all the others do not and will easily end up hitting the barrier in which we consider the pixmap to be

[Okular-devel] [Bug 308800] 'Next page' should switch two pages when viewing two pages on screen

2012-10-22 Thread jens
https://bugs.kde.org/show_bug.cgi?id=308800 --- Comment #6 from jens --- Agree, text to speech is indeed a valid one. I still think that the current behavior is at least not very consistent between what you can do with the keyboard vs the mouse. Following your rationale I would then suggest to le

Re: [Okular-devel] Review Request: Create proper Okular::ScreenAnnotation objects in poppler generator

2012-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106605/#review20668 --- This review has been submitted with commit 77ccbbcbaae2eb8e93d

Re: [Okular-devel] Review Request: Extend GuiUtils with helper function for ScreenAnnotation

2012-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106607/#review20665 --- This review has been submitted with commit a41a727e214eef60054

Re: [Okular-devel] Review Request: Extend Okular::Document to process RenditionActions

2012-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106608/#review20666 --- This review has been submitted with commit 563ad0458e7def8c68f

Re: [Okular-devel] Review Request: Add RenditionAction class

2012-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106603/#review20664 --- This review has been submitted with commit 282950d1278f042ed70

Re: [Okular-devel] Review Request: Extend the Okular::ScreenAnnotation class with API to set/get a trigger action

2012-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106604/#review20667 --- This review has been submitted with commit f713dd0fdf1202e70c2

Re: [Okular-devel] Review Request: Make VideoWidget independent of associated annotation type

2012-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106606/#review20663 --- This review has been submitted with commit d68bba55b44e33ed7f5

[Okular-devel] [Bug 308800] 'Next page' should switch two pages when viewing two pages on screen

2012-10-22 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=308800 --- Comment #5 from Albert Astals Cid --- Using the text to speech feature, searching from the current page -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing

Re: [Okular-devel] Review Request: Use libffmpegthumbnailer to create first-frame images in SnapshotTaker

2012-10-22 Thread Albert Astals Cid
> On Oct. 8, 2012, 8:53 p.m., Albert Astals Cid wrote: > > Does it have to be the ffmpegthumbnailer specifically? Afaik there's > > another video thumbnailer around, isn't there a generic kde mechanism to > > ask for the installed video thumbnailer and use that one? > > Tobias Koenig wrote: >

[Okular-devel] [Bug 308800] 'Next page' should switch two pages when viewing two pages on screen

2012-10-22 Thread jens
https://bugs.kde.org/show_bug.cgi?id=308800 --- Comment #4 from jens --- Could you describe a valid use case for switching from page 3 to 4 when both pages are already fully visible on the screen/viewport? -- You are receiving this mail because: You are the assignee for the bug. ___

Re: [Okular-devel] Review Request: Adapt PageView and PresentationWidget to handle ScreenAnnotations correctly

2012-10-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106986/#review20694 --- Ship it! Please remove the defaults from the switches, we want

[Okular-devel] [Bug 308800] 'Next page' should switch two pages when viewing two pages on screen

2012-10-22 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=308800 --- Comment #3 from Albert Astals Cid --- My rationale: * Changing the behaviour of the current actions is a no go since there are valid use cases for them just switching one page. * Adding new buttons is an overkill given the feature is already acces

Re: [Okular-devel] An outline and some questions regarding undo framework

2012-10-22 Thread Albert Astals Cid
El Dilluns, 22 d'octubre de 2012, a les 15:21:51, Jon Mease va escriure: > Thanks for the feedback Albert. > I think I will proceed with the plan of utilizing the XML code to > store/load annotation state information. And I'll plan on working to get > this in for 4.11. Please forgive my ignorance

Re: [Okular-devel] An outline and some questions regarding undo framework

2012-10-22 Thread Jon Mease
Thanks for the feedback Albert. I think I will proceed with the plan of utilizing the XML code to store/load annotation state information. And I'll plan on working to get this in for 4.11. Please forgive my ignorance of the development process, but when would be a good time to submit a review req

Re: [Okular-devel] Review Request: Split active app desktop file

2012-10-22 Thread Marco Martin
> On Oct. 19, 2012, 5:45 p.m., Albert Astals Cid wrote: > > Now this poses an interesting question, we are installing both okular and > > active-documentviewer saying they open the same mimetypes and saying they > > have the same initial preference, thus on a system that has both installed, >

Re: [Okular-devel] Review Request: Split active app desktop file

2012-10-22 Thread Albert Astals Cid
El Dilluns, 22 d'octubre de 2012, a les 07:36:59, Bogdan Cristea va escriure: > On Monday 22 October 2012 00:21:33 Albert Astals Cid wrote: > > The "active" (touch) code needs to be able to be compiled in a server (as > > distributions do). So you can't do any assumption on the host > > environment

[Okular-devel] [Bug 308800] 'Next page' should switch two pages when viewing two pages on screen

2012-10-22 Thread jens
https://bugs.kde.org/show_bug.cgi?id=308800 --- Comment #2 from jens --- Thanks a lot for your fast comment. Sorry for opening a new issue, I found only these two closed entries with a rather short discussion. Are you referring to these? https://bugs.kde.org/show_bug.cgi?id=258966 https://bugs.kd

Re: [Okular-devel] Review Request: Use libffmpegthumbnailer to create first-frame images in SnapshotTaker

2012-10-22 Thread Tobias Koenig
> On Oct. 8, 2012, 8:53 p.m., Albert Astals Cid wrote: > > Does it have to be the ffmpegthumbnailer specifically? Afaik there's > > another video thumbnailer around, isn't there a generic kde mechanism to > > ask for the installed video thumbnailer and use that one? Hej Albert, the thumbnaile

[Okular-devel] Review Request: Adapt PageView and PresentationWidget to handle ScreenAnnotations correctly

2012-10-22 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106986/ --- Review request for Okular. Description --- This patch completes the s

[Okular-devel] [Bug 308800] 'Next page' should switch two pages when viewing two pages on screen

2012-10-22 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=308800 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #1 from Albert As

[Okular-devel] [Bug 308800] 'Next page' should switch two pages when viewing two pages on screen

2012-10-22 Thread jens
https://bugs.kde.org/show_bug.cgi?id=308800 jens changed: What|Removed |Added Blocks||303462 -- You are receiving this mail because: You are

[Okular-devel] [Bug 308800] New: 'Next page' should switch two pages when viewing two pages on screen

2012-10-22 Thread jens
https://bugs.kde.org/show_bug.cgi?id=308800 Bug ID: 308800 Severity: minor Version: 0.15.2 Priority: NOR Assignee: okular-devel@kde.org Summary: 'Next page' should switch two pages when viewing two pages on screen