----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106986/#review20694 -----------------------------------------------------------
Ship it! Please remove the defaults from the switches, we want to get warnings if we add new enums that are not processed. Besides that the aptch looks ok, i have not tried it but i'm trusting you to have tried it, and at worst it only breaks video playing in the ui and you'll have to fix it ;-) - Albert Astals Cid On Oct. 22, 2012, 11:12 a.m., Tobias Koenig wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106986/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2012, 11:12 a.m.) > > > Review request for Okular. > > > Description > ------- > > This patch completes the series of patches to implement handling of > ScreenAnnotations in Okular. Unfortunately reviewboard has an issue with > accepting the patch, so I attached it as file to this report. > > > Diffs > ----- > > > Diff: http://git.reviewboard.kde.org/r/106986/diff/ > > > Testing > ------- > > > Thanks, > > Tobias Koenig > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
