Re: [PATCH][next] drm/nouveau/conn: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Danilo Krummrich
On Fri, Mar 28, 2025 at 08:56:25AM -0600, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of > a flexible structure where the size of the flexi

Re: [PATCH][next] drm/nouveau/outp: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Gustavo A. R. Silva
On 28/03/25 09:05, Danilo Krummrich wrote: On Fri, Mar 28, 2025 at 08:45:32AM -0600, Gustavo A. R. Silva wrote: -Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexibl

[PATCH v2][next] drm/nouveau/outp: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code, a

Re: [PATCH][next] drm/nouveau/outp: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Danilo Krummrich
On Fri, Mar 28, 2025 at 08:45:32AM -0600, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of > a flexible structure where the size of the flexi

[PATCH][next] drm/nouveau/outp: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code, a

[PATCH][next] drm/nouveau/conn: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code, a

Re: [PATCH v3] drm/nouveau: prime: fix ttm_bo_delayed_delete oops

2025-03-28 Thread Danilo Krummrich
On Wed, Mar 26, 2025 at 12:52:10PM +, Chris Bainbridge wrote: > Fix an oops in ttm_bo_delayed_delete which results from dererencing a > dangling pointer: > > Oops: general protection fault, probably for non-canonical address > 0x6b6b6b6b6b6b6b7b: [#1] PREEMPT SMP > CPU: 4 UID: 0 PID: 108

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-28 Thread Danilo Krummrich
On Thu, Mar 27, 2025 at 02:26:09PM -0400, M Henning wrote: > On Thu, Mar 27, 2025 at 8:56 AM Danilo Krummrich wrote: > > > > On Tue, Mar 25, 2025 at 07:40:56PM -0400, M Henning wrote: > > > Okay, that sounds reasonable since I don't expect this to change very > > > quickly. > > > > > > Since I do

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-28 Thread Danilo Krummrich
(CC: Ben, John) On Thu, Mar 27, 2025 at 02:03:21PM -0400, M Henning wrote: > On Thu, Mar 27, 2025 at 9:51 AM Danilo Krummrich wrote: > > > > On Fri, Mar 21, 2025 at 06:06:34PM -0400, M Henning wrote: > > > On Thu, Mar 20, 2025 at 2:18 PM Danilo Krummrich wrote: > > > > On Wed, Mar 12, 2025 at 05

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-28 Thread Danilo Krummrich
Hi Mel, On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote: > Userspace needs this information to set up zcull correctly. This is a very brief motivation for the commit, please also describe what the commit does using imperative form. > > Signed-off-by: Mel Henning > --- > .../drm/no

Re: [PATCH v2] drm/prime: fix drm_prime_gem_destroy comment

2025-03-28 Thread Danilo Krummrich
On Wed, Mar 26, 2025 at 01:10:58PM +, Chris Bainbridge wrote: > Edit the comments on correct usage of drm_prime_gem_destroy to note > that, if using TTM, drm_prime_gem_destroy must be called in the > ttm_buffer_object.destroy hook, to avoid the dma_buf being freed leaving > a dangling pointer w

Re: [PATCH 2/2] drm/nouveau: DRM_NOUVEAU_SET_ZCULL_CTXSW_BUFFER

2025-03-28 Thread Danilo Krummrich
On Thu, Mar 27, 2025 at 03:01:54PM -0400, M Henning wrote: > On Thu, Mar 27, 2025 at 9:58 AM Danilo Krummrich wrote: > > > > On Fri, Mar 21, 2025 at 07:00:57PM -0400, M Henning wrote: > > > This is a pointer in the gpu's virtual address space. It must be > > > aligned according to ctxsw_align and

Re: [PATCH v2][next] drm/nouveau/outp: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Danilo Krummrich
On Fri, Mar 28, 2025 at 09:52:18AM -0600, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of > a flexible structure where the size of the flexi

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-28 Thread Ben Skeggs
On 21/3/25 04:18, Danilo Krummrich wrote: Hi Mel, On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote: Userspace needs this information to set up zcull correctly. This is a very brief motivation for the commit, please also describe what the commit does using imperative form. Signed-

Re: [PATCH v2] drm/prime: fix drm_prime_gem_destroy comment

2025-03-28 Thread Christian König
Am 28.03.25 um 12:01 schrieb Danilo Krummrich: > On Wed, Mar 26, 2025 at 01:10:58PM +, Chris Bainbridge wrote: >> Edit the comments on correct usage of drm_prime_gem_destroy to note >> that, if using TTM, drm_prime_gem_destroy must be called in the >> ttm_buffer_object.destroy hook, to avoid th