[PATCH v4] drm/sched: Use struct for drm_sched_init() params

2025-02-11 Thread Philipp Stanner
drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of parameters reduces readability and has already caused one missnaming, addressed in: commit 6f1cacf4eba7 ("drm/nouveau: Improve variable name in nouveau_

Re: [PATCH v4] drm/sched: Use struct for drm_sched_init() params

2025-02-11 Thread Lizhi Hou
On 2/11/25 03:14, Philipp Stanner wrote: drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of parameters reduces readability and has already caused one missnaming, addressed in: commit 6f1cacf4eba7 ("d

Re: [PATCH v2 13/17] mm/page_idle: handle device-exclusive entries correctly in page_idle_clear_pte_refs_one()

2025-02-11 Thread SeongJae Park
On Mon, 10 Feb 2025 20:37:55 +0100 David Hildenbrand wrote: > Ever since commit b756a3b5e7ea ("mm: device exclusive memory access") > we can return with a device-exclusive entry from page_vma_mapped_walk(). > > page_idle_clear_pte_refs_one() is not prepared for that, so let's > teach it what to

Re: [PATCH v2 03/17] mm/rmap: convert make_device_exclusive_range() to make_device_exclusive()

2025-02-11 Thread David Hildenbrand
On 11.02.25 06:00, Andrew Morton wrote: On Mon, 10 Feb 2025 20:37:45 +0100 David Hildenbrand wrote: The single "real" user in the tree of make_device_exclusive_range() always requests making only a single address exclusive. The current implementation is hard to fix for properly supporting anon

Re: [PATCH v4] drm/sched: Use struct for drm_sched_init() params

2025-02-11 Thread Danilo Krummrich
On Tue, Feb 11, 2025 at 12:14:23PM +0100, Philipp Stanner wrote: > drm_sched_init() has a great many parameters and upcoming new > functionality for the scheduler might add even more. Generally, the > great number of parameters reduces readability and has already caused > one missnaming, addressed

Re: [PATCH v1 1/2] nouveau/svm: fix missing folio unlock + put after make_device_exclusive_range()

2025-02-11 Thread Alistair Popple
On Fri, Jan 24, 2025 at 07:15:23PM +0100, David Hildenbrand wrote: > In case we have to retry the loop, we are missing to unlock+put the > folio. In that case, we will keep failing make_device_exclusive_range() > because we cannot grab the folio lock, and even return from the function > with the fo

Re: [PATCH v1 2/2] nouveau/svm: don't initialize ret in nouveau_atomic_range_fault()

2025-02-11 Thread Alistair Popple
On Fri, Jan 24, 2025 at 07:15:24PM +0100, David Hildenbrand wrote: > ret will be modified immediately afterwards. Yep. Thanks for fixing. Reviewed-by: Alistair Popple > Signed-off-by: David Hildenbrand > --- > drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [PATCH 1/5] drm/nouveau/nvkm: factor out r535_gsp_rpc_handle_reply()

2025-02-11 Thread Alexandre Courbot
Hi Zhi, On Sat Feb 8, 2025 at 2:58 AM JST, Zhi Wang wrote: > There can be multiple cases of handling the GSP RPC messages, which are > the reply of GSP RPC commands according to the requirement of the > callers and the nature of the GSP RPC commands. > > To support all cases, first, centralize the

Re: [PATCH 2/5] drm/nouveau/nvkm: factor out the current RPC command reply policies

2025-02-11 Thread Alexandre Courbot
On Sat Feb 8, 2025 at 2:58 AM JST, Zhi Wang wrote: > There can be multiple cases of handling the GSP RPC messages, which are > the reply of GSP RPC commands according to the requirement of the callers > and the nature of the GSP RPC commands. > > The current supported reply policies are "callers do

Re: [PATCH 3/5] drm/nouveau/nvkm: introduce new GSP reply policy NVKM_GSP_RPC_REPLY_POLL

2025-02-11 Thread Alexandre Courbot
On Sat Feb 8, 2025 at 2:58 AM JST, Zhi Wang wrote: > There can be multiple cases of handling the GSP RPC messages, which > are the reply of GSP RPC commands according to the requirement of the > callers and the nature of the GSP RPC commands. > > Some GSP RPC command needs a new reply policy: "call

Re: [PATCH 5/5] drm/nouveau/nvkm: introduce a kernel doc for GSP message handling

2025-02-11 Thread Alexandre Courbot
On Sat Feb 8, 2025 at 2:58 AM JST, Zhi Wang wrote: > Introduce a kernel doc to describe the GSP message handling policy. > > Signed-off-by: Zhi Wang > --- > Documentation/gpu/nouveau.rst | 3 +++ > .../gpu/drm/nouveau/include/nvkm/subdev/gsp.h | 17 + > 2 file

Re: [PATCH v3 1/2] gpu: nova-core: add initial driver stub

2025-02-11 Thread Alexandre Courbot
On Mon Feb 10, 2025 at 2:30 AM JST, Danilo Krummrich wrote: > Add the initial nova-core driver stub. > > nova-core is intended to serve as a common base for nova-drm (the > corresponding DRM driver) and the vGPU manager VFIO driver, serving as a > hard- and firmware abstraction layer for GSP-based