Re: [PR] Support parsing MySQL stored procedure syntax part1 [shardingsphere]

2025-04-20 Thread via GitHub
strongduanmu merged PR #35154: URL: https://github.com/apache/shardingsphere/pull/35154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

Re: [PR] Support parsing MySQL stored procedure syntax part1 [shardingsphere]

2025-04-14 Thread via GitHub
strongduanmu commented on code in PR #35154: URL: https://github.com/apache/shardingsphere/pull/35154#discussion_r2043321159 ## test/it/parser/src/main/resources/sql/supported/ddl/create-procedure.xml: ## @@ -49,4 +49,9 @@ + Review Comment: Yes, let's w

Re: [PR] Support parsing MySQL stored procedure syntax part1 [shardingsphere]

2025-04-14 Thread via GitHub
jia17 commented on code in PR #35154: URL: https://github.com/apache/shardingsphere/pull/35154#discussion_r2041915354 ## test/it/parser/src/main/resources/sql/supported/ddl/create-procedure.xml: ## @@ -49,4 +49,9 @@ + Review Comment: I update the code r

Re: [PR] Support parsing MySQL stored procedure syntax part1 [shardingsphere]

2025-04-14 Thread via GitHub
strongduanmu commented on code in PR #35154: URL: https://github.com/apache/shardingsphere/pull/35154#discussion_r2041647922 ## test/it/parser/src/main/resources/sql/supported/ddl/create-procedure.xml: ## @@ -49,4 +49,9 @@ + Review Comment: You can refe

Re: [PR] Support parsing MySQL stored procedure syntax part1 [shardingsphere]

2025-04-14 Thread via GitHub
jia17 commented on code in PR #35154: URL: https://github.com/apache/shardingsphere/pull/35154#discussion_r2041613216 ## test/it/parser/src/main/resources/sql/supported/ddl/create-procedure.xml: ## @@ -49,4 +49,9 @@ + Review Comment: Could you give me s

Re: [PR] Support parsing MySQL stored procedure syntax part1 [shardingsphere]

2025-04-12 Thread via GitHub
jia17 commented on code in PR #35154: URL: https://github.com/apache/shardingsphere/pull/35154#discussion_r2040612170 ## test/it/parser/src/main/resources/sql/supported/ddl/create-procedure.xml: ## @@ -49,4 +49,9 @@ + Review Comment: Sorry, I don't full

Re: [PR] Support parsing MySQL stored procedure syntax part1 [shardingsphere]

2025-04-12 Thread via GitHub
strongduanmu commented on code in PR #35154: URL: https://github.com/apache/shardingsphere/pull/35154#discussion_r2040604723 ## test/it/parser/src/main/resources/sql/supported/ddl/create-procedure.xml: ## @@ -49,4 +49,9 @@ + Review Comment: Can you visi

Re: [PR] Support parsing MySQL stored procedure syntax part1 [shardingsphere]

2025-04-12 Thread via GitHub
jia17 commented on PR #35154: URL: https://github.com/apache/shardingsphere/pull/35154#issuecomment-2798724678 Hello @strongduanmu could you review this PR? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th