strongduanmu commented on code in PR #35154:
URL: https://github.com/apache/shardingsphere/pull/35154#discussion_r2043321159


##########
test/it/parser/src/main/resources/sql/supported/ddl/create-procedure.xml:
##########
@@ -49,4 +49,9 @@
     <sql-case id="create_plsql_block" value="DECLARE warehouse NUMBER := 1;   
ground    NUMBER := 1;   insured   NUMBER := 1;   result    NUMBER; BEGIN   
SELECT BIN_TO_NUM(warehouse, ground, insured) INTO result FROM DUAL;   UPDATE 
orders SET order_status = result WHERE order_id = 2441; END;" db-types="Oracle" 
/>
     <sql-case id="create_procedure_with_insert_into_values" value="create 
procedure T522_PROC (i int =10) as begin insert into T522 (ROW_INT) values 
(:i); end" db-types="Firebird"/>
     <sql-case 
id="create_procedure_with_declare_and_cursor_for_in_select_and_open" 
value="CREATE PROCEDURE F865_PROC (offset_value INT, page_size INT) as DECLARE 
catalog_page CURSOR FOR (SELECT * FROM company ORDER BY namecompany OFFSET 
:offset_value ROWS FETCH NEXT :page_size ROWS ONLY); BEGIN OPEN catalog_page; 
END" db-types="Firebird"/>
+    <sql-case id="create_procedure_with_handler_and_table_creation" 
value="CREATE PROCEDURE peter1 () BEGIN DECLARE v INTEGER DEFAULT 1234; DECLARE 
CONTINUE HANDLER FOR SQLWARNING BEGIN SHOW WARNINGS; SELECT &quot;handler done: 
&quot;,v; END; CREATE TABLE gg (smallint_column SMALLINT); CALL peter2(v); END" 
db-types="MySQL" />

Review Comment:
   Yes, let's waiting all e2e pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to