mdedetrich commented on PR #619:
URL: https://github.com/apache/incubator-pekko/pull/619#issuecomment-1890385397
Unlike Akka we follow semver which means we can only change this in 2.0.x.
Also I doubt this has any actual impact as JVM will make it effectively
final as long as no one s
He-Pin commented on PR #619:
URL: https://github.com/apache/incubator-pekko/pull/619#issuecomment-1890392101
Ok, let's schedule it to 2.0.x, at least I think no one will be affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
He-Pin opened a new pull request, #933:
URL: https://github.com/apache/incubator-pekko/pull/933
Motivation:
When I do code modification in pekko-stream related module, after a
`sortImports` I have to revert all unrelated changes, which is very annoying.
Result:
Sort the imports
He-Pin commented on code in PR #933:
URL: https://github.com/apache/incubator-pekko/pull/933#discussion_r1451429280
##
.scalafix.conf:
##
@@ -46,7 +46,10 @@ SortImports.blocks = [
"scala.",
"*",
"com.sun."
- "org.apache.pekko."
+ "re:^(org\\.apache\\.pekko|pekko\\.)\\
pjfanning opened a new pull request, #934:
URL: https://github.com/apache/incubator-pekko/pull/934
built-in java literals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
pjfanning merged PR #3:
URL: https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
pjfanning merged PR #934:
URL: https://github.com/apache/incubator-pekko/pull/934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr
pjfanning opened a new pull request, #4:
URL: https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/pull/4
We're getting issues in CI with `sbt paradox` when using Java 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pjfanning merged PR #2:
URL: https://github.com/apache/incubator-pekko-http-quickstart-java.g8/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
pjfanning closed pull request #1: Bump ch.qos.logback:logback-classic from
1.2.11 to 1.3.12 in /src/main/g8
URL: https://github.com/apache/incubator-pekko-http-quickstart-java.g8/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
dependabot[bot] commented on PR #1:
URL:
https://github.com/apache/incubator-pekko-http-quickstart-java.g8/pull/1#issuecomment-1890429299
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
pjfanning opened a new pull request, #3:
URL: https://github.com/apache/incubator-pekko-http-quickstart-java.g8/pull/3
`sbt paradox` doesn't work with Java 17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
pjfanning commented on PR #4:
URL:
https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/pull/4#issuecomment-1890430119
This fixes the paradox issue but the
https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/issues/5 is
still causing the CI build to fail. I wan
He-Pin opened a new pull request, #935:
URL: https://github.com/apache/incubator-pekko/pull/935
Motivation:
refs: https://github.com/apache/incubator-pekko/discussions/654
Note:
1. These method are only added for scaladsl
2. `foreach` method just work as fs2, where the `Stre
pjfanning commented on code in PR #935:
URL: https://github.com/apache/incubator-pekko/pull/935#discussion_r1451476399
##
stream/src/main/scala/org/apache/pekko/stream/scaladsl/Flow.scala:
##
@@ -2521,6 +2526,11 @@ trait FlowOps[+Out, +Mat] {
*/
def flatMapConcat[T, M](f:
GitHub user He-Pin added a comment to the discussion: Should Pekko stream
support `for` expression?
added in https://github.com/apache/incubator-pekko/pull/935
GitHub link:
https://github.com/apache/incubator-pekko/discussions/654#discussioncomment-8117642
This is an automatically sent
pjfanning merged PR #2:
URL: https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
He-Pin commented on PR #3:
URL:
https://github.com/apache/incubator-pekko-http-quickstart-java.g8/pull/3#issuecomment-1890442743
Lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
pjfanning closed pull request #4: use java 11 in CI build
URL: https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
pjfanning closed pull request #1: Bump ch.qos.logback:logback-classic from
1.2.3 to 1.3.12 in /src/main/g8
URL: https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
dependabot[bot] commented on PR #1:
URL:
https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/pull/1#issuecomment-1890443179
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
pjfanning merged PR #3:
URL: https://github.com/apache/incubator-pekko-http-quickstart-java.g8/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
pjfanning commented on PR #4:
URL:
https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/pull/4#issuecomment-1890443699
I accidentally included similar changes in #2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
pjfanning commented on code in PR #935:
URL: https://github.com/apache/incubator-pekko/pull/935#discussion_r1451499202
##
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/ForComprehensionsCompileSpec.scala:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software
pjfanning commented on code in PR #935:
URL: https://github.com/apache/incubator-pekko/pull/935#discussion_r1451500073
##
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/ForComprehensionsCompileSpec.scala:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software
He-Pin commented on PR #935:
URL: https://github.com/apache/incubator-pekko/pull/935#issuecomment-1890449553
@pjfanning Do you mean add `@ApiMayChange`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
He-Pin commented on code in PR #935:
URL: https://github.com/apache/incubator-pekko/pull/935#discussion_r1451502676
##
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/ForComprehensionsCompileSpec.scala:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Fo
pjfanning commented on PR #935:
URL: https://github.com/apache/incubator-pekko/pull/935#issuecomment-1890452111
> @pjfanning Do you mean add `@ApiMayChange`?
Maybe not that one - the API signatures won't change but we may need to
tweak the internals of the functions.
Even we a
He-Pin commented on PR #935:
URL: https://github.com/apache/incubator-pekko/pull/935#issuecomment-1890453699
I think the only in question is `foreach`, where `ZIO` alias to `runForEach`
but fs2 alias to `foreach` and then needs a `Stream#compile` to run to a
`F[_]`, as Pekko stream always n
pjfanning opened a new pull request, #28:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/28
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
pjfanning opened a new pull request, #312:
URL: https://github.com/apache/incubator-pekko-connectors/pull/312
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
laglangyue commented on PR #935:
URL: https://github.com/apache/incubator-pekko/pull/935#issuecomment-1890466877
LGTM for code.
This is an Amazing feature, we shoudl update the document also,maybe in
`docs/src/main/paradox/stream/operators/Flow/ `.
--
This is an automated message f
He-Pin commented on PR #935:
URL: https://github.com/apache/incubator-pekko/pull/935#issuecomment-1890467710
> LGTM for code.
> This is an Amazing feature, we shoudl update the document also,maybe in
`docs/src/main/paradox/stream/operators/Flow/ `.
>
I ignore that by purpose,
pjfanning merged PR #28:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
laglangyue commented on PR #311:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/311#issuecomment-1890473327
Overall, LGTM, and I leave some opinion here
(1) Is this compatible with historical users?
(2) should we update the doc `docs/src/main/paradox/ftp.md` ?
--
Thi
pjfanning commented on PR #311:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/311#issuecomment-1890476810
> Overall, LGTM, and I leave some opinion here (1) Is this compatible with
historical users? (2) should we update the doc `docs/src/main/paradox/ftp.md` ?
the pu
pjfanning commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451546765
##
docs/src/main/java/docs/ddata/protobuf/msg/TwoPhaseSetMessages.java:
##
@@ -18,81 +18,87 @@
public final class TwoPhaseSetMessages {
private TwoPhaseSe
pjfanning commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451547314
##
docs/src/main/java/docs/ddata/protobuf/msg/TwoPhaseSetMessages.java:
##
@@ -18,81 +18,87 @@
public final class TwoPhaseSetMessages {
private TwoPhaseSe
He-Pin commented on PR #935:
URL: https://github.com/apache/incubator-pekko/pull/935#issuecomment-1890588104
Let me merge this, I think this one should be ready to go, any improvement
can come up after.
--
This is an automated message from the Apache Git Service.
To respond to the message
He-Pin merged PR #935:
URL: https://github.com/apache/incubator-pekko/pull/935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...
He-Pin opened a new pull request, #937:
URL: https://github.com/apache/incubator-pekko/pull/937
Motivation:
1. Add a `flatten` operator which can simplify the code for common usage.
2. `flatten` is well known for mostly all scala developers
3. both ZIO and FS2 have `flatten` operator
He-Pin commented on code in PR #937:
URL: https://github.com/apache/incubator-pekko/pull/937#discussion_r1451580692
##
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/SourceSpec.scala:
##
@@ -515,4 +515,18 @@ class SourceSpec extends StreamSpec with DefaultTimeout {
He-Pin commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451585528
##
docs/src/main/java/docs/ddata/protobuf/msg/TwoPhaseSetMessages.java:
##
@@ -18,81 +18,87 @@
public final class TwoPhaseSetMessages {
private TwoPhaseSetMe
He-Pin commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451585528
##
docs/src/main/java/docs/ddata/protobuf/msg/TwoPhaseSetMessages.java:
##
@@ -18,81 +18,87 @@
public final class TwoPhaseSetMessages {
private TwoPhaseSetMe
pjfanning commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451587805
##
docs/src/main/java/docs/ddata/protobuf/msg/TwoPhaseSetMessages.java:
##
@@ -18,81 +18,87 @@
public final class TwoPhaseSetMessages {
private TwoPhaseSe
He-Pin commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451589708
##
docs/src/main/java/docs/ddata/protobuf/msg/TwoPhaseSetMessages.java:
##
@@ -18,81 +18,87 @@
public final class TwoPhaseSetMessages {
private TwoPhaseSetMe
He-Pin commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451590589
##
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/Ops.scala:
##
@@ -2225,7 +2225,7 @@ private[pekko] final class StatefulMap[S, In,
Out](create: () =>
He-Pin commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451590755
##
stream/src/main/scala/org/apache/pekko/stream/javadsl/Flow.scala:
##
@@ -770,6 +770,47 @@ final class Flow[In, Out, Mat](delegate: scaladsl.Flow[In,
Out, Mat])
He-Pin closed issue #915: Make SingleConsumerMultiProducer the default mailbox
for stream
URL: https://github.com/apache/incubator-pekko/issues/915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
GitHub user He-Pin closed a discussion: Should Pekko stream support `for`
expression?
Motivation:
Both ZIO and FS2 support this, and which is easier for simple job.
Prons:
Simpler and easier to use.
Cons:
Easy to get unexpected result.
Changes needed:
1. add `flatmap` === `flatmapConcat`
2.
GitHub user naosense closed a discussion: Plan for the first release
Where to find a clear plan for the first release, as well as the current work
schedule? I mean someone like me may want to do something to help, but don't
know what to do.
GitHub link: https://github.com/apache/incubator-pek
GitHub user kaplanbar closed a discussion: Pekko alternative of
akka-stream-contrib?
Hello, is there an alternative for akka-stream-contrib which uses Pekko?
https://github.com/akka/akka-stream-contrib/tree/main
GitHub link: https://github.com/apache/incubator-pekko/discussions/580
This
pjfanning closed issue #366: support jackson 2.16
URL: https://github.com/apache/incubator-pekko-http/issues/366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
pjfanning commented on issue #366:
URL:
https://github.com/apache/incubator-pekko-http/issues/366#issuecomment-1890798830
#368 was merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
scala-steward-asf[bot] opened a new pull request, #938:
URL: https://github.com/apache/incubator-pekko/pull/938
## About this PR
📦 Updates
* org.slf4j:jul-to-slf4j
* org.slf4j:log4j-over-slf4j
* org.slf4j:slf4j-api
from `2.0.10` to `2.0.11`
## Usage
✅ **Please m
pjfanning merged PR #406:
URL: https://github.com/apache/incubator-pekko-http/pull/406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-uns
scala-steward-asf[bot] opened a new pull request, #417:
URL: https://github.com/apache/incubator-pekko-http/pull/417
## About this PR
📦 Updates [com.google.code.gson:gson](https://github.com/google/gson/) from
`2.9.1` to `2.10.1`
## Usage
✅ **Please merge!**
I'll automati
pjfanning merged PR #417:
URL: https://github.com/apache/incubator-pekko-http/pull/417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-uns
pjfanning merged PR #938:
URL: https://github.com/apache/incubator-pekko/pull/938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr
laglangyue opened a new pull request, #939:
URL: https://github.com/apache/incubator-pekko/pull/939
## description
Fix some non-standard comments
use tool of idea 'replaceAll', and check them in local
## why need
it will cause some method can't generate doc
please view the sit
laglangyue commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451668442
##
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowMapWithResourceSpec.scala:
##
@@ -0,0 +1,416 @@
+/*
+ * Licensed to the Apache Software Fou
laglangyue commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451668442
##
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowMapWithResourceSpec.scala:
##
@@ -0,0 +1,416 @@
+/*
+ * Licensed to the Apache Software Fou
laglangyue commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451670572
##
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowMapWithResourceSpec.scala:
##
@@ -0,0 +1,416 @@
+/*
+ * Licensed to the Apache Software Fou
laglangyue commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451670572
##
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowMapWithResourceSpec.scala:
##
@@ -0,0 +1,416 @@
+/*
+ * Licensed to the Apache Software Fou
He-Pin commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451671015
##
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowMapWithResourceSpec.scala:
##
@@ -0,0 +1,416 @@
+/*
+ * Licensed to the Apache Software Foundat
laglangyue commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451672649
##
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowMapWithResourceSpec.scala:
##
@@ -0,0 +1,416 @@
+/*
+ * Licensed to the Apache Software Fou
laglangyue commented on code in PR #931:
URL: https://github.com/apache/incubator-pekko/pull/931#discussion_r1451676001
##
stream/src/main/scala/org/apache/pekko/stream/scaladsl/Flow.scala:
##
@@ -1082,7 +1082,47 @@ trait FlowOps[+Out, +Mat] {
* @param onComplete a function
67 matches
Mail list logo
