He-Pin commented on PR #935: URL: https://github.com/apache/incubator-pekko/pull/935#issuecomment-1890453699
I think the only in question is `foreach`, where `ZIO` alias to `runForEach` but fs2 alias to `foreach` and then needs a `Stream#compile` to run to a `F[_]`, as Pekko stream always needs an *explicitly* `run`, so I think we can follow what fs2 does, and that's what @gmethvin once suggested too. and for the `withFilter` and `flatmMap` , I think the currently shape should be fine, but I will update the scaladoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
