Roiocam commented on code in PR #105:
URL:
https://github.com/apache/incubator-pekko-projection/pull/105#discussion_r1495297199
##
kafka-test/src/test/scala/org/apache/pekko/projection/kafka/internal/KafkaSourceProviderImplSpec.scala:
##
@@ -109,6 +110,12 @@ class KafkaSourcePr
Roiocam commented on code in PR #105:
URL:
https://github.com/apache/incubator-pekko-projection/pull/105#discussion_r1495290031
##
kafka-test/src/test/scala/org/apache/pekko/projection/kafka/internal/KafkaSourceProviderImplSpec.scala:
##
@@ -109,6 +110,12 @@ class KafkaSourcePr
raboof commented on PR #105:
URL:
https://github.com/apache/incubator-pekko-projection/pull/105#issuecomment-1935811477
> > TBH I'm not convinced this change fixes the root cause of the
instability: because of the assertion `records.count(_.partition() ==
tp0.partition()) shouldBe 5` AFAIC
Roiocam commented on PR #105:
URL:
https://github.com/apache/incubator-pekko-projection/pull/105#issuecomment-1935793124
> TBH I'm not convinced this change fixes the root cause of the instability:
because of the assertion `records.count(_.partition() == tp0.partition())
shouldBe 5` AFAICS
Roiocam commented on PR #105:
URL:
https://github.com/apache/incubator-pekko-projection/pull/105#issuecomment-1934414814
@raboof Could you please do a code review? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
Roiocam commented on PR #105:
URL:
https://github.com/apache/incubator-pekko-projection/pull/105#issuecomment-1934409391
After four times CI checks(see:
https://github.com/apache/incubator-pekko-projection/actions/runs/7831923269),
this kind of test has been successfully passed, and we sho
