Re: [PR] Make flatMapPrefix javadsl using java.util.List [pekko]

2025-01-04 Thread via GitHub
He-Pin merged PR #271: URL: https://github.com/apache/pekko/pull/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apa

Re: [PR] Make flatMapPrefix javadsl using java.util.List [pekko]

2025-01-04 Thread via GitHub
He-Pin commented on PR #271: URL: https://github.com/apache/pekko/pull/271#issuecomment-2570937273 I'm using Java at $Work, the current Java api is really bad for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Make flatMapPrefix javadsl using java.util.List [pekko]

2025-01-04 Thread via GitHub
pjfanning commented on code in PR #271: URL: https://github.com/apache/pekko/pull/271#discussion_r1902927361 ## stream/src/main/mima-filters/1.0.x.backwards.excludes/pr-271-use-java-list-in-flatmapPrefix-javadsl.backwards.excludes: ## @@ -0,0 +1,24 @@ +# Licensed to the Apache S

Re: [PR] Make flatMapPrefix javadsl using java.util.List [pekko]

2025-01-04 Thread via GitHub
pjfanning commented on code in PR #271: URL: https://github.com/apache/pekko/pull/271#discussion_r1902925047 ## stream-tests/src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java: ## @@ -40,6 +41,7 @@ import org.junit.Assert; import org.junit.ClassRule; import org.jun

Re: [PR] Make flatMapPrefix javadsl using java.util.List [pekko]

2025-01-04 Thread via GitHub
raboof commented on PR #271: URL: https://github.com/apache/pekko/pull/271#issuecomment-2570917932 This change is binary compatible: any jar that was compiled against a Pekko version without this change will still work when ran against a Pekko version with this change. It is also sou

Re: [PR] Make flatMapPrefix javadsl using java.util.List [pekko]

2025-01-04 Thread via GitHub
He-Pin commented on PR #271: URL: https://github.com/apache/pekko/pull/271#issuecomment-2570912821 What do you think about 2.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Make flatMapPrefix javadsl using java.util.List [pekko]

2025-01-04 Thread via GitHub
pjfanning commented on PR #271: URL: https://github.com/apache/pekko/pull/271#issuecomment-2570875034 I still think we should add new methods and keep the existing methods that accept Iterable as input. This is a breaking change and I like to avoid breaking changes. -- This is an automat