raboof commented on PR #271: URL: https://github.com/apache/pekko/pull/271#issuecomment-2570917932
This change is binary compatible: any jar that was compiled against a Pekko version without this change will still work when ran against a Pekko version with this change. It is also source compatible when passing in a lambda. It is not source compatible when passing in a function constant. That seems like an acceptable change. > users of Sets and classes like that might still want to use the method The change of type is in the type of the objects Pekko provides, not in the type of the objects the user passes to Pekko. So changing the type from Iterable to List just formalizes a restriction on the Pekko implementation, not on the user code. While it's arguably only a minor quality of life improvement, I'd be OK with merging this change. Since there's been a lot of discussion above I'd like to see more consensus on that before actually merging, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
