Re: [PR] perf: avoid boxing in zipWithIndex [pekko]

pjfanning commented on PR #1669: URL: https://github.com/apache/pekko/pull/1669#issuecomment-2571149666 > @pjfanning it's a bug too, the signature on`SubSource` returns a `Pair ` instead of `Pair` Can you fix the description then to mention this? -- This is an automated message from

Re: [PR] perf: avoid boxing in zipWithIndex [pekko]

He-Pin commented on PR #1669: URL: https://github.com/apache/pekko/pull/1669#issuecomment-2571124072 @pjfanning it's a bug too, the signature on`SubSource` returns a `Pair ` instead of `Pair` -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] perf: avoid boxing in zipWithIndex [pekko]

pjfanning commented on PR #1669: URL: https://github.com/apache/pekko/pull/1669#issuecomment-2571088134 removed 'bug' label - this is a performance improvement according to the description -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] perf: avoid boxing in zipWithIndex [pekko]

pjfanning commented on code in PR #1669: URL: https://github.com/apache/pekko/pull/1669#discussion_r1902962065 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/Flow.scala: ## @@ -26,6 +26,7 @@ import scala.concurrent.duration.FiniteDuration import scala.reflect.ClassTag

Re: [PR] perf: avoid boxing in zipWithIndex [pekko]

pjfanning commented on PR #1669: URL: https://github.com/apache/pekko/pull/1669#issuecomment-2571026287 #1526 added a test so we shold be able to avoid the same break as before - but we could still hit issues in other untested scenarios -- This is an automated message from the Apache Git

Re: [PR] perf: avoid boxing in zipWithIndex [pekko]

He-Pin commented on PR #1669: URL: https://github.com/apache/pekko/pull/1669#issuecomment-2571008465 @mdedetrich Yes, with additional test added and actually find a bug in the `subSource` -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] perf: avoid boxing in zipWithIndex [pekko]

He-Pin commented on code in PR #1669: URL: https://github.com/apache/pekko/pull/1669#discussion_r1902276568 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/SubSource.scala: ## @@ -2246,8 +2247,9 @@ class SubSource[Out, Mat]( * * '''Cancels when''' downstream can

Re: [PR] perf: avoid boxing in zipWithIndex [pekko]

pjfanning commented on code in PR #1669: URL: https://github.com/apache/pekko/pull/1669#discussion_r1902093694 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/Flow.scala: ## @@ -26,6 +26,7 @@ import scala.concurrent.duration.FiniteDuration import scala.reflect.ClassTag

Re: [PR] perf: avoid boxing in zipWithIndex [pekko]

He-Pin commented on code in PR #1669: URL: https://github.com/apache/pekko/pull/1669#discussion_r1902068068 ## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/Ops.scala: ## @@ -77,6 +78,48 @@ import pekko.util.ccompat._ } } +/** + * INTERNAL API + */ +@Internal

Re: [PR] perf: avoid boxing in zipWithIndex [pekko]

He-Pin commented on code in PR #1669: URL: https://github.com/apache/pekko/pull/1669#discussion_r1902067493 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/SubSource.scala: ## @@ -2246,8 +2247,9 @@ class SubSource[Out, Mat]( * * '''Cancels when''' downstream can

[PR] perf: avoid boxing in zipWithIndex [pekko]

He-Pin opened a new pull request, #1669: URL: https://github.com/apache/pekko/pull/1669 Motivation: Performance, but it was reverted in https://github.com/apache/pekko/issues/1525 instead of https://github.com/apache/pekko/pull/1657 Modification: Reimplemented it in a dedicat