pjfanning commented on code in PR #1669: URL: https://github.com/apache/pekko/pull/1669#discussion_r1902962065
########## stream/src/main/scala/org/apache/pekko/stream/javadsl/Flow.scala: ########## @@ -26,6 +26,7 @@ import scala.concurrent.duration.FiniteDuration import scala.reflect.ClassTag import org.apache.pekko +import org.apache.pekko.stream.impl.fusing.ZipWithIndexJava Review Comment: are we sure this change was done? ########## stream/src/main/scala/org/apache/pekko/stream/impl/JavaStreamSource.scala: ########## @@ -13,14 +13,14 @@ package org.apache.pekko.stream.impl +import java.util.Spliterator Review Comment: can this be reverted? there are no other changes in this class ########## stream/src/main/scala/org/apache/pekko/stream/scaladsl/FlowWithContext.scala: ########## @@ -16,8 +16,8 @@ package org.apache.pekko.stream.scaladsl import scala.annotation.unchecked.uncheckedVariance import org.apache.pekko -import pekko.annotation.ApiMayChange import pekko.NotUsed +import pekko.annotation.ApiMayChange Review Comment: can this be reverted? there are no other code changes in this class ########## stream/src/main/mima-filters/1.0.x.backwards.excludes/pr-1669-avoid-boxing-in-zipWithIndex.backwards.excludes: ########## @@ -0,0 +1,19 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Should be java.lang.Long instead of java.lang.Object Review Comment: this should be 1.1.x.backward.excludes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
