He-Pin commented on PR #1638:
URL: https://github.com/apache/pekko/pull/1638#issuecomment-2564397150
This should not be needed, the current code is right, thanks god :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
He-Pin closed pull request #1638: chore: Try to fix Netty leak with explicit
read.
URL: https://github.com/apache/pekko/pull/1638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
He-Pin commented on code in PR #1638:
URL: https://github.com/apache/pekko/pull/1638#discussion_r1898957180
##
remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyHelpers.scala:
##
@@ -36,7 +35,7 @@ private[netty] trait NettyHelpers {
protected def onOpen(@un
jxnu-liguobin commented on code in PR #1638:
URL: https://github.com/apache/pekko/pull/1638#discussion_r1898957082
##
remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyHelpers.scala:
##
@@ -36,7 +35,7 @@ private[netty] trait NettyHelpers {
protected def onO
He-Pin commented on PR #1638:
URL: https://github.com/apache/pekko/pull/1638#issuecomment-2564386850
Do local run with `cluster/MultiJvm/test` and `
-Dio.netty.leakDetection.level=PARANOID` to find if it leaked.
--
This is an automated message from the Apache Git Service.
To respond to
He-Pin opened a new pull request, #1638:
URL: https://github.com/apache/pekko/pull/1638
Motivation:
refs: https://github.com/apache/pekko/issues/1634
Modification:
Do explicit read instead.
Result:
Expect No leaks.
--
This is an automated message from the Apa