He-Pin commented on code in PR #1638:
URL: https://github.com/apache/pekko/pull/1638#discussion_r1898957180
##########
remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyHelpers.scala:
##########
@@ -36,7 +35,7 @@ private[netty] trait NettyHelpers {
protected def onOpen(@unused ctx: ChannelHandlerContext): Unit = ()
- protected def onMessage(@unused ctx: ChannelHandlerContext, @unused msg:
ByteBuf): Unit = ()
+ protected def onMessage(@unused ctx: ChannelHandlerContext, @unused msg:
Array[Byte]): Unit = ()
Review Comment:
This PR is just a Try, and will not be needed. the old code is actually
right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
