Re: [PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-28 Thread via GitHub
mdedetrich merged PR #1063: URL: https://github.com/apache/incubator-pekko/pull/1063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

Re: [PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-28 Thread via GitHub
pjfanning commented on PR #1060: URL: https://github.com/apache/incubator-pekko/pull/1060#issuecomment-1913539063 use #1063 instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-28 Thread via GitHub
pjfanning closed pull request #1060: Update sbt-osgi to 0.10.0 URL: https://github.com/apache/incubator-pekko/pull/1060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-27 Thread via GitHub
mdedetrich commented on PR #1063: URL: https://github.com/apache/incubator-pekko/pull/1063#issuecomment-1913434283 > Before we can merge this, we should validate the Java 9 related classes is rightly been generated Agreed @Roiocam Do you want to do this since you did it last time.

Re: [PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-27 Thread via GitHub
He-Pin commented on PR #1063: URL: https://github.com/apache/incubator-pekko/pull/1063#issuecomment-1913433758 Before we can merge this, we should validate the Java 9 related classes is right generated -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-27 Thread via GitHub
mdedetrich commented on code in PR #1063: URL: https://github.com/apache/incubator-pekko/pull/1063#discussion_r1468725107 ## build.sbt: ## @@ -467,6 +470,7 @@ lazy val testkit = pekkoModule("testkit") .settings(AutomaticModuleName.settings("pekko.actor.testkit")) .settings

Re: [PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-27 Thread via GitHub
mdedetrich commented on code in PR #1063: URL: https://github.com/apache/incubator-pekko/pull/1063#discussion_r1468725107 ## build.sbt: ## @@ -467,6 +470,7 @@ lazy val testkit = pekkoModule("testkit") .settings(AutomaticModuleName.settings("pekko.actor.testkit")) .settings

Re: [PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-27 Thread via GitHub
mdedetrich commented on code in PR #1063: URL: https://github.com/apache/incubator-pekko/pull/1063#discussion_r1468713547 ## build.sbt: ## @@ -467,6 +470,7 @@ lazy val testkit = pekkoModule("testkit") .settings(AutomaticModuleName.settings("pekko.actor.testkit")) .settings

Re: [PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-27 Thread via GitHub
mdedetrich commented on code in PR #1063: URL: https://github.com/apache/incubator-pekko/pull/1063#discussion_r1468712937 ## build.sbt: ## @@ -467,6 +470,7 @@ lazy val testkit = pekkoModule("testkit") .settings(AutomaticModuleName.settings("pekko.actor.testkit")) .settings

Re: [PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-27 Thread via GitHub
mdedetrich commented on code in PR #1063: URL: https://github.com/apache/incubator-pekko/pull/1063#discussion_r1468712937 ## build.sbt: ## @@ -467,6 +470,7 @@ lazy val testkit = pekkoModule("testkit") .settings(AutomaticModuleName.settings("pekko.actor.testkit")) .settings

Re: [PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-27 Thread via GitHub
He-Pin commented on code in PR #1063: URL: https://github.com/apache/incubator-pekko/pull/1063#discussion_r1468706264 ## build.sbt: ## @@ -427,20 +428,22 @@ lazy val slf4j = pekkoModule("slf4j") .settings(Dependencies.slf4j) .settings(AutomaticModuleName.settings("pekko.sl

Re: [PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-27 Thread via GitHub
mdedetrich commented on PR #1063: URL: https://github.com/apache/incubator-pekko/pull/1063#issuecomment-1913386611 @Roiocam If you want to have a look as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-27 Thread via GitHub
mdedetrich opened a new pull request, #1063: URL: https://github.com/apache/incubator-pekko/pull/1063 This PR brings in the latest version of sbt-osgi. Aside from the package name being changed, of note is that since the initialization of keys was properly fixed in https://github.com/sbt/sb

[PR] Update sbt-osgi to 0.10.0 [incubator-pekko]

2024-01-27 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #1060: URL: https://github.com/apache/incubator-pekko/pull/1060 ## About this PR 📦 Updates [com.github.sbt:sbt-osgi](https://github.com/sbt/sbt-osgi) from `0.9.11` to `0.10.0` 📜 [GitHub Release Notes](https://github.com/sbt/sbt-osg