He-Pin commented on code in PR #1063:
URL: https://github.com/apache/incubator-pekko/pull/1063#discussion_r1468706264
##########
build.sbt:
##########
@@ -427,20 +428,22 @@ lazy val slf4j = pekkoModule("slf4j")
.settings(Dependencies.slf4j)
.settings(AutomaticModuleName.settings("pekko.slf4j"))
.settings(OSGi.slf4j)
+ .enablePlugins(SbtOsgi)
lazy val stream = pekkoModule("stream")
.dependsOn(actor, protobufV3)
.settings(Dependencies.stream)
.settings(AutomaticModuleName.settings("pekko.stream"))
.settings(OSGi.stream)
.settings(Protobuf.settings)
- .enablePlugins(BoilerplatePlugin, Jdk9)
+ .enablePlugins(BoilerplatePlugin, Jdk9, SbtOsgi)
lazy val streamTestkit = pekkoModule("stream-testkit")
.dependsOn(stream, testkit % "compile->compile;test->test")
.settings(Dependencies.streamTestkit)
.settings(AutomaticModuleName.settings("pekko.stream.testkit"))
.settings(OSGi.streamTestkit)
+ .enablePlugins(SbtOsgi)
Review Comment:
So does the kit.
##########
build.sbt:
##########
@@ -467,6 +470,7 @@ lazy val testkit = pekkoModule("testkit")
.settings(AutomaticModuleName.settings("pekko.actor.testkit"))
.settings(OSGi.testkit)
.settings(initialCommands += "import org.apache.pekko.testkit._")
+ .enablePlugins(SbtOsgi)
Review Comment:
Does the tests need osgi too？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
