Re: [PR] Update kafka-clients to 4.0.0 [pekko-connectors-kafka]

2025-04-01 Thread via GitHub
pjfanning commented on code in PR #296: URL: https://github.com/apache/pekko-connectors-kafka/pull/296#discussion_r2022599064 ## testkit/src/main/scala/org/apache/pekko/kafka/testkit/scaladsl/KafkaSpec.scala: ## @@ -37,6 +37,7 @@ import org.apache.kafka.clients.producer.{ Produ

Re: [PR] Update kafka-clients to 4.0.0 [pekko-connectors-kafka]

2025-03-30 Thread via GitHub
gaeljw commented on code in PR #296: URL: https://github.com/apache/pekko-connectors-kafka/pull/296#discussion_r2020170677 ## testkit/src/main/scala/org/apache/pekko/kafka/testkit/scaladsl/KafkaSpec.scala: ## @@ -37,6 +37,7 @@ import org.apache.kafka.clients.producer.{ Producer

Re: [PR] Update kafka-clients to 4.0.0 [pekko-connectors-kafka]

2025-03-26 Thread via GitHub
pjfanning commented on PR #296: URL: https://github.com/apache/pekko-connectors-kafka/pull/296#issuecomment-2755858020 looks like Java 8 is properly support with Kafka 4.0.0 - https://dlcdn.apache.org/kafka/4.0.0/RELEASE_NOTES.html -- This is an automated message from the Apache Git Serv

Re: [PR] Update kafka-clients to 4.0.0 [pekko-connectors-kafka]

2025-03-26 Thread via GitHub
pjfanning commented on code in PR #296: URL: https://github.com/apache/pekko-connectors-kafka/pull/296#discussion_r2014163513 ## core/src/main/scala/org/apache/pekko/kafka/RestrictedConsumer.scala: ## @@ -43,12 +43,6 @@ final class RestrictedConsumer(consumer: Consumer[_, _],

Re: [PR] Update kafka-clients to 4.0.0 [pekko-connectors-kafka]

2025-03-26 Thread via GitHub
pjfanning commented on PR #296: URL: https://github.com/apache/pekko-connectors-kafka/pull/296#issuecomment-2754221603 I fixed the compile issues in the main source but now there are quite a few in the test source. ``` [error] /home/runner/work/pekko-connectors-kafka/pekko-connec

Re: [PR] Update kafka-clients to 4.0.0 [pekko-connectors-kafka]

2025-03-23 Thread via GitHub
pjfanning commented on PR #296: URL: https://github.com/apache/pekko-connectors-kafka/pull/296#issuecomment-2746134928 upgrade causes compile issues due to API changes ``` [error] /home/runner/work/pekko-connectors-kafka/pekko-connectors-kafka/core/src/main/scala/org/apache/pekko/

[PR] Update kafka-clients to 4.0.0 [pekko-connectors-kafka]

2025-03-22 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #296: URL: https://github.com/apache/pekko-connectors-kafka/pull/296 ## About this PR 📦 Updates [org.apache.kafka:kafka-clients](https://kafka.apache.org) from `3.9.0` to `4.0.0` ⚠ ## Usage ✅ **Please merge!** I'll automat