gaeljw commented on code in PR #296: URL: https://github.com/apache/pekko-connectors-kafka/pull/296#discussion_r2020170677
########## testkit/src/main/scala/org/apache/pekko/kafka/testkit/scaladsl/KafkaSpec.scala: ########## @@ -37,6 +37,7 @@ import org.apache.kafka.clients.producer.{ Producer => KProducer, ProducerRecord import org.apache.kafka.common.ConsumerGroupState import org.slf4j.{ Logger, LoggerFactory } +import scala.annotation.nowarn import scala.collection.immutable import scala.concurrent.duration._ import scala.concurrent.{ Await, ExecutionContext, Future } Review Comment: (Comment for line 46 below) I see there's still a `zooKeeperPort`, does it still make sense with Kafka 4.x? I haven't looked at how it's used but Kafka server 4.x requires KRaft mode and there's no ZK anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org