mdedetrich commented on PR #395:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/395#issuecomment-1914227485
I am going to go ahead and merge this, I wanted to try and get a successful
run of `mqtt` but its well known that this test is incredibly failure and its
hit rate of
mdedetrich merged PR #395:
URL: https://github.com/apache/incubator-pekko-connectors/pull/395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
mdedetrich commented on PR #395:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/395#issuecomment-1913436650
@He-Pin There is also a related issue on this
https://github.com/pjfanning/sbt-pekko-build/issues/9
--
This is an automated message from the Apache Git Service.
To
He-Pin commented on PR #395:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/395#issuecomment-1913436533
> > Maybe we can do this
> >
> > ```
> > pekkoInlineEnabled := !sys.props.contains("pekko.no.inline")
> > ```
>
> Then we have to repeat this in every s
mdedetrich commented on PR #395:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/395#issuecomment-1913433878
> Maybe we can do this
>
> ```
> pekkoInlineEnabled := !sys.props.contains("pekko.no.inline")
> ```
Then we have to repeat this in every single Pekk
He-Pin commented on PR #395:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/395#issuecomment-1913432795
> > I'd think explicit is better
>
> It removes the ability to disable the inliner locally which is useful if
you want to debug issues
Maybe we can do this
mdedetrich commented on PR #395:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/395#issuecomment-1913432268
> I'd think explicit is better
It removes the ability to disable the inliner locally which is useful if you
want to debug issues
--
This is an automated mess
He-Pin commented on PR #395:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/395#issuecomment-1913431959
I'd think explicit is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mdedetrich commented on PR #395:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/395#issuecomment-1913429265
I will wait until
https://github.com/apache/incubator-pekko-connectors/pull/398 is resolved
before merging this
--
This is an automated message from the Apache Git
mdedetrich commented on PR #395:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/395#issuecomment-1913350429
So although I have tested this in the past already so I am 99% sure there
shouldn't be an issue, I will try and make every single CI for each connector
pass before me
mdedetrich opened a new pull request, #395:
URL: https://github.com/apache/incubator-pekko-connectors/pull/395
Enable the inliner since this is now 1.1.x. @pjfanning I know you were
sensitive about explicitly setting this to `true` to make it more clear but
doing so disables the knob/cli fl
11 matches
Mail list logo
