He-Pin commented on PR #395:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/395#issuecomment-1913436533
> > Maybe we can do this
> >
> > ```
> > pekkoInlineEnabled := !sys.props.contains("pekko.no.inline")
> > ```
>
> Then we have to repeat this in every single Pekko project which may have
inconsistency issues and also defeats the whole point of putting it in
sbt-pekko-build, i.e.
https://github.com/pjfanning/sbt-pekko-build/blob/main/src/main/scala/com/github/pjfanning/pekkobuild/PekkoInlinePlugin.scala#L55-L57
so it can be shared in all Pekko projects.
>
> When we are able to release artifacts from CI then we can reverse the
defaults so that inline isn't enable by default on local machines
Let's DRY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
