Re: [PR] Add overridden duration timeout to StreamTestKit [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1468: URL: https://github.com/apache/pekko/pull/1468#discussion_r1920936961 ## stream-testkit/src/main/scala/org/apache/pekko/stream/testkit/scaladsl/StreamTestKit.scala: ## @@ -53,10 +71,15 @@ object StreamTestKit { } /** INTERNAL API */

Re: [PR] Add overridden duration timeout to StreamTestKit [pekko]

2024-09-12 Thread via GitHub
jxnu-liguobin commented on code in PR #1468: URL: https://github.com/apache/pekko/pull/1468#discussion_r1756705231 ## stream-testkit/src/test/scala/org/apache/pekko/stream/testkit/StreamConfiguration.scala: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Add overridden duration timeout to StreamTestKit [pekko]

2024-09-12 Thread via GitHub
mdedetrich commented on code in PR #1468: URL: https://github.com/apache/pekko/pull/1468#discussion_r1756325644 ## stream-testkit/src/test/scala/org/apache/pekko/stream/testkit/StreamConfiguration.scala: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Add overridden duration timeout to StreamTestKit [pekko]

2024-09-12 Thread via GitHub
mdedetrich commented on PR #1468: URL: https://github.com/apache/pekko/pull/1468#issuecomment-2345512906 Adding some reviewers to this PR to get an idea whether its even on the right track, @jrudolph @raboof Maybe you have some comments? -- This is an automated message from the Apache Git

Re: [PR] Add overridden duration timeout to StreamTestKit [pekko]

2024-09-09 Thread via GitHub
mdedetrich commented on code in PR #1468: URL: https://github.com/apache/pekko/pull/1468#discussion_r1750089328 ## stream-testkit/src/test/scala/org/apache/pekko/stream/testkit/StreamSpec.scala: ## @@ -27,10 +26,26 @@ import pekko.testkit.{ PekkoSpec, TestProbe } import pekko.t

Re: [PR] Add overridden duration timeout to StreamTestKit [pekko]

2024-09-09 Thread via GitHub
mdedetrich commented on code in PR #1468: URL: https://github.com/apache/pekko/pull/1468#discussion_r1749990316 ## stream-testkit/src/test/scala/org/apache/pekko/stream/testkit/StreamSpec.scala: ## Review Comment: Not sure if this is the best way to configure the timeout fo