mdedetrich commented on code in PR #1468:
URL: https://github.com/apache/pekko/pull/1468#discussion_r1750089328
##########
stream-testkit/src/test/scala/org/apache/pekko/stream/testkit/StreamSpec.scala:
##########
@@ -27,10 +26,26 @@ import pekko.testkit.{ PekkoSpec, TestProbe }
import pekko.testkit.TestKitUtils
import org.scalatest.Failed
+import org.scalatest.time.{ Millis, Span }
import com.typesafe.config.{ Config, ConfigFactory }
+import java.util.concurrent.TimeUnit
+
abstract class StreamSpec(_system: ActorSystem) extends PekkoSpec(_system) {
+
+ final case class StreamConfig(allStagesStoppedTimeout: Span = Span({
Review Comment:
This might look a bit un-orthodox by Pekko standards, but it is the
idiomatic way to override a configuration when in ScalaTest (which is what
`StreamSpec` extends).
The defaault behaviour is still the same (i.e. getting the value from
`pekko.stream.testkit.all-stages-stopped-timeout`) but if you decide to
override it then you can do it the ScalaTest specific way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
