pjfanning commented on PR #485:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/485#issuecomment-1960453817
I'll keep an eye on the tests because I suspect that the closes could be
asynch and may need eventually blocks.
--
This is an automated message from the Apache Git S
pjfanning merged PR #485:
URL: https://github.com/apache/incubator-pekko-connectors/pull/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
pjfanning commented on PR #485:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/485#issuecomment-1960377127
@mdedetrich the test change sin JmsProducerRetrySpec fail with the existing
code and pass with the new code that closes the JMS sessions in the
retriableException code
pjfanning commented on PR #485:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/485#issuecomment-1960250942
I'll try to add some test coverage. https://github.com/pjfanning/JmsWrapper
is WIP
--
This is an automated message from the Apache Git Service.
To respond to the mes
mdedetrich commented on PR #485:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/485#issuecomment-1958785430
> relates to #484
>
> not sure how straightforward this is to unit test - would probably involve
opening up a lot of innards of the code
I would be more
pjfanning opened a new pull request, #485:
URL: https://github.com/apache/incubator-pekko-connectors/pull/485
relates to #484
not sure how straightforward this is to unit test - would probably involve
opening up a lot of innards of the code
--
This is an automated message from the
