mdedetrich commented on PR #485: URL: https://github.com/apache/incubator-pekko-connectors/pull/485#issuecomment-1958785430
> relates to #484 > > not sure how straightforward this is to unit test - would probably involve opening up a lot of innards of the code I would be more comfortable if we can somehow test this change as it would also allow us to account for regressions since being a resource leak its quite critical and we want to make sure that it works as intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org