[GH] (pekko-connectors): Workflow run "Publish Nightly" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Publish Nightly" on pekko-connectors.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 7ddb28b46fda98ad5ec630255f0e3bad985a09b2 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update n

[GH] (pekko-connectors): Workflow run "CI" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "CI" on pekko-connectors.git has failed. Run started by GitHub user scala-steward-asf[bot] (triggered by scala-steward-asf[bot]). Head commit for run: c77ff3c638ddd5e12d6a5e2f4daf0ccab8c0826d / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github

[GH] (pekko-connectors): Workflow run "CI" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "CI" on pekko-connectors.git has failed. Run started by GitHub user scala-steward-asf[bot] (triggered by scala-steward-asf[bot]). Head commit for run: 6462554c3b0746e163f06a7a50a0d607f17fcc41 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github

[GH] (pekko-connectors-kafka): Workflow run "Nightly Build and Test" is working again!

2024-12-28 Thread GitBox
The GitHub Actions job "Nightly Build and Test" on pekko-connectors-kafka.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: dc2f33607ec08325cf768a686d17f5658d4134e8 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.git

[GH] (pekko-management): Workflow run "Nightly Tests" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Nightly Tests" on pekko-management.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 751fa96dc9ddf23a6e8c06486820f9f8b2109a2d / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update ecs

[PR] Update auth, dynamodb, eventbridge, firehose, ... to 2.29.43 [pekko-connectors]

2024-12-28 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #934: URL: https://github.com/apache/pekko-connectors/pull/934 ## About this PR 📦 Updates * software.amazon.awssdk:auth * software.amazon.awssdk:dynamodb * software.amazon.awssdk:eventbridge * software.amazon.awssdk:firehose

[PR] Update sbt, scripted-plugin to 1.10.7 [pekko-connectors]

2024-12-28 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #933: URL: https://github.com/apache/pekko-connectors/pull/933 ## About this PR 📦 Updates * [org.scala-sbt:sbt](https://github.com/sbt/sbt) * [org.scala-sbt:scripted-plugin](https://github.com/sbt/sbt) from `1.10.6` to `1.10.

[GH] (pekko-http): Workflow run "Publish nightly snapshots and documentation" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Publish nightly snapshots and documentation" on pekko-http.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: cc97e82bf122d4b202d317b3471a39451844b49e / PJ Fanning jackson 2.18.2 (#639) Report URL: https://github.com/apache/p

[GH] (pekko-http): Workflow run "Nightly Builds" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Nightly Builds" on pekko-http.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: cc97e82bf122d4b202d317b3471a39451844b49e / PJ Fanning jackson 2.18.2 (#639) Report URL: https://github.com/apache/pekko-http/actions/runs/1253157

Re: [PR] remove old scala steward settings [pekko-http]

2024-12-28 Thread via GitHub
He-Pin merged PR #640: URL: https://github.com/apache/pekko-http/pull/640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekk

Re: [PR] Update sbt, scripted-plugin to 1.10.7 [pekko-http]

2024-12-28 Thread via GitHub
He-Pin merged PR #641: URL: https://github.com/apache/pekko-http/pull/641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekk

Re: [PR] Update sbt, scripted-plugin to 1.10.7 [pekko-persistence-r2dbc]

2024-12-28 Thread via GitHub
He-Pin merged PR #182: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

[GH] (pekko): Workflow run "Nightly Builds" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Nightly Builds" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: fc09ac63441951544f8a02cd23c2304d0dcf5dae / He-Pin(kerr) chore: Enable netty leak detector in CI (#1639) Report URL: https://github.com/apache/pek

[GH] (pekko-management): Workflow run "Unit Tests" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Unit Tests" on pekko-management.git has failed. Run started by GitHub user scala-steward-asf[bot] (triggered by scala-steward-asf[bot]). Head commit for run: fe83277cb1e980b4591584bd223436f547e04c76 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.norepl

[GH] (pekko-persistence-jdbc): Workflow run "Publish 1.0 Nightly" is working again!

2024-12-28 Thread GitBox
The GitHub Actions job "Publish 1.0 Nightly" on pekko-persistence-jdbc.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 41b1b1f966274171d6d0971b0324ba0c24ab38d9 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github

[GH] (pekko-projection): Workflow run "Link Validator" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Link Validator" on pekko-projection.git has failed. Run started by GitHub user scala-steward-asf[bot] (triggered by scala-steward-asf[bot]). Head commit for run: 973dee097e2ccf7cb1a5b74928b1fe6ae585d4bc / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.no

[PR] Update sbt, scripted-plugin to 1.10.7 [pekko-persistence-r2dbc]

2024-12-28 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #182: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/182 ## About this PR 📦 Updates * [org.scala-sbt:sbt](https://github.com/sbt/sbt) * [org.scala-sbt:scripted-plugin](https://github.com/sbt/sbt) from `1.10.6` to

[PR] Update sbt, scripted-plugin to 1.10.7 [pekko-projection]

2024-12-28 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #236: URL: https://github.com/apache/pekko-projection/pull/236 ## About this PR 📦 Updates * [org.scala-sbt:sbt](https://github.com/sbt/sbt) * [org.scala-sbt:scripted-plugin](https://github.com/sbt/sbt) from `1.10.6` to `1.10.

[GH] (pekko-management): Workflow run "Link Validator" is working again!

2024-12-28 Thread GitBox
The GitHub Actions job "Link Validator" on pekko-management.git has succeeded. Run started by GitHub user scala-steward-asf[bot] (triggered by scala-steward-asf[bot]). Head commit for run: 7911748a327de2675778abf970c8ca2c2bdfee35 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users

[GH] (pekko-management): Workflow run "Link Validator" is working again!

2024-12-28 Thread GitBox
The GitHub Actions job "Link Validator" on pekko-management.git has succeeded. Run started by GitHub user scala-steward-asf[bot] (triggered by scala-steward-asf[bot]). Head commit for run: 9fc8fd189e0394a97a6c071699be14b592cb0f36 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users

[PR] Update sbt, scripted-plugin to 1.10.7 [pekko-persistence-jdbc]

2024-12-28 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #253: URL: https://github.com/apache/pekko-persistence-jdbc/pull/253 ## About this PR 📦 Updates * [org.scala-sbt:sbt](https://github.com/sbt/sbt) * [org.scala-sbt:scripted-plugin](https://github.com/sbt/sbt) from `1.10.6` to

[GH] (pekko-management): Workflow run "Link Validator" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Link Validator" on pekko-management.git has failed. Run started by GitHub user scala-steward-asf[bot] (triggered by scala-steward-asf[bot]). Head commit for run: fe83277cb1e980b4591584bd223436f547e04c76 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.no

[PR] Update sbt, scripted-plugin to 1.10.7 [pekko-http]

2024-12-28 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #641: URL: https://github.com/apache/pekko-http/pull/641 ## About this PR 📦 Updates * [org.scala-sbt:sbt](https://github.com/sbt/sbt) * [org.scala-sbt:scripted-plugin](https://github.com/sbt/sbt) from `1.10.6` to `1.10.7`

[PR] Update sbt, scripted-plugin to 1.10.7 [pekko-management]

2024-12-28 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #369: URL: https://github.com/apache/pekko-management/pull/369 ## About this PR 📦 Updates * [org.scala-sbt:sbt](https://github.com/sbt/sbt) * [org.scala-sbt:scripted-plugin](https://github.com/sbt/sbt) from `1.10.6` to `1.10.

[PR] Update ecs to 2.29.43 [pekko-management]

2024-12-28 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #370: URL: https://github.com/apache/pekko-management/pull/370 ## About this PR 📦 Updates software.amazon.awssdk:ecs from `2.29.39` to `2.29.43` ## Usage ✅ **Please merge!** I'll automatically update this PR to resolve conf

[GH] (pekko-grpc): Workflow run "Link Validator" is working again!

2024-12-28 Thread GitBox
The GitHub Actions job "Link Validator" on pekko-grpc.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 9ad137271e0fb0d9b9a990193f215d7fc499eff7 / PJ Fanning Update build.sbt Report URL: https://github.com/apache/pekko-grpc/actions/runs/125

[GH] (pekko-persistence-dynamodb): Workflow run "Update Dependency Graph" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Update Dependency Graph" on pekko-persistence-dynamodb.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 69ba4038415673f28722a92ba4eae76c6adee98c / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.g

Re: [PR] Update sbt, scripted-plugin to 1.10.7 [pekko-persistence-dynamodb]

2024-12-28 Thread via GitHub
pjfanning merged PR #187: URL: https://github.com/apache/pekko-persistence-dynamodb/pull/187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] Update sbt, scripted-plugin to 1.10.7 [pekko-connectors-kafka]

2024-12-28 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #268: URL: https://github.com/apache/pekko-connectors-kafka/pull/268 ## About this PR 📦 Updates * [org.scala-sbt:sbt](https://github.com/sbt/sbt) * [org.scala-sbt:scripted-plugin](https://github.com/sbt/sbt) from `1.10.6` to

[GH] (pekko-grpc): Workflow run "Link Validator" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Link Validator" on pekko-grpc.git has failed. Run started by GitHub user scala-steward-asf[bot] (triggered by scala-steward-asf[bot]). Head commit for run: 0611caad5780b3f3de0bd8ea94a540aad4ba756d / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.

[PR] Update sbt, scripted-plugin to 1.10.7 [pekko-persistence-cassandra]

2024-12-28 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #247: URL: https://github.com/apache/pekko-persistence-cassandra/pull/247 ## About this PR 📦 Updates * [org.scala-sbt:sbt](https://github.com/sbt/sbt) * [org.scala-sbt:scripted-plugin](https://github.com/sbt/sbt) from `1.10.6

[PR] Update sbt, scripted-plugin to 1.10.7 [pekko-grpc]

2024-12-28 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #420: URL: https://github.com/apache/pekko-grpc/pull/420 ## About this PR 📦 Updates * [org.scala-sbt:sbt](https://github.com/sbt/sbt) * [org.scala-sbt:scripted-plugin](https://github.com/sbt/sbt) from `1.10.6` to `1.10.7`

[PR] Update sbt, scripted-plugin to 1.10.7 [pekko-persistence-dynamodb]

2024-12-28 Thread via GitHub
scala-steward-asf[bot] opened a new pull request, #187: URL: https://github.com/apache/pekko-persistence-dynamodb/pull/187 ## About this PR 📦 Updates * [org.scala-sbt:sbt](https://github.com/sbt/sbt) * [org.scala-sbt:scripted-plugin](https://github.com/sbt/sbt) from `1.10.6`

Re: [PR] jackson 2.18.2 [pekko-http]

2024-12-28 Thread via GitHub
pjfanning merged PR #639: URL: https://github.com/apache/pekko-http/pull/639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@p

[PR] remove old scala steward settings [pekko-http]

2024-12-28 Thread via GitHub
pjfanning opened a new pull request, #640: URL: https://github.com/apache/pekko-http/pull/640 we already use newer versions of scala-xml and specs2 than the scala steward pin is set to * scala-xml 2.1.0: https://github.com/apache/pekko-http/blob/main/project/Dependencies.scala#L54 * s

[PR] jackson 2.18.2 [pekko-http]

2024-12-28 Thread via GitHub
pjfanning opened a new pull request, #639: URL: https://github.com/apache/pekko-http/pull/639 see https://github.com/apache/pekko/pull/1556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] jackson 2.18 with max-token-count support [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on code in PR #1556: URL: https://github.com/apache/pekko/pull/1556#discussion_r1898997001 ## serialization-jackson/src/main/scala/org/apache/pekko/serialization/jackson/JacksonObjectMapperProvider.scala: ## @@ -159,11 +160,10 @@ object JacksonObjectMapperPro

Re: [PR] jackson 2.18 with max-token-count support [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on code in PR #1556: URL: https://github.com/apache/pekko/pull/1556#discussion_r1898997001 ## serialization-jackson/src/main/scala/org/apache/pekko/serialization/jackson/JacksonObjectMapperProvider.scala: ## @@ -159,11 +160,10 @@ object JacksonObjectMapperPro

[GH] (pekko): Workflow run "Nightly Builds" is working again!

2024-12-28 Thread GitBox
The GitHub Actions job "Nightly Builds" on pekko.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 2ac96a7879a5d6e9f21fed4672177a513c1ebd20 / PJ Fanning Update MixedProtocolClusterSpec.scala Report URL: https://github.com/apache/pekko/actio

Re: [I] Clustering issues leading to all nodes being downed [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on issue #578: URL: https://github.com/apache/pekko/issues/578#issuecomment-2564415474 @zhxiaogg 自己维护集群不错,比如 我们内部也可以用 VipServer 之类的,去中心化的这种感觉很容易出问题,毕竟内部经常搞断网演练。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Clustering issues leading to all nodes being downed [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on issue #578: URL: https://github.com/apache/pekko/issues/578#issuecomment-2564415041 Seem the problem is that `harmless=true/false` is not taken into account, I'm not using Cluster at work, so need more time for me to workout the problem. -- This is an automated message

[PR] chore: Add netty leak detector in multi-node-testing. [pekko]

2024-12-28 Thread via GitHub
He-Pin opened a new pull request, #1641: URL: https://github.com/apache/pekko/pull/1641 Motivation: Add the leak detector to multi-node-testing too. refs: https://github.com/apache/pekko/issues/1634 Modification: Add the options to the MultiNode CommandLine Options Resu

Re: [I] No transport is loaded for protocol: [pekko], available protocols: [pekko.tcp] [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on issue #1640: URL: https://github.com/apache/pekko/issues/1640#issuecomment-2564406059 Ok. I can see that this run may not be associated with the PR. No tests failed in this run. Maybe, the tests were negative tests where this sort of logging is expected? -- T

[GH] (pekko): Workflow run "Nightly Builds" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Nightly Builds" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: b3602ecb9a36a0ae0ed4040f754884c21dfa7c06 / PJ Fanning more tests Report URL: https://github.com/apache/pekko/actions/runs/12528611749 With rega

Re: [I] No transport is loaded for protocol: [pekko], available protocols: [pekko.tcp] [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on issue #1640: URL: https://github.com/apache/pekko/issues/1640#issuecomment-2564404408 That run is for a PR that is not yet ready. #1594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] No transport is loaded for protocol: [pekko], available protocols: [pekko.tcp] [pekko]

2024-12-28 Thread via GitHub
pjfanning closed issue #1640: No transport is loaded for protocol: [pekko], available protocols: [pekko.tcp] URL: https://github.com/apache/pekko/issues/1640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[I] No transport is loaded for protocol: [pekko], available protocols: [pekko.tcp] [pekko]

2024-12-28 Thread via GitHub
He-Pin opened a new issue, #1640: URL: https://github.com/apache/pekko/issues/1640 See this in testing: ``` No transport is loaded for protocol: [pekko], available protocols: [pekko.tcp] ``` https://github.com/apache/pekko/actions/runs/12528863513/job/34943874467#step:7:5682 -

[GH] (pekko): Workflow run "Nightly Builds" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Nightly Builds" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 1303acdb3b44f694f38e0f9486084ab9852d9b9f / PJ Fanning extra tests Report URL: https://github.com/apache/pekko/actions/runs/12528252498 With reg

Re: [PR] chore: Try to fix Netty leak with explicit read. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on PR #1638: URL: https://github.com/apache/pekko/pull/1638#issuecomment-2564397150 This should not be needed, the current code is right, thanks god :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] chore: Try to fix Netty leak with explicit read. [pekko]

2024-12-28 Thread via GitHub
He-Pin closed pull request #1638: chore: Try to fix Netty leak with explicit read. URL: https://github.com/apache/pekko/pull/1638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] chore: Enable netty leak detector in CI [pekko]

2024-12-28 Thread via GitHub
He-Pin merged PR #1639: URL: https://github.com/apache/pekko/pull/1639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.a

Re: [I] Maybe memory leak in Netty 4 transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on issue #1634: URL: https://github.com/apache/pekko/issues/1634#issuecomment-2564392638 @pjfanning I think the only way to find where it leaked is using ` -Dio.netty.leakDetection.level=PARANOID` and return the test, which will print the detail leaked position. -- This

Re: [I] Maybe memory leak in Netty 4 transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on issue #1634: URL: https://github.com/apache/pekko/issues/1634#issuecomment-2564391192 Yes, I run it locally, and no leak, otherwise it will prints something like: ``` LEAK: {}.release() was not called before it's garbage-collected. ``` -- This is an automat

Re: [I] Maybe memory leak in Netty 4 transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on issue #1634: URL: https://github.com/apache/pekko/issues/1634#issuecomment-2564391664 @pjfanning I think the exception handing is nice, I will add it in another PR. Iet's close it after https://github.com/apache/pekko/pull/1639 merged and checked it again. -- This

Re: [PR] chore: Enable netty leak detector in CI [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on code in PR #1639: URL: https://github.com/apache/pekko/pull/1639#discussion_r1898959324 ## .jvmopts-ci: ## @@ -12,3 +12,5 @@ -XX:-ClassUnloadingWithConcurrentMark -Djava.security.egd=file:/dev/./urandom -Dpekko.ci-server=true +#Trace Netty memory leaks

[PR] chore: Enable netty leak detector in CI [pekko]

2024-12-28 Thread via GitHub
He-Pin opened a new pull request, #1639: URL: https://github.com/apache/pekko/pull/1639 Motivation: It needs to be enabled in `.jvmopts-ci` too. refs: https://github.com/apache/pekko/issues/1634 otherwise, it's just : ``` io.netty.util.ResourceLeakDetector -- -Di

Re: [I] Maybe memory leak in Netty 4 transport. [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on issue #1634: URL: https://github.com/apache/pekko/issues/1634#issuecomment-2564389980 Isn't it good that there is no leak? Can we close this? Any ideas what might be going wrong in Flink tests? https://issues.apache.org/jira/browse/FLINK-36290 Do w

Re: [I] Maybe memory leak in Netty 4 transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on issue #1634: URL: https://github.com/apache/pekko/issues/1634#issuecomment-2564387991 Do local run with cluster/MultiJvm/test and -Dio.netty.leakDetection.level=PARANOID to find if it leaked. -- This is an automated message from the Apache Git Service. T

Re: [PR] chore: Try to fix Netty leak with explicit read. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on code in PR #1638: URL: https://github.com/apache/pekko/pull/1638#discussion_r1898957180 ## remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyHelpers.scala: ## @@ -36,7 +35,7 @@ private[netty] trait NettyHelpers { protected def onOpen(@un

Re: [PR] chore: Try to fix Netty leak with explicit read. [pekko]

2024-12-28 Thread via GitHub
jxnu-liguobin commented on code in PR #1638: URL: https://github.com/apache/pekko/pull/1638#discussion_r1898957082 ## remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyHelpers.scala: ## @@ -36,7 +35,7 @@ private[netty] trait NettyHelpers { protected def onO

Re: [PR] chore: Try to fix Netty leak with explicit read. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on PR #1638: URL: https://github.com/apache/pekko/pull/1638#issuecomment-2564386850 Do local run with `cluster/MultiJvm/test` and ` -Dio.netty.leakDetection.level=PARANOID` to find if it leaked. -- This is an automated message from the Apache Git Service. To respond to

[GH] (pekko): Workflow run "Pull Requests" is working again!

2024-12-28 Thread GitBox
The GitHub Actions job "Pull Requests" on pekko.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 1303acdb3b44f694f38e0f9486084ab9852d9b9f / PJ Fanning extra tests Report URL: https://github.com/apache/pekko/actions/runs/12528252486 With r

Re: [PR] chore: Turn on Netty's leak detector in build. [pekko]

2024-12-28 Thread via GitHub
He-Pin merged PR #1637: URL: https://github.com/apache/pekko/pull/1637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.a

Re: [I] Maybe memory leak in Netty 4 transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on issue #1634: URL: https://github.com/apache/pekko/issues/1634#issuecomment-2564384109 Actually, the code is Right:(, Because it extends the `SimpleChannelInboundHandler` which will do auto-release. ```scala finally { if (autoRelease && rele

[GH] (pekko): Workflow run "Binary Compatibility" is working again!

2024-12-28 Thread GitBox
The GitHub Actions job "Binary Compatibility" on pekko.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: a68611be0185549ed6f1348c9b499400cf80acb2 / He-Pin chore: Try to fix Netty leak with explicit read. Report URL: https://github.com/apache/pekko

[GH] (pekko): Workflow run "Generate doc check" is working again!

2024-12-28 Thread GitBox
The GitHub Actions job "Generate doc check" on pekko.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: a68611be0185549ed6f1348c9b499400cf80acb2 / He-Pin chore: Try to fix Netty leak with explicit read. Report URL: https://github.com/apache/pekko/a

[PR] chore: Try to fix Netty leak with explicit read. [pekko]

2024-12-28 Thread via GitHub
He-Pin opened a new pull request, #1638: URL: https://github.com/apache/pekko/pull/1638 Motivation: refs: https://github.com/apache/pekko/issues/1634 Modification: Do explicit read instead. Result: Expect No leaks. -- This is an automated message from the Apa

[GH] (pekko): Workflow run "Pull Requests" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Pull Requests" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: b9b376070f21e1f0f962f3ca4421ddc67120273f / He-Pin fix: Fix ByteBuf leak in remoting transport. Report URL: https://github.com/apache/pekko/actions/runs/

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin closed pull request #1635: fix: Fix ByteBuf leak in remoting transport. URL: https://github.com/apache/pekko/pull/1635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GH] (pekko): Workflow run "Generate doc check" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Generate doc check" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: b9b376070f21e1f0f962f3ca4421ddc67120273f / He-Pin fix: Fix ByteBuf leak in remoting transport. Report URL: https://github.com/apache/pekko/actions/

[GH] (pekko): Workflow run "Binary Compatibility" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Binary Compatibility" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: b9b376070f21e1f0f962f3ca4421ddc67120273f / He-Pin fix: Fix ByteBuf leak in remoting transport. Report URL: https://github.com/apache/pekko/action

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on PR #1635: URL: https://github.com/apache/pekko/pull/1635#issuecomment-2564373345 OK, Will split -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GH] (pekko): Workflow run "Build and test Pekko with Scala 3" is working again!

2024-12-28 Thread GitBox
The GitHub Actions job "Build and test Pekko with Scala 3" on pekko.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 918c448f1fb326348718981785536e44ec229f05 / He-Pin chore: Turn on Netty's leak detector in build. Report URL: https://github.com/

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on code in PR #1635: URL: https://github.com/apache/pekko/pull/1635#discussion_r1898916610 ## remote/src/main/scala/org/apache/pekko/remote/transport/netty/TcpSupport.scala: ## @@ -56,8 +58,16 @@ private[remote] trait TcpHandlers extends CommonHandlers { }

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on PR #1635: URL: https://github.com/apache/pekko/pull/1635#issuecomment-2564365975 I would prefer if the exception handling changes were tracked separately - separate issue with a description of why the existing exception handling is wrong - and separate PR. I th

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on code in PR #1635: URL: https://github.com/apache/pekko/pull/1635#discussion_r1898944106 ## remote/src/main/scala/org/apache/pekko/remote/transport/netty/TcpSupport.scala: ## @@ -56,8 +58,16 @@ private[remote] trait TcpHandlers extends CommonHandlers { }

[GH] (pekko): Workflow run "Build and test Pekko with Scala 3" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Build and test Pekko with Scala 3" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: e9fa6932510610895826ee94f32180ece0a49b34 / He-Pin fix: Fix ByteBuf leak in remoting transport. Report URL: https://github.com/apach

[GH] (pekko): Workflow run "Build and test Pekko with Scala 3" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Build and test Pekko with Scala 3" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 7d662ee38528823715cb5e3723136be385a33bf7 / He-Pin fix: Fix ByteBuf leak in remoting transport. Report URL: https://github.com/apach

[GH] (pekko): Workflow run "Pull Requests" is working again!

2024-12-28 Thread GitBox
The GitHub Actions job "Pull Requests" on pekko.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 918c448f1fb326348718981785536e44ec229f05 / He-Pin chore: Turn on Netty's leak detector in build. Report URL: https://github.com/apache/pekko/actions/

[GH] (pekko): Workflow run "Pull Requests" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Pull Requests" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 7d662ee38528823715cb5e3723136be385a33bf7 / He-Pin fix: Fix ByteBuf leak in remoting transport. Report URL: https://github.com/apache/pekko/actions/runs/

[GH] (pekko): Workflow run "Pull Requests" failed!

2024-12-28 Thread GitBox
The GitHub Actions job "Pull Requests" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: e9fa6932510610895826ee94f32180ece0a49b34 / He-Pin fix: Fix ByteBuf leak in remoting transport. Report URL: https://github.com/apache/pekko/actions/runs/

Re: [I] Maybe memory leak in Netty 4 transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on issue #1634: URL: https://github.com/apache/pekko/issues/1634#issuecomment-2564359173 @pjfanning Sorry,I wrong linked , have updated to the right link -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] chore: Turn on Netty's leak detector in build. [pekko]

2024-12-28 Thread via GitHub
He-Pin opened a new pull request, #1637: URL: https://github.com/apache/pekko/pull/1637 Motivation: refs: Turn on Netty's leak detector to avoid for https://github.com/apache/pekko/issues/1634 Modification: turn on the leak detector. Result: Will get logged in the

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on code in PR #1635: URL: https://github.com/apache/pekko/pull/1635#discussion_r1898917450 ## multi-node-testkit/src/main/scala/org/apache/pekko/remote/testconductor/RemoteConnection.scala: ## @@ -56,8 +56,15 @@ private[pekko] class ProtobufEncoder extends Mess

Re: [I] Maybe memory leak in Netty 4 transport. [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on issue #1634: URL: https://github.com/apache/pekko/issues/1634#issuecomment-2564342806 @He-Pin you linked https://issues.apache.org/jira/browse/FLINK-36788 - I don't understand why. The real issue appears to be https://issues.apache.org/jira/browse/FLINK-36510 -- Th

Re: [I] Maybe memory leak in Netty 4 transport. [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on issue #1634: URL: https://github.com/apache/pekko/issues/1634#issuecomment-2564342275 We now have https://github.com/apache/pekko/pull/1635 but can we take a little bit of time and care. There is no point rushing this. The change is not really usable until we do a rel

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on PR #1636: URL: https://github.com/apache/pekko/pull/1636#issuecomment-2564341741 This should not be attempted while #1636. We need 1 PR to review, not 2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
pjfanning closed pull request #1636: fix: Fix ByteBuf leak in remoting transport. URL: https://github.com/apache/pekko/pull/1636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on code in PR #1635: URL: https://github.com/apache/pekko/pull/1635#discussion_r1898916610 ## remote/src/main/scala/org/apache/pekko/remote/transport/netty/TcpSupport.scala: ## @@ -56,8 +58,16 @@ private[remote] trait TcpHandlers extends CommonHandlers { }

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on PR #1636: URL: https://github.com/apache/pekko/pull/1636#issuecomment-2564340696 changed back to main branch - the PR was messed up when it was set to merge to 1.1.x branch and would have brought lots of unrelated changes -- This is an automated message from the Apa

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on code in PR #1635: URL: https://github.com/apache/pekko/pull/1635#discussion_r1898915568 ## multi-node-testkit/src/main/scala/org/apache/pekko/remote/testconductor/RemoteConnection.scala: ## @@ -56,8 +56,15 @@ private[pekko] class ProtobufEncoder extends Mess

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on code in PR #1635: URL: https://github.com/apache/pekko/pull/1635#discussion_r1898915474 ## multi-node-testkit/src/main/scala/org/apache/pekko/remote/testconductor/RemoteConnection.scala: ## @@ -56,8 +56,15 @@ private[pekko] class ProtobufEncoder extends M

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on code in PR #1635: URL: https://github.com/apache/pekko/pull/1635#discussion_r1898915474 ## multi-node-testkit/src/main/scala/org/apache/pekko/remote/testconductor/RemoteConnection.scala: ## @@ -56,8 +56,15 @@ private[pekko] class ProtobufEncoder extends M

Re: [PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on code in PR #1635: URL: https://github.com/apache/pekko/pull/1635#discussion_r1898915322 ## multi-node-testkit/src/main/scala/org/apache/pekko/remote/testconductor/RemoteConnection.scala: ## @@ -56,8 +56,15 @@ private[pekko] class ProtobufEncoder extends M

[PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin opened a new pull request, #1636: URL: https://github.com/apache/pekko/pull/1636 Motivation: refs: https://github.com/apache/pekko/issues/1634 Modification: Call byteBuf.release after bytes read. Result: No leaks. Sorry for everyone. It's using reta

[PR] fix: Fix ByteBuf leak in remoting transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin opened a new pull request, #1635: URL: https://github.com/apache/pekko/pull/1635 Motivation: refs: https://github.com/apache/pekko/issues/1634 Modification: Call `byteBuf.release` after bytes read. Result: No leaks. Sorry for everyone. -- This is an aut

Re: [I] Maybe memory leak in Netty 4 transport. [pekko]

2024-12-28 Thread via GitHub
pjfanning commented on issue #1634: URL: https://github.com/apache/pekko/issues/1634#issuecomment-2564338163 The link makes no mention of Pekko. Can you remove the labels (bug and backport) until there is Pekko specific POC for this? -- This is an automated message from the Apache Git Ser

[I] Maybe memory leak in Netty 4 transport. [pekko]

2024-12-28 Thread via GitHub
He-Pin opened a new issue, #1634: URL: https://github.com/apache/pekko/issues/1634 refs: https://issues.apache.org/jira/browse/FLINK-36788?jql=project%20%3D%20FLINK%20AND%20fixVersion%20%3D%201.19.2 I think there will be some leak, eg, not calling `ByteBuf.release` somewhere.

Re: [I] limit spin loop in TLSActor [pekko]

2024-12-28 Thread via GitHub
He-Pin commented on issue #1633: URL: https://github.com/apache/pekko/issues/1633#issuecomment-2564328411 Close it now, after checking the code, it's been fixed by @pjfanning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] limit spin loop in TLSActor [pekko]

2024-12-28 Thread via GitHub
He-Pin closed issue #1633: limit spin loop in TLSActor URL: https://github.com/apache/pekko/issues/1633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >