Kami commented on code in PR #1967:
URL: https://github.com/apache/libcloud/pull/1967#discussion_r1413052187
##
libcloud/dns/drivers/godaddy.py:
##
@@ -288,12 +288,13 @@ def get_zone(self, zone_id):
"""
Get a zone (by domain)
-:param zone_id: The dom
Kami commented on PR #1967:
URL: https://github.com/apache/libcloud/pull/1967#issuecomment-1837448385
@Circuitsoft It appears tests are also failing.
```
>domain, = [x.domain for x in self.list_zones() if x.id == zone_id]
E ValueError: not enough values to unpack
Kami commented on PR #1967:
URL: https://github.com/apache/libcloud/pull/1967#issuecomment-1783866902
@Circuitsoft Thanks for the contribution.
Since this is a breaking change, can you please add an entry to
`docs/upgrade_notes.rst` file? You should be able to find some examples on ho
Circuitsoft opened a new pull request, #1967:
URL: https://github.com/apache/libcloud/pull/1967
Other drivers take the ID, not the domain name. This puts the GoDaddy driver
in-line with how other drivers work.
## Changes Title (replace this with a logical title for your changes)
