Circuitsoft opened a new pull request, #1967: URL: https://github.com/apache/libcloud/pull/1967
Other drivers take the ID, not the domain name. This puts the GoDaddy driver in-line with how other drivers work. ## Changes Title (replace this with a logical title for your changes) ### Description Saltstack has been throwing errors when working with GoDaddy dns entries because the driver takes different parameters than other drivers it was designed around. This fixes the interface to put it more in-line with other drivers. ### Status done, ready for review ### Checklist (tick everything that applies) - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [ ] Documentation - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
