[GitHub] [ignite-3] tkalkirill merged pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-23 Thread via GitHub
tkalkirill merged PR #2228: URL: https://github.com/apache/ignite-3/pull/2228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] korlov42 merged pull request #2244: IGNITE-19815 Make ItTableScanTest resilient

2023-06-23 Thread via GitHub
korlov42 merged PR #2244: URL: https://github.com/apache/ignite-3/pull/2244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite-3] tkalkirill opened a new pull request, #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-23 Thread via GitHub
tkalkirill opened a new pull request, #2247: URL: https://github.com/apache/ignite-3/pull/2247 https://issues.apache.org/jira/browse/IGNITE-19798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite-3] AMashenkov merged pull request #2202: IGNITE-19621 Sql. Shrink planner search space by removing pre known not applicable indexes

2023-06-23 Thread via GitHub
AMashenkov merged PR #2202: URL: https://github.com/apache/ignite-3/pull/2202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2248: IGNITE-19626 .NET: Propagate compute deployment units

2023-06-23 Thread via GitHub
ptupitsyn opened a new pull request, #2248: URL: https://github.com/apache/ignite-3/pull/2248 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-23 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1239901297 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/ScannableTableSelfTest.java: ## @@ -0,0 +1,961 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-23 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1239908977 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/ScannableTableSelfTest.java: ## @@ -0,0 +1,961 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-23 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1239908411 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/ScannableTableSelfTest.java: ## @@ -0,0 +1,961 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-23 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1239909194 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/ScannableTableSelfTest.java: ## @@ -0,0 +1,961 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-23 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1239908411 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/ScannableTableSelfTest.java: ## @@ -0,0 +1,961 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-23 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1239908411 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/ScannableTableSelfTest.java: ## @@ -0,0 +1,961 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-3] lowka commented on pull request #2196: IGNITE-19615: Index is not used while performing SELECT over an indexed column.

2023-06-23 Thread via GitHub
lowka commented on PR #2196: URL: https://github.com/apache/ignite-3/pull/2196#issuecomment-160431 > After this patch an index is used indeed. But resulting plan is rather invalid. For a query like `SELECT val FROM my WHERE id = 100500`, where `id` is of type TINYINT, I've got following

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-23 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1239928045 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/ScannableTableSelfTest.java: ## @@ -0,0 +1,961 @@ +/* + * Licensed to the Apache Softw

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-23 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1239931055 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/ScannableTableSelfTest.java: ## @@ -0,0 +1,961 @@ +/* + * Licensed to the Apache Softw

[GitHub] [ignite-3] lowka commented on pull request #2196: IGNITE-19615: Index is not used while performing SELECT over an indexed column.

2023-06-23 Thread via GitHub
lowka commented on PR #2196: URL: https://github.com/apache/ignite-3/pull/2196#issuecomment-1604448948 Optimiser starts from: > LogicalProject(VAL=[$1]), id = 116 > LogicalFilter(condition=[=(CAST($0):INTEGER NOT NULL, 100500)]), id = 114 > IgniteLogicalTableScan(table=[[PU

[GitHub] [ignite-3] lowka commented on pull request #2196: IGNITE-19615: Index is not used while performing SELECT over an indexed column.

2023-06-23 Thread via GitHub
lowka commented on PR #2196: URL: https://github.com/apache/ignite-3/pull/2196#issuecomment-1604466190 Yep. Types are correct. > SqlValidator BINARY_COMPARISON: CAST(`MY`.`ID` AS INTEGER) = 100500 types: INTEGER INTEGER So the problem should be in SearchBound assembly code.

[GitHub] [ignite-extensions] nizhikov opened a new pull request, #217: IGNITE-19677 Management API OpenAPI invoker plugin implemented

2023-06-23 Thread via GitHub
nizhikov opened a new pull request, #217: URL: https://github.com/apache/ignite-extensions/pull/217 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [ignite] rajsolanki73 opened a new issue, #10803: GridDiagnostic warning while starting ignite 2.15.0

2023-06-23 Thread via GitHub
rajsolanki73 opened a new issue, #10803: URL: https://github.com/apache/ignite/issues/10803 I see this following in log. [2023-06-23T13:10:31,168][WARN ][pub-#21][GridDiagnostic] Initial heap size is 248MB (should be no less than 512MB, use -Xms512m -Xmx512m). in https://githu

[GitHub] [ignite-3] lowka commented on a diff in pull request #2214: IGNITE-19654: remove redundant planing timeout and use correct one.

2023-06-23 Thread via GitHub
lowka commented on code in PR #2214: URL: https://github.com/apache/ignite-3/pull/2214#discussion_r1240197198 ## modules/jdbc/src/test/java/org/apache/ignite/internal/jdbc/PreparedStatementParamsTest.java: ## @@ -61,25 +62,28 @@ public class PreparedStatementParamsTest {

[GitHub] [ignite-3] lowka commented on a diff in pull request #2214: IGNITE-19654: remove redundant planing timeout and use correct one.

2023-06-23 Thread via GitHub
lowka commented on code in PR #2214: URL: https://github.com/apache/ignite-3/pull/2214#discussion_r1240205498 ## modules/jdbc/src/test/java/org/apache/ignite/internal/jdbc/PreparedStatementParamsTest.java: ## @@ -61,25 +62,28 @@ public class PreparedStatementParamsTest {

[GitHub] [ignite-3] Flaugh24 opened a new pull request, #2250: IGNITE-19689 fix ItClusterManagerTest.testClusterConfigurationIsRemovedFromClusterStateAfterUpdating

2023-06-25 Thread via GitHub
Flaugh24 opened a new pull request, #2250: URL: https://github.com/apache/ignite-3/pull/2250 Increase timeout of electing a new leader -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [ignite-3] PakhomovAlexander merged pull request #2207: IGNITE-19760 Create cluster status before deployment unit files uploading

2023-06-25 Thread via GitHub
PakhomovAlexander merged PR #2207: URL: https://github.com/apache/ignite-3/pull/2207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [ignite-3] kgusakov opened a new pull request, #2252: IGNITE-19724 Removed redundant joins

2023-06-25 Thread via GitHub
kgusakov opened a new pull request, #2252: URL: https://github.com/apache/ignite-3/pull/2252 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2251: IGNITE-19831 Rename RaftManager methods to better reflect their behavior

2023-06-25 Thread via GitHub
tkalkirill commented on code in PR #2251: URL: https://github.com/apache/ignite-3/pull/2251#discussion_r1241526721 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/RaftManager.java: ## @@ -26,61 +26,91 @@ /** * Raft manager. + * + * This class contains two

[GitHub] [ignite-3] tkalkirill opened a new pull request, #2254: IGNITE-19500 IndexManager should listen CatalogService events instead of configuration

2023-06-25 Thread via GitHub
tkalkirill opened a new pull request, #2254: URL: https://github.com/apache/ignite-3/pull/2254 https://issues.apache.org/jira/browse/IGNITE-19500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite-3] tkalkirill closed pull request #2242: IGNITE-19500 IndexManager should listen CatalogService events instead of configuration

2023-06-25 Thread via GitHub
tkalkirill closed pull request #2242: IGNITE-19500 IndexManager should listen CatalogService events instead of configuration URL: https://github.com/apache/ignite-3/pull/2242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2251: IGNITE-19831 Rename RaftManager methods to better reflect their behavior

2023-06-25 Thread via GitHub
sashapolo commented on code in PR #2251: URL: https://github.com/apache/ignite-3/pull/2251#discussion_r1241663749 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/OnRevisionAppliedCallback.java: ## @@ -29,7 +29,7 @@ public interface OnRevisionAp

[GitHub] [ignite-3] lowka commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-06-25 Thread via GitHub
lowka commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1241659499 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java: ## @@ -141,8 +164,59 @@ public void stop() throws Exception {

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2251: IGNITE-19831 Rename RaftManager methods to better reflect their behavior

2023-06-26 Thread via GitHub
tkalkirill commented on code in PR #2251: URL: https://github.com/apache/ignite-3/pull/2251#discussion_r1241711357 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/OnRevisionAppliedCallback.java: ## @@ -29,7 +29,7 @@ public interface OnRevisionA

[GitHub] [ignite-3] zstan merged pull request #2234: IGNITE-19803 Sql. Change erroneously annotated tests

2023-06-26 Thread via GitHub
zstan merged PR #2234: URL: https://github.com/apache/ignite-3/pull/2234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2251: IGNITE-19831 Rename RaftManager methods to better reflect their behavior

2023-06-26 Thread via GitHub
sashapolo commented on code in PR #2251: URL: https://github.com/apache/ignite-3/pull/2251#discussion_r1241727243 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/OnRevisionAppliedCallback.java: ## @@ -29,7 +29,7 @@ public interface OnRevisionAp

[GitHub] [ignite] Indupa commented on issue #10747: Does Apache Ignite 2.15.0 Runs using OpenJDK 17 version ......?

2023-06-26 Thread via GitHub
Indupa commented on issue #10747: URL: https://github.com/apache/ignite/issues/10747#issuecomment-1606857334 Hi , In our project , ignite is started using "Topshelf" command to run as windows service by passing JAVA_HOME as one of the Argument. when i tried to run Apche Ignite 2.1

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2233: IGNITE-19693 getAll does not preserve order and does not return nulls for missing keys

2023-06-26 Thread via GitHub
rpuch commented on code in PR #2233: URL: https://github.com/apache/ignite-3/pull/2233#discussion_r1241713092 ## modules/api/src/main/java/org/apache/ignite/table/RecordView.java: ## @@ -55,18 +56,20 @@ public interface RecordView extends DataStreamerTarget { * @param key

[GitHub] [ignite-3] isapego commented on a diff in pull request #2248: IGNITE-19626 .NET: Propagate compute deployment units

2023-06-26 Thread via GitHub
isapego commented on code in PR #2248: URL: https://github.com/apache/ignite-3/pull/2248#discussion_r1241734233 ## modules/platforms/dotnet/Apache.Ignite/Compute/ICompute.cs: ## @@ -15,60 +15,81 @@ * limitations under the License. */ -namespace Apache.Ignite.Compute -{ -

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2224: IGNITE-17770 ItIgniteNodeRestartTest.testCfgGap is flaky

2023-06-26 Thread via GitHub
sk0x50 commented on code in PR #2224: URL: https://github.com/apache/ignite-3/pull/2224#discussion_r1241722933 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java: ## @@ -1229,9 +1228,20 @@ private static void checkTableW

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2233: IGNITE-19693 getAll does not preserve order and does not return nulls for missing keys

2023-06-26 Thread via GitHub
tkalkirill commented on code in PR #2233: URL: https://github.com/apache/ignite-3/pull/2233#discussion_r1241745285 ## modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientKeyValueView.java: ## @@ -464,11 +464,12 @@ private HashMap readGetAllResponse(ClientS

[GitHub] [ignite-3] tkalkirill merged pull request #2233: IGNITE-19693 getAll does not preserve order and does not return nulls for missing keys

2023-06-26 Thread via GitHub
tkalkirill merged PR #2233: URL: https://github.com/apache/ignite-3/pull/2233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2248: IGNITE-19626 .NET: Propagate compute deployment units

2023-06-26 Thread via GitHub
rpuch commented on code in PR #2248: URL: https://github.com/apache/ignite-3/pull/2248#discussion_r1241761767 ## modules/compute/src/main/java/org/apache/ignite/internal/compute/ComputeComponentImpl.java: ## @@ -238,12 +238,15 @@ private void processExecuteRequest(ExecuteRequest

[GitHub] [ignite-3] tkalkirill merged pull request #2251: IGNITE-19831 Rename RaftManager methods to better reflect their behavior

2023-06-26 Thread via GitHub
tkalkirill merged PR #2251: URL: https://github.com/apache/ignite-3/pull/2251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #2224: IGNITE-17770 ItIgniteNodeRestartTest.testCfgGap is flaky

2023-06-26 Thread via GitHub
denis-chudov commented on code in PR #2224: URL: https://github.com/apache/ignite-3/pull/2224#discussion_r1241817705 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -446,14 +446,16 @@ private CompletableFuture en

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
ibessonov commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241761480 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogService.java: ## @@ -44,6 +44,8 @@ public interface CatalogService { CatalogTableDe

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
tkalkirill commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241826467 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -191,6 +191,12 @@ public CatalogTableDescriptor table(int tableId

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
tkalkirill commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241829741 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/DropZoneEventParameters.java: ## @@ -30,8 +30,8 @@ public class DropZoneEventParameters e

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
tkalkirill commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241830203 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java: ## @@ -1250,24 +1286,31 @@ public void testCreateIndexEvents() {

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
tkalkirill commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241830620 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java: ## @@ -1638,6 +1681,78 @@ void testGetCatalogEntityInCatalogEvent()

[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #2224: IGNITE-17770 ItIgniteNodeRestartTest.testCfgGap is flaky

2023-06-26 Thread via GitHub
denis-chudov commented on code in PR #2224: URL: https://github.com/apache/ignite-3/pull/2224#discussion_r1241835894 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java: ## @@ -1229,9 +1228,20 @@ private static void check

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
tkalkirill commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241836962 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -877,4 +886,24 @@ private static void validateAlterTableColumn(

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
tkalkirill commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241839211 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -295,7 +306,7 @@ public CompletableFuture dropTable(DropTablePara

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
tkalkirill commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241839866 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -877,4 +886,24 @@ private static void validateAlterTableColumn(

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
tkalkirill commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241839866 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -877,4 +886,24 @@ private static void validateAlterTableColumn(

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
tkalkirill commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241843388 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -275,11 +281,16 @@ public CompletableFuture createTable(CreateTa

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
tkalkirill commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241845381 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogService.java: ## @@ -44,6 +44,8 @@ public interface CatalogService { CatalogTableD

[GitHub] [ignite-3] valepakh commented on a diff in pull request #2219: IGNITE-19708 Check refcounter of unit before undeploy

2023-06-26 Thread via GitHub
valepakh commented on code in PR #2219: URL: https://github.com/apache/ignite-3/pull/2219#discussion_r1241835616 ## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/DefaultNodeCallback.java: ## @@ -53,20 +56,23 @@ public class DefaultNodeCallback exten

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
ibessonov commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241857900 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogService.java: ## @@ -44,6 +44,8 @@ public interface CatalogService { CatalogTableDe

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
ibessonov commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241859836 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -275,11 +281,16 @@ public CompletableFuture createTable(CreateTab

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2237: IGNITE-19777 Perform local metastorage recovery

2023-06-26 Thread via GitHub
sashapolo commented on code in PR #2237: URL: https://github.com/apache/ignite-3/pull/2237#discussion_r1241811950 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -691,14 +691,24 @@ public CompletableFuture start(Path configPath) {

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
ibessonov commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241861239 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -295,7 +306,7 @@ public CompletableFuture dropTable(DropTableParam

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
ibessonov commented on code in PR #2247: URL: https://github.com/apache/ignite-3/pull/2247#discussion_r1241861656 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -877,4 +886,24 @@ private static void validateAlterTableColumn(

[GitHub] [ignite-3] tkalkirill merged pull request #2247: IGNITE-19798 Add functionality to the catalog to switch the IndexManager to catalog events

2023-06-26 Thread via GitHub
tkalkirill merged PR #2247: URL: https://github.com/apache/ignite-3/pull/2247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #2248: IGNITE-19626 .NET: Propagate compute deployment units

2023-06-26 Thread via GitHub
ptupitsyn commented on code in PR #2248: URL: https://github.com/apache/ignite-3/pull/2248#discussion_r1241900982 ## modules/platforms/dotnet/Apache.Ignite/Compute/ICompute.cs: ## @@ -15,60 +15,81 @@ * limitations under the License. */ -namespace Apache.Ignite.Compute -{ -

[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #2248: IGNITE-19626 .NET: Propagate compute deployment units

2023-06-26 Thread via GitHub
ptupitsyn commented on code in PR #2248: URL: https://github.com/apache/ignite-3/pull/2248#discussion_r1241900982 ## modules/platforms/dotnet/Apache.Ignite/Compute/ICompute.cs: ## @@ -15,60 +15,81 @@ * limitations under the License. */ -namespace Apache.Ignite.Compute -{ -

[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #2248: IGNITE-19626 .NET: Propagate compute deployment units

2023-06-26 Thread via GitHub
ptupitsyn commented on code in PR #2248: URL: https://github.com/apache/ignite-3/pull/2248#discussion_r1241902746 ## modules/compute/src/main/java/org/apache/ignite/internal/compute/ComputeComponentImpl.java: ## @@ -238,12 +238,15 @@ private void processExecuteRequest(ExecuteReq

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2237: IGNITE-19777 Perform local metastorage recovery

2023-06-26 Thread via GitHub
SammyVimes commented on code in PR #2237: URL: https://github.com/apache/ignite-3/pull/2237#discussion_r1241942617 ## modules/runner/src/main/java/org/apache/ignite/internal/recovery/ConfigurationCatchUpListener.java: ## @@ -84,6 +84,7 @@ private boolean isConfigurationUpToDate(

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2237: IGNITE-19777 Perform local metastorage recovery

2023-06-26 Thread via GitHub
SammyVimes commented on code in PR #2237: URL: https://github.com/apache/ignite-3/pull/2237#discussion_r1241943596 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -148,6 +158,60 @@ public MetaStorageManagerImpl(

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2237: IGNITE-19777 Perform local metastorage recovery

2023-06-26 Thread via GitHub
SammyVimes commented on code in PR #2237: URL: https://github.com/apache/ignite-3/pull/2237#discussion_r1241946230 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java: ## @@ -719,11 +732,66 @@ public void nodeWithDataTest

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2237: IGNITE-19777 Perform local metastorage recovery

2023-06-26 Thread via GitHub
SammyVimes commented on code in PR #2237: URL: https://github.com/apache/ignite-3/pull/2237#discussion_r1241947584 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java: ## @@ -719,11 +732,66 @@ public void nodeWithDataTest

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-06-26 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1607141984 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2237: IGNITE-19777 Perform local metastorage recovery

2023-06-26 Thread via GitHub
SammyVimes commented on code in PR #2237: URL: https://github.com/apache/ignite-3/pull/2237#discussion_r1241952681 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerRecoveryTest.java: ## @@ -0,0 +1,176 @@ +/* + * Licensed to the A

[GitHub] [ignite-3] PakhomovAlexander merged pull request #2216: IGNITE-19450 Add * char to latest version of unit in list command

2023-06-26 Thread via GitHub
PakhomovAlexander merged PR #2216: URL: https://github.com/apache/ignite-3/pull/2216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-26 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1242013058 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/ScannableTableSelfTest.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-26 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1242013058 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/ScannableTableSelfTest.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-3] AMashenkov merged pull request #2205: IGNITE-19755: move common test classes to testFixtures for runner module

2023-06-26 Thread via GitHub
AMashenkov merged PR #2205: URL: https://github.com/apache/ignite-3/pull/2205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-26 Thread via GitHub
sanpwc commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1241987943 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapper.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-26 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1242072073 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapper.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-06-26 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1607303293 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-26 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1242080574 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapper.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-26 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1242080574 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapper.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-26 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1242093277 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapper.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-26 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1242109276 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-26 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r124223 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/ScannableTableSelfTest.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache Softw

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-26 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1242111422 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-26 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1242112542 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionUtils.java: ## @@ -177,14 +177,15 @@ public static int extractCodeFrom(Throwable t) { return

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-26 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1242149763 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-26 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1242150615 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-06-26 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1607479713 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] ademakov opened a new pull request, #2256: IGNITE-19666 Remove nullmaps from binary tuples in C++

2023-06-26 Thread via GitHub
ademakov opened a new pull request, #2256: URL: https://github.com/apache/ignite-3/pull/2256 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-06-26 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1607528971 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-extensions] shishkovilja opened a new pull request, #218: IGNITE-19368 Fix ignite-cdc-ext assembly: bring back kafka-clients an…

2023-06-26 Thread via GitHub
shishkovilja opened a new pull request, #218: URL: https://github.com/apache/ignite-extensions/pull/218 …d slf4j-api -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [ignite-3] ptupitsyn merged pull request #2248: IGNITE-19626 .NET: Propagate compute deployment units

2023-06-26 Thread via GitHub
ptupitsyn merged PR #2248: URL: https://github.com/apache/ignite-3/pull/2248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite] alex-plekhanov opened a new pull request, #10804: IGNITE-19818 SQL Calcite: Fix failure on planning when cache size exc…

2023-06-26 Thread via GitHub
alex-plekhanov opened a new pull request, #10804: URL: https://github.com/apache/ignite/pull/10804 …eeds Integer.MAX_VALUE Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10804: IGNITE-19818 SQL Calcite: Fix failure on planning when cache size exc…

2023-06-26 Thread via GitHub
sonarcloud[bot] commented on PR #10804: URL: https://github.com/apache/ignite/pull/10804#issuecomment-1607701876 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-06-26 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1607705205 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] anton-vinogradov opened a new pull request, #10805: IGNITE-19845 IgniteTxLocalAdapter.sndTransformedVals field removal

2023-06-26 Thread via GitHub
anton-vinogradov opened a new pull request, #10805: URL: https://github.com/apache/ignite/pull/10805 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10805: IGNITE-19845 IgniteTxLocalAdapter.sndTransformedVals field removal

2023-06-26 Thread via GitHub
sonarcloud[bot] commented on PR #10805: URL: https://github.com/apache/ignite/pull/10805#issuecomment-1607742644 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-06-26 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1607758549 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10775: IGNITE-19676 Command JMX Invoker

2023-06-26 Thread via GitHub
sonarcloud[bot] commented on PR #10775: URL: https://github.com/apache/ignite/pull/10775#issuecomment-1607787161 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-26 Thread via GitHub
sanpwc commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1242434599 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapper.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-26 Thread via GitHub
sanpwc commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1242448068 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10775: IGNITE-19676 Command JMX Invoker

2023-06-26 Thread via GitHub
sonarcloud[bot] commented on PR #10775: URL: https://github.com/apache/ignite/pull/10775#issuecomment-1607829831 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] ademakov commented on a diff in pull request #2239: IGNITE-19199 Propagate safe time when Meta Storage is idle

2023-06-26 Thread via GitHub
ademakov commented on code in PR #2239: URL: https://github.com/apache/ignite-3/pull/2239#discussion_r1242466447 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageLeaderElectionListener.java: ## @@ -62,87 +66,108 @@ public class MetaStor

<    2   3   4   5   6   7   8   9   10   11   >