tkalkirill commented on code in PR #2233:
URL: https://github.com/apache/ignite-3/pull/2233#discussion_r1241745285
##########
modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientKeyValueView.java:
##########
@@ -464,11 +464,12 @@ private HashMap<K, V> readGetAllResponse(ClientSchema
schema, ClientMessageUnpac
try {
for (int i = 0; i < cnt; i++) {
- in.unpackBoolean(); // TODO: Optimize (IGNITE-16022).
-
- var tupleReader = new
BinaryTupleReader(schema.columns().length, in.readBinaryUnsafe());
- var reader = new ClientMarshallerReader(tupleReader);
- res.put((K) keyMarsh.readObject(reader, null), (V)
valMarsh.readObject(reader, null));
+ // TODO: Optimize (IGNITE-16022).
+ if (in.unpackBoolean()) {
Review Comment:
I think yes, this part was done by @ptupitsyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
