[GitHub] [ignite] sonarcloud[bot] commented on pull request #10775: IGNITE-19676 Command JMX Invoker

2023-06-19 Thread via GitHub
sonarcloud[bot] commented on PR #10775: URL: https://github.com/apache/ignite/pull/10775#issuecomment-1597558530 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10775: IGNITE-19676 Command JMX Invoker

2023-06-19 Thread via GitHub
sonarcloud[bot] commented on PR #10775: URL: https://github.com/apache/ignite/pull/10775#issuecomment-1597606996 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] satishviswanathan commented on issue #10785: .NET library for integrating with NHibernate

2023-06-19 Thread via GitHub
satishviswanathan commented on issue #10785: URL: https://github.com/apache/ignite/issues/10785#issuecomment-1597649984 @ptupitsyn , thank you for sharing the info. I'm relatively new to ignite and still trying to figure it out. Appreciate your help. -- This is an automated message from

[GitHub] [ignite-3] denis-chudov opened a new pull request, #2221: IGNITE-19747 Fixed flaky ItRebalanceDistributedTest.testOnLeaderElectedRebalanceRestart

2023-06-19 Thread via GitHub
denis-chudov opened a new pull request, #2221: URL: https://github.com/apache/ignite-3/pull/2221 https://issues.apache.org/jira/browse/IGNITE-19747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite] ptupitsyn closed issue #10785: .NET library for integrating with NHibernate

2023-06-19 Thread via GitHub
ptupitsyn closed issue #10785: .NET library for integrating with NHibernate URL: https://github.com/apache/ignite/issues/10785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2222: IGNITE-19774 .NET: Fix IgniteClientTests.TestToString flakiness

2023-06-19 Thread via GitHub
ptupitsyn opened a new pull request, #: URL: https://github.com/apache/ignite-3/pull/ (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [ignite-3] isapego merged pull request #2191: IGNITE-19206 Re-factor ODBC connection info handling

2023-06-19 Thread via GitHub
isapego merged PR #2191: URL: https://github.com/apache/ignite-3/pull/2191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ign

[GitHub] [ignite-3] ptupitsyn merged pull request #2222: IGNITE-19774 .NET: Fix IgniteClientTests.TestToString flakiness

2023-06-19 Thread via GitHub
ptupitsyn merged PR #: URL: https://github.com/apache/ignite-3/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2172: IGNITE-19574 restore global states of DistributionZoneManager after restart

2023-06-19 Thread via GitHub
sanpwc commented on code in PR #2172: URL: https://github.com/apache/ignite-3/pull/2172#discussion_r1234813293 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/BaseIgniteRestartTest.java: ## @@ -0,0 +1,369 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2172: IGNITE-19574 restore global states of DistributionZoneManager after restart

2023-06-20 Thread via GitHub
sanpwc commented on code in PR #2172: URL: https://github.com/apache/ignite-3/pull/2172#discussion_r1234836916 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java: ## @@ -946,81 +955,11 @@ private void updateLogi

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2172: IGNITE-19574 restore global states of DistributionZoneManager after restart

2023-06-20 Thread via GitHub
sanpwc commented on code in PR #2172: URL: https://github.com/apache/ignite-3/pull/2172#discussion_r1234850732 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerConfigurationChangesTest.java: ## @@ -113,7 +116,12 @@ p

[GitHub] [ignite-3] zstan opened a new pull request, #2223: IGNITE-19668 Sql. Fix testLengthExpressionWithDynamicParameter

2023-06-20 Thread via GitHub
zstan opened a new pull request, #2223: URL: https://github.com/apache/ignite-3/pull/2223 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2172: IGNITE-19574 restore global states of DistributionZoneManager after restart

2023-06-20 Thread via GitHub
alievmirza commented on code in PR #2172: URL: https://github.com/apache/ignite-3/pull/2172#discussion_r1234868769 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java: ## @@ -946,81 +955,11 @@ private void update

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2209: IGNITE-19731 Fixed ItTableScanTest different test failed

2023-06-20 Thread via GitHub
sanpwc commented on code in PR #2209: URL: https://github.com/apache/ignite-3/pull/2209#discussion_r1234877316 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/SortedIndexLocker.java: ## @@ -100,7 +100,12 @@ public CompletableFuture locksForScan(UUID t

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2209: IGNITE-19731 Fixed ItTableScanTest different test failed

2023-06-20 Thread via GitHub
vldpyatkov commented on code in PR #2209: URL: https://github.com/apache/ignite-3/pull/2209#discussion_r1234888953 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/SortedIndexLocker.java: ## @@ -100,7 +100,12 @@ public CompletableFuture locksForScan(UU

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2218: IGNITE-19700 Added several optimizations for meta-storage reads.

2023-06-20 Thread via GitHub
rpuch commented on code in PR #2218: URL: https://github.com/apache/ignite-3/pull/2218#discussion_r1234918926 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -427,7 +436,7 @@ private void updateKey

[GitHub] [ignite-3] zstan commented on pull request #2223: IGNITE-19668 Sql. Fix testLengthExpressionWithDynamicParameter

2023-06-20 Thread via GitHub
zstan commented on PR #2223: URL: https://github.com/apache/ignite-3/pull/2223#issuecomment-1598372074 @lowka can u make a review plz ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2218: IGNITE-19700 Added several optimizations for meta-storage reads.

2023-06-20 Thread via GitHub
ibessonov commented on code in PR #2218: URL: https://github.com/apache/ignite-3/pull/2218#discussion_r1234962972 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -427,7 +436,7 @@ private void updat

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2218: IGNITE-19700 Added several optimizations for meta-storage reads.

2023-06-20 Thread via GitHub
ibessonov commented on code in PR #2218: URL: https://github.com/apache/ignite-3/pull/2218#discussion_r1234971871 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -239,20 +243,25 @@ public void star

[GitHub] [ignite-3] sk0x50 merged pull request #2212: IGNITE-19716 Added a temporary fix for AssertionError in randomNodes until IGNITE-19466 is resolved

2023-06-20 Thread via GitHub
sk0x50 merged PR #2212: URL: https://github.com/apache/ignite-3/pull/2212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[GitHub] [ignite-3] ibessonov merged pull request #2218: IGNITE-19700 Added several optimizations for meta-storage reads.

2023-06-20 Thread via GitHub
ibessonov merged PR #2218: URL: https://github.com/apache/ignite-3/pull/2218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] vldpyatkov merged pull request #2221: IGNITE-19747 Fixed flaky ItRebalanceDistributedTest.testOnLeaderElectedRebalanceRestart

2023-06-20 Thread via GitHub
vldpyatkov merged PR #2221: URL: https://github.com/apache/ignite-3/pull/2221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] sanpwc merged pull request #2172: IGNITE-19574 restore global states of DistributionZoneManager after restart

2023-06-20 Thread via GitHub
sanpwc merged PR #2172: URL: https://github.com/apache/ignite-3/pull/2172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[GitHub] [ignite] vshipb closed pull request #10789: IGNITE-19773 move Task classes into Command classes package

2023-06-20 Thread via GitHub
vshipb closed pull request #10789: IGNITE-19773 move Task classes into Command classes package URL: https://github.com/apache/ignite/pull/10789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ignite] vshipb opened a new pull request, #10790: IGNITE-19773 Move Encryption tasks classes to commands classes package

2023-06-20 Thread via GitHub
vshipb opened a new pull request, #10790: URL: https://github.com/apache/ignite/pull/10790 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### The

[GitHub] [ignite-3] denis-chudov opened a new pull request, #2224: IGNITE-17770 ItIgniteNodeRestartTest.testCfgGap is flaky

2023-06-20 Thread via GitHub
denis-chudov opened a new pull request, #2224: URL: https://github.com/apache/ignite-3/pull/2224 https://issues.apache.org/jira/browse/IGNITE-17770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10790: IGNITE-19773 Move Encryption tasks classes to commands classes package

2023-06-20 Thread via GitHub
sonarcloud[bot] commented on PR #10790: URL: https://github.com/apache/ignite/pull/10790#issuecomment-1598611569 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] sk0x50 opened a new pull request, #2225: IGNITE-19539 Added exception mapper utility

2023-06-20 Thread via GitHub
sk0x50 opened a new pull request, #2225: URL: https://github.com/apache/ignite-3/pull/2225 https://issues.apache.org/jira/browse/IGNITE-19539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [ignite] nizhikov merged pull request #10790: IGNITE-19773 Move Encryption tasks classes to commands classes package

2023-06-20 Thread via GitHub
nizhikov merged PR #10790: URL: https://github.com/apache/ignite/pull/10790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10790: IGNITE-19773 Move Encryption tasks classes to commands classes package

2023-06-20 Thread via GitHub
sonarcloud[bot] commented on PR #10790: URL: https://github.com/apache/ignite/pull/10790#issuecomment-1598640358 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] AMashenkov opened a new pull request, #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-06-20 Thread via GitHub
AMashenkov opened a new pull request, #2226: URL: https://github.com/apache/ignite-3/pull/2226 https://issues.apache.org/jira/browse/IGNITE-17765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite-3] AMashenkov commented on pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-06-20 Thread via GitHub
AMashenkov commented on PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#issuecomment-1598650926 - Implemented indirect cache for query plans: query string -> normalized query srting -> query plan - Fixed EXPLAIN to use cached plan - Tests added -- This is an automated me

[GitHub] [ignite-3] AMashenkov commented on pull request #2192: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-06-20 Thread via GitHub
AMashenkov commented on PR #2192: URL: https://github.com/apache/ignite-3/pull/2192#issuecomment-1598659423 - Cache plans for original query string as for normalized query string. Cache coherence for original and normalized string is not supported. - Fixed EXPLAIN to use cached plan -

[GitHub] [ignite] vshipb opened a new pull request, #10791: IGNITE-19779 move "Kill" task classes to "org.apache.ignite.internal.management.kill" package

2023-06-20 Thread via GitHub
vshipb opened a new pull request, #10791: URL: https://github.com/apache/ignite/pull/10791 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [ignite] nizhikov merged pull request #10791: IGNITE-19779 move "Kill" task classes to "org.apache.ignite.internal.management.kill" package

2023-06-20 Thread via GitHub
nizhikov merged PR #10791: URL: https://github.com/apache/ignite/pull/10791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10791: IGNITE-19779 move "Kill" task classes to "org.apache.ignite.internal.management.kill" package

2023-06-20 Thread via GitHub
sonarcloud[bot] commented on PR #10791: URL: https://github.com/apache/ignite/pull/10791#issuecomment-1598779605 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] vshipb opened a new pull request, #10792: IGNITE-19780 move Consistency Task classes into "org.apache.ignite.internal.management.consistency" package

2023-06-20 Thread via GitHub
vshipb opened a new pull request, #10792: URL: https://github.com/apache/ignite/pull/10792 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [ignite] nizhikov merged pull request #10792: IGNITE-19780 move Consistency Task classes into "org.apache.ignite.internal.management.consistency" package

2023-06-20 Thread via GitHub
nizhikov merged PR #10792: URL: https://github.com/apache/ignite/pull/10792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite] sk0x50 closed pull request #10264: IGNITE-17742 Fixed an issue that could lead to B+Tree corruption during attempt to write a large entry to atomic cache

2023-06-20 Thread via GitHub
sk0x50 closed pull request #10264: IGNITE-17742 Fixed an issue that could lead to B+Tree corruption during attempt to write a large entry to atomic cache URL: https://github.com/apache/ignite/pull/10264 -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10792: IGNITE-19780 move Consistency Task classes into "org.apache.ignite.internal.management.consistency" package

2023-06-20 Thread via GitHub
sonarcloud[bot] commented on PR #10792: URL: https://github.com/apache/ignite/pull/10792#issuecomment-1598849599 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] PakhomovAlexander merged pull request #2211: IGNITE-19651 Create internal representation of DeploymentUnit

2023-06-20 Thread via GitHub
PakhomovAlexander merged PR #2211: URL: https://github.com/apache/ignite-3/pull/2211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [ignite] vshipb opened a new pull request, #10793: IGNITE-19781 move Diagnostic and Meta task classes into "org.apache.ignite.internal.management" package

2023-06-20 Thread via GitHub
vshipb opened a new pull request, #10793: URL: https://github.com/apache/ignite/pull/10793 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [ignite-3] Pochatkin commented on a diff in pull request #2194: IGNITE-19519 Deployment unit removal

2023-06-20 Thread via GitHub
Pochatkin commented on code in PR #2194: URL: https://github.com/apache/ignite-3/pull/2194#discussion_r1235339202 ## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/metastore/ClusterEventCallback.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apach

[GitHub] [ignite-3] sergeyuttsel closed pull request #2217: IGNITE-19745 Prototype of revision awaiting.

2023-06-20 Thread via GitHub
sergeyuttsel closed pull request #2217: IGNITE-19745 Prototype of revision awaiting. URL: https://github.com/apache/ignite-3/pull/2217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10793: IGNITE-19781 move Diagnostic and Meta task classes into "org.apache.ignite.internal.management" package

2023-06-20 Thread via GitHub
sonarcloud[bot] commented on PR #10793: URL: https://github.com/apache/ignite/pull/10793#issuecomment-1598917668 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] nizhikov merged pull request #10793: IGNITE-19781 move Diagnostic and Meta task classes into "org.apache.ignite.internal.management" package

2023-06-20 Thread via GitHub
nizhikov merged PR #10793: URL: https://github.com/apache/ignite/pull/10793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite-3] valepakh commented on a diff in pull request #2194: IGNITE-19519 Deployment unit removal

2023-06-20 Thread via GitHub
valepakh commented on code in PR #2194: URL: https://github.com/apache/ignite-3/pull/2194#discussion_r1235370962 ## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/metastore/ClusterEventCallback.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10788: IGNITE-19725 WIP

2023-06-20 Thread via GitHub
sonarcloud[bot] commented on PR #10788: URL: https://github.com/apache/ignite/pull/10788#issuecomment-1599149419 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10775: IGNITE-19676 Command JMX Invoker

2023-06-20 Thread via GitHub
sonarcloud[bot] commented on PR #10775: URL: https://github.com/apache/ignite/pull/10775#issuecomment-1599217139 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10775: IGNITE-19676 Command JMX Invoker

2023-06-20 Thread via GitHub
sonarcloud[bot] commented on PR #10775: URL: https://github.com/apache/ignite/pull/10775#issuecomment-1599356084 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] satishviswanathan commented on issue #10785: .NET library for integrating with NHibernate

2023-06-20 Thread via GitHub
satishviswanathan commented on issue #10785: URL: https://github.com/apache/ignite/issues/10785#issuecomment-1600065143 @ptupitsyn I can see a library for entity framework library as well. Does both serve the same purpose ? -- This is an automated message from the Apache Git Service. To

[GitHub] [ignite] ptupitsyn commented on issue #10785: .NET library for integrating with NHibernate

2023-06-20 Thread via GitHub
ptupitsyn commented on issue #10785: URL: https://github.com/apache/ignite/issues/10785#issuecomment-1600270097 [Entity Framework](https://www.nuget.org/packages/Apache.Ignite.EntityFramework) provides second-level cache for the legacy EF on .NET Framework. It is a different thing. -- T

[GitHub] [ignite] vshipb opened a new pull request, #10794: IGNITE-19786 Move Persistence and Property task classes to command class packages

2023-06-21 Thread via GitHub
vshipb opened a new pull request, #10794: URL: https://github.com/apache/ignite/pull/10794 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10794: IGNITE-19786 Move Persistence and Property task classes to command class packages

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10794: URL: https://github.com/apache/ignite/pull/10794#issuecomment-1600334944 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236521082 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -319,6 +321,19 @@ public CompletableFuture get(ByteA

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236521868 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -60,6 +61,13 @@ public interface MetaStorageManager exten

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236524093 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorage.java: ## @@ -70,6 +70,16 @@ public interface KeyValueStorage extends

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236531427 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1215,6 +1227,54 @@ private Entry doGe

[GitHub] [ignite] nizhikov merged pull request #10794: IGNITE-19786 Move Persistence and Property task classes to command class packages

2023-06-21 Thread via GitHub
nizhikov merged PR #10794: URL: https://github.com/apache/ignite/pull/10794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236601472 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/BasicOperationsKeyValueStorageTest.java: ## @@ -190,6 +192,67 @@ void getWithRevision

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236604998 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/BasicOperationsKeyValueStorageTest.java: ## @@ -190,6 +192,67 @@ void getWithRevision

[GitHub] [ignite] vshipb opened a new pull request, #10795: IGNITE-19787 Move Snapshot and Wal task classes to command class packages

2023-06-21 Thread via GitHub
vshipb opened a new pull request, #10795: URL: https://github.com/apache/ignite/pull/10795 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [ignite-3] rpuch opened a new pull request, #2228: IGNITE-19209 Implement installing table schema updates

2023-06-21 Thread via GitHub
rpuch opened a new pull request, #2228: URL: https://github.com/apache/ignite-3/pull/2228 https://issues.apache.org/jira/browse/IGNITE-19209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2229: IGNITE-19560 Fix Netty buffer leak

2023-06-21 Thread via GitHub
ptupitsyn opened a new pull request, #2229: URL: https://github.com/apache/ignite-3/pull/2229 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236641674 ## modules/core/src/main/java/org/apache/ignite/spi/systemview/view/ServiceView.java: ## @@ -98,4 +99,14 @@ public boolean staticallyConfigured() { public UUID o

[GitHub] [ignite] nizhikov merged pull request #10795: IGNITE-19787 Move Snapshot and Wal task classes to command class packages

2023-06-21 Thread via GitHub
nizhikov merged PR #10795: URL: https://github.com/apache/ignite/pull/10795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
NSAmelchev commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236648958 ## modules/core/src/main/java/org/apache/ignite/spi/systemview/view/ServiceView.java: ## @@ -98,4 +99,14 @@ public boolean staticallyConfigured() { public UUID

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10795: IGNITE-19787 Move Snapshot and Wal task classes to command class packages

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10795: URL: https://github.com/apache/ignite/pull/10795#issuecomment-1600456373 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10783: URL: https://github.com/apache/ignite/pull/10783#issuecomment-1600462939 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r123941 ## modules/core/src/test/java/org/apache/ignite/internal/metric/SystemViewSelfTest.java: ## @@ -289,6 +289,7 @@ public void testServices() throws Exception {

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
NSAmelchev commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236667771 ## modules/core/src/test/java/org/apache/ignite/internal/metric/SystemViewSelfTest.java: ## @@ -289,6 +289,7 @@ public void testServices() throws Exception {

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10783: URL: https://github.com/apache/ignite/pull/10783#issuecomment-1600481069 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236677583 ## modules/control-utility/src/test/java/org/apache/ignite/util/SystemViewCommandTest.java: ## @@ -346,6 +346,7 @@ public void testServices() { assertEquals(

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236677583 ## modules/control-utility/src/test/java/org/apache/ignite/util/SystemViewCommandTest.java: ## @@ -346,6 +346,7 @@ public void testServices() { assertEquals(

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236694204 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TransformingPublisher.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236697380 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TransformingPublisher.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite] vshipb opened a new pull request, #10796: IGNITE-19754 Move remaining Cache classes to command classes package

2023-06-21 Thread via GitHub
vshipb opened a new pull request, #10796: URL: https://github.com/apache/ignite/pull/10796 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
NSAmelchev commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236701307 ## modules/control-utility/src/test/java/org/apache/ignite/util/SystemViewCommandTest.java: ## @@ -346,6 +346,7 @@ public void testServices() { assertEqual

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236703915 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TransformingPublisher.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10783: URL: https://github.com/apache/ignite/pull/10783#issuecomment-1600515645 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236709047 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TransformingPublisher.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236712245 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java: ## @@ -63,6 +72,113 @@ public Publisher scan(ExecutionConte

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236717349 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java: ## @@ -63,6 +72,113 @@ public Publisher scan(ExecutionConte

[GitHub] [ignite] nizhikov merged pull request #10796: IGNITE-19754 Move remaining Cache classes to command classes package

2023-06-21 Thread via GitHub
nizhikov merged PR #10796: URL: https://github.com/apache/ignite/pull/10796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-21 Thread via GitHub
ibessonov commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236693712 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperFuture.java: ## @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10796: IGNITE-19754 Move remaining Cache classes to command classes package

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10796: URL: https://github.com/apache/ignite/pull/10796#issuecomment-1600529803 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236719996 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java: ## @@ -63,6 +72,113 @@ public Publisher scan(ExecutionConte

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-21 Thread via GitHub
ibessonov commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236712924 ## modules/api/src/test/java/org/apache/ignite/lang/IgniteExceptionMapperUtilTest.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-21 Thread via GitHub
ibessonov commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236708527 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMappersProvider.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236720397 ## modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/metric/SqlViewExporterSpiTest.java: ## @@ -309,6 +310,7 @@ public void testServices() {

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10788: IGNITE-19725 SQL Calclite: Implement local flag support

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10788: URL: https://github.com/apache/ignite/pull/10788#issuecomment-1600537124 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10783: URL: https://github.com/apache/ignite/pull/10783#issuecomment-1600567012 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236757037 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorage.java: ## @@ -70,6 +70,16 @@ public interface KeyValueStorage ex

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236757755 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/BasicOperationsKeyValueStorageTest.java: ## @@ -190,6 +192,67 @@ void getWithRe

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236758044 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/BasicOperationsKeyValueStorageTest.java: ## @@ -190,6 +192,67 @@ void getWithRe

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236759236 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java: ## @@ -63,6 +72,113 @@ public Publisher scan(ExecutionContext c

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236760687 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java: ## @@ -63,6 +72,113 @@ public Publisher scan(ExecutionContext c

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236762824 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java: ## @@ -63,6 +72,113 @@ public Publisher scan(ExecutionContext c

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236763358 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TransformingPublisher.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [ignite] nizhikov opened a new pull request, #10797: IGNITE-19753 Move task classes to commands

2023-06-21 Thread via GitHub
nizhikov opened a new pull request, #10797: URL: https://github.com/apache/ignite/pull/10797 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

<    1   2   3   4   5   6   7   8   9   10   >