Re: [PR] IGNITE-24985 Add a test where a node joins to the cluster of two [ignite-3]

2025-04-03 Thread via GitHub
ibessonov merged PR #5542: URL: https://github.com/apache/ignite-3/pull/5542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24837 C++: Fix error codes [ignite-3]

2025-04-03 Thread via GitHub
isapego merged PR #5557: URL: https://github.com/apache/ignite-3/pull/5557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ign

Re: [PR] IGNITE-24227 Sql. Improve type checking in LIMIT / OFFSET clauses [ignite-3]

2025-04-03 Thread via GitHub
AMashenkov commented on code in PR #5479: URL: https://github.com/apache/ignite-3/pull/5479#discussion_r2026552303 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/LimitNode.java: ## @@ -89,19 +93,30 @@ public void push(RowT row) throws Exceptio

Re: [PR] IGNITE-22857 C++ Remove NUMBER and BITMASK types [ignite-3]

2025-04-03 Thread via GitHub
isapego merged PR #5558: URL: https://github.com/apache/ignite-3/pull/5558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ign

Re: [PR] IGNITE-25004 Notify failure handler in CatalogManagerImpl [ignite-3]

2025-04-03 Thread via GitHub
rpuch merged PR #5554: URL: https://github.com/apache/ignite-3/pull/5554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-24974 Pool starvation when stopping zone in colocation mode [ignite-3]

2025-04-03 Thread via GitHub
sashapolo commented on code in PR #5547: URL: https://github.com/apache/ignite-3/pull/5547#discussion_r2026470233 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/NaiveAsyncReadWriteLock.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to

Re: [PR] IGNITE-24227 Sql. Improve type checking in LIMIT / OFFSET clauses [ignite-3]

2025-04-03 Thread via GitHub
AMashenkov commented on code in PR #5479: URL: https://github.com/apache/ignite-3/pull/5479#discussion_r2026549199 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/LimitNode.java: ## @@ -136,6 +153,6 @@ protected Downstream requestDownstream(int

Re: [PR] IGNITE-24966 Sql. Improve OrderedMergePublisher performance [ignite-3]

2025-04-03 Thread via GitHub
AMashenkov merged PR #5525: URL: https://github.com/apache/ignite-3/pull/5525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] IGNITE-25015 Fix ItAbstractDataStreamerTest test when the colocation feature is enabled [ignite-3]

2025-04-03 Thread via GitHub
sk0x50 opened a new pull request, #5563: URL: https://github.com/apache/ignite-3/pull/5563 https://issues.apache.org/jira/browse/IGNITE-25015 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an

Re: [PR] IGNITE-24825 Add bounds check for temporal types [ignite-3]

2025-04-03 Thread via GitHub
xtern commented on code in PR #5515: URL: https://github.com/apache/ignite-3/pull/5515#discussion_r2026741608 ## modules/platforms/dotnet/Apache.Ignite.Tests/Proto/ColocationHashTests.cs: ## @@ -96,10 +96,11 @@ public class ColocationHashTests : IgniteTestsBase LocalTim

Re: [PR] IGNITE-25020 Fix NPE in TableManagerTest when colocation is enabled [ignite-3]

2025-04-03 Thread via GitHub
sk0x50 merged PR #5570: URL: https://github.com/apache/ignite-3/pull/5570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

Re: [PR] IGNITE-24258 .NET: Add QualifiedName API [ignite-3]

2025-04-03 Thread via GitHub
Copilot commented on code in PR #5565: URL: https://github.com/apache/ignite-3/pull/5565#discussion_r2026931669 ## modules/platforms/dotnet/Apache.Ignite.Tests/Table/KeyColumnOrderTests.cs: ## @@ -26,8 +26,7 @@ namespace Apache.Ignite.Tests.Table; /// public class KeyColumnOr

Re: [PR] IGNITE-24624 : Calcite. Heuristics of join order. [ignite]

2025-04-03 Thread via GitHub
alex-plekhanov commented on code in PR #11935: URL: https://github.com/apache/ignite/pull/11935#discussion_r2027733356 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/hints/JoinTypeHintPlannerTest.java: ## @@ -468,6 +537,95 @@ public

[PR] IGNITE-24847 Move some U methods, IgniteException, IgniteCheckedException to ignite-commons [ignite]

2025-04-03 Thread via GitHub
shishkovilja opened a new pull request, #11981: URL: https://github.com/apache/ignite/pull/11981 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ##

[PR] IGNITE-24997 Adopt runner test to colocation track [ignite-3]

2025-04-03 Thread via GitHub
sk0x50 opened a new pull request, #5551: URL: https://github.com/apache/ignite-3/pull/5551 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ###

Re: [PR] IGNITE-24624 : Calcite. Heuristics of join order. [ignite]

2025-04-03 Thread via GitHub
sonarqubecloud[bot] commented on PR #11935: URL: https://github.com/apache/ignite/pull/11935#issuecomment-2776919509 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

[PR] IGNITE-24968 Fixed race when registering query cancellation from thin client. [ignite-3]

2025-04-03 Thread via GitHub
xtern opened a new pull request, #5569: URL: https://github.com/apache/ignite-3/pull/5569 https://issues.apache.org/jira/browse/IGNITE-24968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-25018 Fix flaky ItLearnersTest [ignite-3]

2025-04-03 Thread via GitHub
sashapolo merged PR #5566: URL: https://github.com/apache/ignite-3/pull/5566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24974 Pool starvation when stopping zone in colocation mode [ignite-3]

2025-04-03 Thread via GitHub
rpuch commented on code in PR #5547: URL: https://github.com/apache/ignite-3/pull/5547#discussion_r2026641212 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/NaiveAsyncReadWriteLock.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the

Re: [PR] IGNITE-24974 Pool starvation when stopping zone in colocation mode [ignite-3]

2025-04-03 Thread via GitHub
rpuch commented on code in PR #5547: URL: https://github.com/apache/ignite-3/pull/5547#discussion_r2026646563 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/NaiveAsyncReadWriteLock.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the

Re: [PR] IGNITE-25004 Notify failure handler in CatalogManagerImpl [ignite-3]

2025-04-03 Thread via GitHub
ivanzlenko commented on PR #5554: URL: https://github.com/apache/ignite-3/pull/5554#issuecomment-2774808455 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] IGNITE-24974 Pool starvation when stopping zone in colocation mode [ignite-3]

2025-04-03 Thread via GitHub
rpuch merged PR #5547: URL: https://github.com/apache/ignite-3/pull/5547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[PR] IGNITE-25016 Relax Mapper requirements and allow unmapped columns. [ignite-3]

2025-04-03 Thread via GitHub
AMashenkov opened a new pull request, #5564: URL: https://github.com/apache/ignite-3/pull/5564 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-24825 Add bounds check for temporal types [ignite-3]

2025-04-03 Thread via GitHub
xtern commented on code in PR #5515: URL: https://github.com/apache/ignite-3/pull/5515#discussion_r2026741608 ## modules/platforms/dotnet/Apache.Ignite.Tests/Proto/ColocationHashTests.cs: ## @@ -96,10 +96,11 @@ public class ColocationHashTests : IgniteTestsBase LocalTim

[PR] IGNITE-25007 Create JMH benchmark to test secondary indexes [ignite-3]

2025-04-03 Thread via GitHub
vldpyatkov opened a new pull request, #5561: URL: https://github.com/apache/ignite-3/pull/5561 https://issues.apache.org/jira/browse/IGNITE-25007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] IGNITE-24825 Add bounds check for temporal types [ignite-3]

2025-04-03 Thread via GitHub
xtern commented on code in PR #5515: URL: https://github.com/apache/ignite-3/pull/5515#discussion_r2026741608 ## modules/platforms/dotnet/Apache.Ignite.Tests/Proto/ColocationHashTests.cs: ## @@ -96,10 +96,11 @@ public class ColocationHashTests : IgniteTestsBase LocalTim

Re: [PR] IGNITE-24825 Add bounds check for temporal types [ignite-3]

2025-04-03 Thread via GitHub
xtern commented on code in PR #5515: URL: https://github.com/apache/ignite-3/pull/5515#discussion_r2026741608 ## modules/platforms/dotnet/Apache.Ignite.Tests/Proto/ColocationHashTests.cs: ## @@ -96,10 +96,11 @@ public class ColocationHashTests : IgniteTestsBase LocalTim

[PR] IGNITE-24794 Sql. FORCE_INDEX hint must have a strict meaning [ignite-3]

2025-04-03 Thread via GitHub
zstan opened a new pull request, #5562: URL: https://github.com/apache/ignite-3/pull/5562 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ###

Re: [PR] IGNITE-24974 Pool starvation when stopping zone in colocation mode [ignite-3]

2025-04-03 Thread via GitHub
rpuch commented on code in PR #5547: URL: https://github.com/apache/ignite-3/pull/5547#discussion_r2026764281 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/NaiveAsyncReadWriteLock.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the

[PR] IGNITE-25019 Remove unneeded future from ClusterManagementGroupManager [ignite-3]

2025-04-03 Thread via GitHub
sashapolo opened a new pull request, #5567: URL: https://github.com/apache/ignite-3/pull/5567 https://issues.apache.org/jira/browse/IGNITE-25019 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-25015 Fix ItAbstractDataStreamerTest test when the colocation feature is enabled [ignite-3]

2025-04-03 Thread via GitHub
sanpwc commented on code in PR #5563: URL: https://github.com/apache/ignite-3/pull/5563#discussion_r2026930590 ## modules/table/src/main/java/org/apache/ignite/internal/table/InternalTable.java: ## @@ -524,10 +524,10 @@ Publisher lookup( /** * Returns {@link ClusterNo

Re: [PR] IGNITE-25015 Fix ItAbstractDataStreamerTest test when the colocation feature is enabled [ignite-3]

2025-04-03 Thread via GitHub
sk0x50 commented on code in PR #5563: URL: https://github.com/apache/ignite-3/pull/5563#discussion_r2026933109 ## modules/client/src/test/java/org/apache/ignite/client/fakes/FakeInternalTable.java: ## @@ -524,9 +521,9 @@ public ScheduledExecutorService streamerFlushExecutor() {

Re: [PR] IGNITE-25015 Fix ItAbstractDataStreamerTest test when the colocation feature is enabled [ignite-3]

2025-04-03 Thread via GitHub
sk0x50 commented on code in PR #5563: URL: https://github.com/apache/ignite-3/pull/5563#discussion_r2026933109 ## modules/client/src/test/java/org/apache/ignite/client/fakes/FakeInternalTable.java: ## @@ -524,9 +521,9 @@ public ScheduledExecutorService streamerFlushExecutor() {

Re: [PR] IGNITE-25019 Remove unneeded future from ClusterManagementGroupManager [ignite-3]

2025-04-03 Thread via GitHub
sashapolo merged PR #5567: URL: https://github.com/apache/ignite-3/pull/5567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24751 SQL Calcite: Add thread pool starvation warning [ignite]

2025-04-03 Thread via GitHub
sonarqubecloud[bot] commented on PR #11980: URL: https://github.com/apache/ignite/pull/11980#issuecomment-2775805269 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-24997 Adapt runner test for the colocation track [ignite-3]

2025-04-03 Thread via GitHub
sashapolo commented on code in PR #5551: URL: https://github.com/apache/ignite-3/pull/5551#discussion_r2026617075 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteInMemoryNodeRestartTest.java: ## @@ -249,8 +259,13 @@ private static boolean

Re: [PR] IGNITE-24997 Adapt runner test for the colocation track [ignite-3]

2025-04-03 Thread via GitHub
sk0x50 commented on code in PR #5551: URL: https://github.com/apache/ignite-3/pull/5551#discussion_r2026839210 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteInMemoryNodeRestartTest.java: ## @@ -249,8 +259,13 @@ private static boolean s

Re: [PR] IGNITE-25015 Fix ItAbstractDataStreamerTest test when the colocation feature is enabled [ignite-3]

2025-04-03 Thread via GitHub
sk0x50 commented on code in PR #5563: URL: https://github.com/apache/ignite-3/pull/5563#discussion_r2026940063 ## modules/table/src/main/java/org/apache/ignite/internal/table/InternalTable.java: ## @@ -524,10 +524,10 @@ Publisher lookup( /** * Returns {@link ClusterNo

Re: [PR] IGNITE-25015 Fix ItAbstractDataStreamerTest test when the colocation feature is enabled [ignite-3]

2025-04-03 Thread via GitHub
sanpwc commented on code in PR #5563: URL: https://github.com/apache/ignite-3/pull/5563#discussion_r2026928964 ## modules/client/src/test/java/org/apache/ignite/client/fakes/FakeInternalTable.java: ## @@ -524,9 +521,9 @@ public ScheduledExecutorService streamerFlushExecutor() {

Re: [PR] IGNITE-24624 : Calcite. Heuristics of join order. [ignite]

2025-04-03 Thread via GitHub
alex-plekhanov commented on code in PR #11935: URL: https://github.com/apache/ignite/pull/11935#discussion_r2027131412 ## modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java: ## @@ -467,17 +466,26 @@ protected IgniteLogger log() { }

[PR] IGNITE-25011 Make IgniteNameUtils.quoteIfNeeded consistent with parse methods. [ignite-3]

2025-04-03 Thread via GitHub
AMashenkov opened a new pull request, #5559: URL: https://github.com/apache/ignite-3/pull/5559 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-24974 Pool starvation when stopping zone in colocation mode [ignite-3]

2025-04-03 Thread via GitHub
rpuch commented on code in PR #5547: URL: https://github.com/apache/ignite-3/pull/5547#discussion_r2026786192 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/NaiveAsyncReadWriteLock.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the

Re: [PR] IGNITE-25015 Fix ItAbstractDataStreamerTest test when the colocation feature is enabled [ignite-3]

2025-04-03 Thread via GitHub
sk0x50 merged PR #5563: URL: https://github.com/apache/ignite-3/pull/5563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

Re: [PR] IGNITE-24751 SQL Calcite: Add thread pool starvation warning [ignite]

2025-04-03 Thread via GitHub
sonarqubecloud[bot] commented on PR #11980: URL: https://github.com/apache/ignite/pull/11980#issuecomment-2775993111 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-24227 Sql. Improve type checking in LIMIT / OFFSET clauses [ignite-3]

2025-04-03 Thread via GitHub
AMashenkov commented on code in PR #5479: URL: https://github.com/apache/ignite-3/pull/5479#discussion_r2026563030 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/SortNode.java: ## @@ -59,18 +58,19 @@ public class SortNode extends AbstractNode

[PR] IGNITE-24258 .NET: Add QualifiedName API [ignite-3]

2025-04-03 Thread via GitHub
ptupitsyn opened a new pull request, #5565: URL: https://github.com/apache/ignite-3/pull/5565 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e