Re: [PR] IGNITE-24247 Indexes created with table must be created in AVAILABLE state [ignite-3]

2025-01-27 Thread via GitHub
korlov42 commented on code in PR #5113: URL: https://github.com/apache/ignite-3/pull/5113#discussion_r1930642025 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageHashIndexDescriptor.java: ## @@ -93,7 +94,7 @@ public String toString() { *

Re: [PR] IGNITE-24313 Improve invocation timeout exception message [ignite-3]

2025-01-27 Thread via GitHub
rpuch commented on code in PR #5122: URL: https://github.com/apache/ignite-3/pull/5122#discussion_r1930361876 ## modules/network/src/test/java/org/apache/ignite/internal/network/DefaultMessagingServiceTest.java: ## @@ -525,6 +539,8 @@ private Services createMessagingService(

Re: [PR] IGNITE-24242 Add RO/RW Transaction Timeout configuration schema [ignite-3]

2025-01-27 Thread via GitHub
sanpwc commented on code in PR #5093: URL: https://github.com/apache/ignite-3/pull/5093#discussion_r1930346109 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -418,7 +418,9 @@ public class TableManager implements IgniteTablesI

Re: [PR] IGNITE-24313 Improve invocation timeout exception message [ignite-3]

2025-01-27 Thread via GitHub
rpuch commented on code in PR #5122: URL: https://github.com/apache/ignite-3/pull/5122#discussion_r1930536320 ## modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/asserts/CompletableFutureAssert.java: ## @@ -92,12 +92,18 @@ public static X assertWillTh

Re: [PR] IGNITE-24033 Sql schema. Extend Compute API with supporting qualified names [ignite-3]

2025-01-27 Thread via GitHub
zstan commented on code in PR #5102: URL: https://github.com/apache/ignite-3/pull/5102#discussion_r1930536953 ## modules/client/src/test/java/org/apache/ignite/client/ClientComputeTest.java: ## @@ -197,10 +197,10 @@ public void testExecuteColocatedThrowsTableNotFoundExceptionWh

Re: [PR] IGNITE-24313 Improve invocation timeout exception message [ignite-3]

2025-01-27 Thread via GitHub
rpuch commented on code in PR #5122: URL: https://github.com/apache/ignite-3/pull/5122#discussion_r1930543291 ## modules/core/src/main/java/org/apache/ignite/internal/future/timeout/TimeoutObject.java: ## @@ -37,4 +38,11 @@ public interface TimeoutObject> { * @return A fut

Re: [PR] IGNITE-24242 Add RO/RW Transaction Timeout configuration schema [ignite-3]

2025-01-27 Thread via GitHub
rpuch commented on code in PR #5093: URL: https://github.com/apache/ignite-3/pull/5093#discussion_r1930550613 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/configuration/TransactionConfigurationSchema.java: ## @@ -36,15 +36,15 @@ public class TransactionCon

Re: [PR] IGNITE-24033 Sql schema. Extend Compute API with supporting qualified names [ignite-3]

2025-01-27 Thread via GitHub
zstan merged PR #5102: URL: https://github.com/apache/ignite-3/pull/5102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-15126 Fixes cluster hanging if exception occurred during activation. [ignite]

2025-01-27 Thread via GitHub
sonarqubecloud[bot] commented on PR #11694: URL: https://github.com/apache/ignite/pull/11694#issuecomment-2615464388 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-24247 Indexes created with table must be created in AVAILABLE state [ignite-3]

2025-01-27 Thread via GitHub
korlov42 commented on code in PR #5113: URL: https://github.com/apache/ignite-3/pull/5113#discussion_r1930429861 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/UpdateContext.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] IGNITE-24215 Improve internal Catalog API [ignite-3]

2025-01-27 Thread via GitHub
AMashenkov commented on code in PR #5112: URL: https://github.com/apache/ignite-3/pull/5112#discussion_r1930440624 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogService.java: ## @@ -42,7 +34,8 @@ * Events are fired in the metastore thread. *

[PR] IGNITE-24283 Remove shared command from replication pipeline. [ignite-3]

2025-01-27 Thread via GitHub
ascherbakoff opened a new pull request, #5124: URL: https://github.com/apache/ignite-3/pull/5124 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-24247 Indexes created with table must be created in AVAILABLE state [ignite-3]

2025-01-27 Thread via GitHub
ibessonov commented on code in PR #5113: URL: https://github.com/apache/ignite-3/pull/5113#discussion_r1930578318 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageHashIndexDescriptor.java: ## @@ -93,7 +94,7 @@ public String toString() {

Re: [PR] IGNITE-24247 Indexes created with table must be created in AVAILABLE state [ignite-3]

2025-01-27 Thread via GitHub
ibessonov commented on code in PR #5113: URL: https://github.com/apache/ignite-3/pull/5113#discussion_r1930578318 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageHashIndexDescriptor.java: ## @@ -93,7 +94,7 @@ public String toString() {

Re: [PR] IGNITE-24313 Improve invocation timeout exception message [ignite-3]

2025-01-27 Thread via GitHub
sashapolo commented on code in PR #5122: URL: https://github.com/apache/ignite-3/pull/5122#discussion_r1930335629 ## modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/asserts/CompletableFutureAssert.java: ## @@ -92,12 +92,18 @@ public static X assertWi

Re: [PR] IGNITE-24215 Improve internal Catalog API [ignite-3]

2025-01-27 Thread via GitHub
korlov42 commented on code in PR #5112: URL: https://github.com/apache/ignite-3/pull/5112#discussion_r1930448627 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogService.java: ## @@ -42,7 +34,8 @@ * Events are fired in the metastore thread. *

Re: [PR] IGNITE-24313 Improve invocation timeout exception message [ignite-3]

2025-01-27 Thread via GitHub
rpuch merged PR #5122: URL: https://github.com/apache/ignite-3/pull/5122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-24247 Indexes created with table must be created in AVAILABLE state [ignite-3]

2025-01-27 Thread via GitHub
sashapolo commented on code in PR #5113: URL: https://github.com/apache/ignite-3/pull/5113#discussion_r1930563074 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageHashIndexDescriptor.java: ## @@ -93,7 +94,7 @@ public String toString() {

[PR] IGNITE-24319 Initial take on RNs [ignite-3]

2025-01-27 Thread via GitHub
IgGusev opened a new pull request, #5125: URL: https://github.com/apache/ignite-3/pull/5125 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ##

Re: [PR] ignite-22197 Move ifExists flag handling inside a Catalog [ignite-3]

2025-01-27 Thread via GitHub
ygerzhedovich commented on code in PR #5121: URL: https://github.com/apache/ignite-3/pull/5121#discussion_r1930567998 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandlerExceptionHandlingTest.java: ## @@ -67,6 +71,7 @@ void before(

Re: [PR] ignite-22197 Move ifExists flag handling inside a Catalog [ignite-3]

2025-01-27 Thread via GitHub
ygerzhedovich commented on code in PR #5121: URL: https://github.com/apache/ignite-3/pull/5121#discussion_r1930567998 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandlerExceptionHandlingTest.java: ## @@ -67,6 +71,7 @@ void before(

Re: [PR] IGNITE-24247 Indexes created with table must be created in AVAILABLE state [ignite-3]

2025-01-27 Thread via GitHub
sashapolo commented on code in PR #5113: URL: https://github.com/apache/ignite-3/pull/5113#discussion_r1930671620 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageHashIndexDescriptor.java: ## @@ -93,7 +94,7 @@ public String toString() {

Re: [PR] IGNITE-24247 Indexes created with table must be created in AVAILABLE state [ignite-3]

2025-01-27 Thread via GitHub
korlov42 commented on code in PR #5113: URL: https://github.com/apache/ignite-3/pull/5113#discussion_r1930676462 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageHashIndexDescriptor.java: ## @@ -93,7 +94,7 @@ public String toString() { *

Re: [PR] IGNITE-24215 Improve internal Catalog API [ignite-3]

2025-01-27 Thread via GitHub
AMashenkov commented on code in PR #5112: URL: https://github.com/apache/ignite-3/pull/5112#discussion_r1930679967 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogService.java: ## @@ -42,7 +34,8 @@ * Events are fired in the metastore thread. *

Re: [PR] IGNITE-24247 Indexes created with table must be created in AVAILABLE state [ignite-3]

2025-01-27 Thread via GitHub
sashapolo commented on code in PR #5113: URL: https://github.com/apache/ignite-3/pull/5113#discussion_r1930683908 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageHashIndexDescriptor.java: ## @@ -93,7 +94,7 @@ public String toString() {

[PR] IGNITE-24316 wait system view initialization in integration tests [ignite-3]

2025-01-27 Thread via GitHub
nevdmitry opened a new pull request, #5123: URL: https://github.com/apache/ignite-3/pull/5123 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-24242 Add RO/RW Transaction Timeout configuration schema [ignite-3]

2025-01-27 Thread via GitHub
rpuch commented on code in PR #5093: URL: https://github.com/apache/ignite-3/pull/5093#discussion_r1930295418 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -418,7 +418,9 @@ public class TableManager implements IgniteTablesIn

Re: [PR] IGNITE-24317 Move binaryMetadata, marshaller directories logic to IgniteDirectories class [ignite]

2025-01-27 Thread via GitHub
sonarqubecloud[bot] commented on PR #11831: URL: https://github.com/apache/ignite/pull/11831#issuecomment-2615322044 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-24101 Remove SEPARATE_CACHE_PER_NON_COLLOCATED_SET_SINCE [ignite]

2025-01-27 Thread via GitHub
sonarqubecloud[bot] commented on PR #11810: URL: https://github.com/apache/ignite/pull/11810#issuecomment-2615329695 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-24267 Heap lock manager behave incorrectly in case of overflow [ignite-3]

2025-01-27 Thread via GitHub
vldpyatkov merged PR #5096: URL: https://github.com/apache/ignite-3/pull/5096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-24130 Move binaryMetadata, marshaller directories logic to IgniteDirectories class [ignite]

2025-01-27 Thread via GitHub
sonarqubecloud[bot] commented on PR #11829: URL: https://github.com/apache/ignite/pull/11829#issuecomment-2615287919 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-24130 Move binaryMetadata, marshaller directories logic to IgniteDirectories class [ignite]

2025-01-27 Thread via GitHub
nizhikov closed pull request #11829: IGNITE-24130 Move binaryMetadata, marshaller directories logic to IgniteDirectories class URL: https://github.com/apache/ignite/pull/11829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[PR] IGNITE-24317 Move binaryMetadata, marshaller directories logic to IgniteDirectories class [ignite]

2025-01-27 Thread via GitHub
nizhikov opened a new pull request, #11831: URL: https://github.com/apache/ignite/pull/11831 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] IGNITE-24130 Move binaryMetadata, marshaller directories logic to IgniteDirectories class [ignite]

2025-01-27 Thread via GitHub
sonarqubecloud[bot] commented on PR #11829: URL: https://github.com/apache/ignite/pull/11829#issuecomment-2615304302 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-24033 Sql schema. Extend Compute API with supporting qualified names [ignite-3]

2025-01-27 Thread via GitHub
AMashenkov commented on code in PR #5102: URL: https://github.com/apache/ignite-3/pull/5102#discussion_r1930181599 ## modules/client/src/test/java/org/apache/ignite/client/ClientComputeTest.java: ## @@ -197,10 +197,10 @@ public void testExecuteColocatedThrowsTableNotFoundExcept

Re: [PR] IGNITE-24316 wait system view initialization in integration tests [ignite-3]

2025-01-27 Thread via GitHub
Pochatkin merged PR #5123: URL: https://github.com/apache/ignite-3/pull/5123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24215 Improve internal Catalog API [ignite-3]

2025-01-27 Thread via GitHub
AMashenkov merged PR #5112: URL: https://github.com/apache/ignite-3/pull/5112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] IGNITE-24323 SQL Calcite: Add query blocking tasks executor (allows t… [ignite]

2025-01-27 Thread via GitHub
alex-plekhanov opened a new pull request, #11833: URL: https://github.com/apache/ignite/pull/11833 …o execute SQL inside UDF) Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the follow

Re: [PR] IGNITE-24323 SQL Calcite: Add query blocking tasks executor (allows t… [ignite]

2025-01-27 Thread via GitHub
sonarqubecloud[bot] commented on PR #11833: URL: https://github.com/apache/ignite/pull/11833#issuecomment-2616842549 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-24323 SQL Calcite: Add query blocking tasks executor (allows t… [ignite]

2025-01-27 Thread via GitHub
sonarqubecloud[bot] commented on PR #11833: URL: https://github.com/apache/ignite/pull/11833#issuecomment-2616885857 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

[PR] Calcite table functions [ignite]

2025-01-27 Thread via GitHub
Vladsz83 opened a new pull request, #11832: URL: https://github.com/apache/ignite/pull/11832 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] [IGNITE-24262] AssertionError in ClusterTimeImpl.startSafeTimeScheduler [ignite-3]

2025-01-27 Thread via GitHub
ivanzlenko commented on code in PR #5101: URL: https://github.com/apache/ignite-3/pull/5101#discussion_r1931492005 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/time/ClusterTimeImpl.java: ## @@ -91,13 +100,17 @@ public ClusterTimeImpl(String

[PR] IGNITE-24324 DB API: Re-name package to pyignite-dbapi [ignite-3]

2025-01-27 Thread via GitHub
isapego opened a new pull request, #5127: URL: https://github.com/apache/ignite-3/pull/5127 https://issues.apache.org/jira/browse/IGNITE-24324 Re-name package to `pyignite-dbapi`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] IGNITE-24309 Decrease number of slots in HeapLockManager in tests [ignite-3]

2025-01-27 Thread via GitHub
ivanzlenko commented on code in PR #5118: URL: https://github.com/apache/ignite-3/pull/5118#discussion_r1931539765 ## modules/runner/src/testFixtures/java/org/apache/ignite/internal/testframework/TestIgnitionManager.java: ## @@ -112,11 +114,35 @@ public class TestIgnitionManager

[PR] IGNITE-24298 DB API: Fix invalid freeing of an object [ignite-3]

2025-01-27 Thread via GitHub
isapego opened a new pull request, #5126: URL: https://github.com/apache/ignite-3/pull/5126 https://issues.apache.org/jira/browse/IGNITE-24298 - Added a test with 1 rows; - Fixed multiple freeing of the object that should not have been freed in the first place. -- This is an

Re: [PR] IGNITE-24324 DB API: Re-name package to pyignite-dbapi [ignite-3]

2025-01-27 Thread via GitHub
ptupitsyn commented on code in PR #5127: URL: https://github.com/apache/ignite-3/pull/5127#discussion_r1931633742 ## modules/platforms/python/CMakeLists.txt: ## @@ -16,7 +16,7 @@ # cmake_minimum_required(VERSION 3.18) -project(pyignite3 VERSION ${IGNITE_VERSION} LANGUAGES CX