ivanzlenko commented on code in PR #5118:
URL: https://github.com/apache/ignite-3/pull/5118#discussion_r1931539765
##########
modules/runner/src/testFixtures/java/org/apache/ignite/internal/testframework/TestIgnitionManager.java:
##########
@@ -112,11 +114,35 @@ public class TestIgnitionManager {
* @throws IgniteException If error occurs while reading node
configuration.
*/
public static IgniteServer start(String nodeName, @Nullable String
configStr, Path workDir) {
+ return doStart(nodeName, configStr, workDir, true);
+ }
+
+ /**
+ * Starts an Ignite node with an optional bootstrap configuration from an
input stream with HOCON configs.
+ *
+ * <p>When this method returns, the node is partially started and ready to
accept the init command (that is, its
+ * REST endpoint is functional).
+ *
+ * @param nodeName Name of the node. Must not be {@code null}.
+ * @param configStr Optional node configuration.
+ * @return Completable future that resolves into an Ignite node after all
components are started and the cluster initialization is
Review Comment:
Missing param workDir here.
##########
modules/runner/src/testFixtures/java/org/apache/ignite/internal/testframework/TestIgnitionManager.java:
##########
@@ -206,4 +243,8 @@ private static ConfigDocument
applyTestDefault(ConfigDocument document, String p
return document.withValueText(path, value);
}
}
+
+ private static String toDoubleQuotedString(Object obj) {
Review Comment:
Let's add this to StringUtils, 'cause we have quite a lot of places where we
can have a use of this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
