[PR] IGNITE-24164 Remove catalog usage from debug logging [ignite-3]

2025-01-07 Thread via GitHub
sashapolo opened a new pull request, #5002: URL: https://github.com/apache/ignite-3/pull/5002 https://issues.apache.org/jira/browse/IGNITE-24164 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-23736 Sql. Provide ability to catch start/finish events for query [ignite-3]

2025-01-07 Thread via GitHub
xtern commented on code in PR #4977: URL: https://github.com/apache/ignite-3/pull/4977#discussion_r1905589092 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/Program.java: ## @@ -76,6 +76,8 @@ CompletableFuture run(Query query) {

[PR] Bump org.springframework.data:spring-data-jdbc from 3.4.0 to 3.4.1 [ignite-3]

2025-01-07 Thread via GitHub
dependabot[bot] opened a new pull request, #5003: URL: https://github.com/apache/ignite-3/pull/5003 Bumps org.springframework.data:spring-data-jdbc from 3.4.0 to 3.4.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency

Re: [PR] IGNITE-24036 Sql schema. Introduce QualifiedName class [ignite-3]

2025-01-07 Thread via GitHub
AMashenkov merged PR #4971: URL: https://github.com/apache/ignite-3/pull/4971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-24063 Add peers count as parameter into DistributionAlgorithm [ignite-3]

2025-01-07 Thread via GitHub
vldpyatkov commented on code in PR #4985: URL: https://github.com/apache/ignite-3/pull/4985#discussion_r1905354655 ## modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/RendezvousDistributionFunction.java: ## @@ -284,11 +288,12 @@ publi

Re: [PR] IGNITE-23968 Sql. Improve row count estimation for joins [ignite-3]

2025-01-07 Thread via GitHub
korlov42 commented on code in PR #4992: URL: https://github.com/apache/ignite-3/pull/4992#discussion_r1905363421 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/IgniteMdRowCount.java: ## @@ -100,68 +106,334 @@ public double getRowCount(IgniteLi

Re: [PR] IGNITE-23968 Sql. Improve row count estimation for joins [ignite-3]

2025-01-07 Thread via GitHub
korlov42 commented on code in PR #4992: URL: https://github.com/apache/ignite-3/pull/4992#discussion_r1905364002 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/IgniteMdRowCount.java: ## @@ -100,68 +106,334 @@ public double getRowCount(IgniteLi

Re: [PR] IGNITE-24063 Add peers count as parameter into DistributionAlgorithm [ignite-3]

2025-01-07 Thread via GitHub
vldpyatkov commented on code in PR #4985: URL: https://github.com/apache/ignite-3/pull/4985#discussion_r1905354655 ## modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/RendezvousDistributionFunction.java: ## @@ -284,11 +288,12 @@ publi

Re: [PR] IGNITE-24063 Add peers count as parameter into DistributionAlgorithm [ignite-3]

2025-01-07 Thread via GitHub
vldpyatkov commented on code in PR #4985: URL: https://github.com/apache/ignite-3/pull/4985#discussion_r1905354655 ## modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/RendezvousDistributionFunction.java: ## @@ -284,11 +288,12 @@ publi

Re: [PR] IGNITE-23968 Sql. Improve row count estimation for joins [ignite-3]

2025-01-07 Thread via GitHub
korlov42 commented on code in PR #4992: URL: https://github.com/apache/ignite-3/pull/4992#discussion_r1905362633 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/IgniteMdRowCount.java: ## @@ -100,68 +106,334 @@ public double getRowCount(IgniteLi

Re: [PR] IGNITE-23968 Sql. Improve row count estimation for joins [ignite-3]

2025-01-07 Thread via GitHub
korlov42 commented on code in PR #4992: URL: https://github.com/apache/ignite-3/pull/4992#discussion_r1905363421 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/IgniteMdRowCount.java: ## @@ -100,68 +106,334 @@ public double getRowCount(IgniteLi

Re: [PR] IGNITE-24063 Add peers count as parameter into DistributionAlgorithm [ignite-3]

2025-01-07 Thread via GitHub
denis-chudov commented on code in PR #4985: URL: https://github.com/apache/ignite-3/pull/4985#discussion_r1905370463 ## modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/RendezvousDistributionFunction.java: ## @@ -284,11 +288,12 @@ pub

Re: [PR] IGNITE-24063 Add peers count as parameter into DistributionAlgorithm [ignite-3]

2025-01-07 Thread via GitHub
vldpyatkov merged PR #4985: URL: https://github.com/apache/ignite-3/pull/4985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-24161 Mute flaky testAssignmentsChainUpdatedOnAutomaticReset [ignite-3]

2025-01-07 Thread via GitHub
vldpyatkov merged PR #4999: URL: https://github.com/apache/ignite-3/pull/4999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-24163 Optimize EventLog [ignite-3]

2025-01-07 Thread via GitHub
AMashenkov commented on code in PR #5004: URL: https://github.com/apache/ignite-3/pull/5004#discussion_r1905726441 ## modules/eventlog/src/main/java/org/apache/ignite/internal/eventlog/impl/ConfigurationBasedChannelRegistry.java: ## @@ -35,73 +34,57 @@ import org.apache.ignite.

Re: [PR] IGNITE-24163 Optimize EventLog [ignite-3]

2025-01-07 Thread via GitHub
AMashenkov commented on code in PR #5004: URL: https://github.com/apache/ignite-3/pull/5004#discussion_r1905736856 ## modules/eventlog/src/main/java/org/apache/ignite/internal/eventlog/impl/ConfigurationBasedChannelRegistry.java: ## @@ -35,73 +34,57 @@ import org.apache.ignite.

Re: [PR] IGNITE-24150 Ability to have different prefixes for exceptions [ignite-3]

2025-01-07 Thread via GitHub
ygerzhedovich commented on code in PR #4991: URL: https://github.com/apache/ignite-3/pull/4991#discussion_r1905746083 ## modules/api/src/main/java/org/apache/ignite/lang/ErrorGroup.java: ## @@ -125,62 +129,14 @@ public static String errorMessage(UUID traceId, int code, String m

Re: [PR] IGNITE-24150 Ability to have different prefixes for exceptions [ignite-3]

2025-01-07 Thread via GitHub
ygerzhedovich commented on code in PR #4991: URL: https://github.com/apache/ignite-3/pull/4991#discussion_r1905749162 ## modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java: ## @@ -73,13 +104,36 @@ public static synchronized ErrorGroup registerGroup(String groupNa

[PR] IGNITE-24163 Optimize EventLog [ignite-3]

2025-01-07 Thread via GitHub
PakhomovAlexander opened a new pull request, #5004: URL: https://github.com/apache/ignite-3/pull/5004 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

[PR] IGNITE-24080 Fix config path reading in CLI init command [ignite-3]

2025-01-07 Thread via GitHub
Pochatkin opened a new pull request, #5001: URL: https://github.com/apache/ignite-3/pull/5001 https://issues.apache.org/jira/browse/IGNITE-24080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] IGNITE-24149 .NET: Fix SqlStatement.TimeZoneId [ignite-3]

2025-01-07 Thread via GitHub
ptupitsyn merged PR #5000: URL: https://github.com/apache/ignite-3/pull/5000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-23736 Sql. Provide ability to catch start/finish events for query [ignite-3]

2025-01-07 Thread via GitHub
xtern commented on code in PR #4977: URL: https://github.com/apache/ignite-3/pull/4977#discussion_r1905593510 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -445,6 +446,7 @@ private AsyncDataCursor executeExecutab

Re: [PR] IGNITE-23736 Sql. Provide ability to catch start/finish events for query [ignite-3]

2025-01-07 Thread via GitHub
xtern commented on code in PR #4977: URL: https://github.com/apache/ignite-3/pull/4977#discussion_r1905593510 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -445,6 +446,7 @@ private AsyncDataCursor executeExecutab

Re: [PR] IGNITE-24163 Optimize EventLog [ignite-3]

2025-01-07 Thread via GitHub
ygerzhedovich commented on code in PR #5004: URL: https://github.com/apache/ignite-3/pull/5004#discussion_r1905674295 ## modules/eventlog/src/main/java/org/apache/ignite/internal/eventlog/api/EventLog.java: ## @@ -44,7 +44,16 @@ public interface EventLog { /** * Write

Re: [PR] IGNITE-24064 Rendezvous function is now able to calculate learners' assignments [ignite-3]

2025-01-07 Thread via GitHub
vldpyatkov merged PR #4993: URL: https://github.com/apache/ignite-3/pull/4993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] IGNITE-24161 Mute flaky testAssignmentsChainUpdatedOnAutomaticReset [ignite-3]

2025-01-07 Thread via GitHub
kgusakov opened a new pull request, #4999: URL: https://github.com/apache/ignite-3/pull/4999 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: #

Re: [PR] IGNITE-21665 Implement Event log [ignite-3]

2025-01-07 Thread via GitHub
AMashenkov commented on code in PR #3522: URL: https://github.com/apache/ignite-3/pull/3522#discussion_r1905264147 ## modules/eventlog/src/main/java/org/apache/ignite/internal/eventlog/api/EventLog.java: ## @@ -20,9 +20,31 @@ import java.util.function.Supplier; /** - * Logs

Re: [PR] IGNITE-21665 Implement Event log [ignite-3]

2025-01-07 Thread via GitHub
AMashenkov commented on code in PR #3522: URL: https://github.com/apache/ignite-3/pull/3522#discussion_r1905265778 ## modules/eventlog/src/main/java/org/apache/ignite/internal/eventlog/impl/ConfigurationBasedChannelRegistry.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apac

Re: [PR] IGNITE-23968 Sql. Improve row count estimation for joins [ignite-3]

2025-01-07 Thread via GitHub
ygerzhedovich commented on code in PR #4992: URL: https://github.com/apache/ignite-3/pull/4992#discussion_r1901668559 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/IgniteMdRowCount.java: ## @@ -100,68 +106,334 @@ public double getRowCount(Ign

Re: [PR] IGNITE-21665 Implement Event log [ignite-3]

2025-01-07 Thread via GitHub
AMashenkov commented on code in PR #3522: URL: https://github.com/apache/ignite-3/pull/3522#discussion_r1905270052 ## modules/eventlog/src/main/java/org/apache/ignite/internal/eventlog/impl/ConfigurationBasedChannelRegistry.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apac

Re: [PR] IGNITE-24150 Ability to have different prefixes for exceptions [ignite-3]

2025-01-07 Thread via GitHub
korlov42 commented on code in PR #4991: URL: https://github.com/apache/ignite-3/pull/4991#discussion_r1905325066 ## modules/api/src/main/java/org/apache/ignite/lang/ErrorGroup.java: ## @@ -125,62 +129,14 @@ public static String errorMessage(UUID traceId, int code, String messag

[PR] IGNITE-24149 .NET: Fix SqlStatement.TimeZoneId [ignite-3]

2025-01-07 Thread via GitHub
ptupitsyn opened a new pull request, #5000: URL: https://github.com/apache/ignite-3/pull/5000 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] IGNITE-21665 Implement Event log [ignite-3]

2025-01-07 Thread via GitHub
AMashenkov commented on code in PR #3522: URL: https://github.com/apache/ignite-3/pull/3522#discussion_r1905271456 ## modules/eventlog/src/main/java/org/apache/ignite/internal/eventlog/impl/ConfigurationBasedSinkRegistry.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache S

Re: [PR] IGNITE-21665 Implement Event log [ignite-3]

2025-01-07 Thread via GitHub
AMashenkov commented on code in PR #3522: URL: https://github.com/apache/ignite-3/pull/3522#discussion_r1905277496 ## modules/eventlog/src/main/java/org/apache/ignite/internal/eventlog/impl/EventLogImpl.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] IGNITE-21665 Implement Event log [ignite-3]

2025-01-07 Thread via GitHub
AMashenkov commented on code in PR #3522: URL: https://github.com/apache/ignite-3/pull/3522#discussion_r1905273635 ## modules/eventlog/src/main/java/org/apache/ignite/internal/eventlog/impl/ConfigurationBasedChannelRegistry.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apac

Re: [PR] IGNITE-23951 Spring Data JDBC support for Ignite [ignite-3]

2025-01-07 Thread via GitHub
Pochatkin merged PR #4968: URL: https://github.com/apache/ignite-3/pull/4968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24123 Add DistributionAlgorithm interface [ignite-3]

2025-01-07 Thread via GitHub
vldpyatkov merged PR #4984: URL: https://github.com/apache/ignite-3/pull/4984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [I] Question: Ignite Client Python Setup [ignite]

2025-01-07 Thread via GitHub
isapego commented on issue #11795: URL: https://github.com/apache/ignite/issues/11795#issuecomment-2574890439 Hello. You can use one client. There are async methods you can use to avoid blocking. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] IGNITE-24010 Table suite is long enough to divide it [ignite-3]

2025-01-07 Thread via GitHub
vldpyatkov merged PR #4980: URL: https://github.com/apache/ignite-3/pull/4980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-24123 Add DistributionAlgorithm interface [ignite-3]

2025-01-07 Thread via GitHub
vldpyatkov commented on code in PR #4984: URL: https://github.com/apache/ignite-3/pull/4984#discussion_r1905227125 ## modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/PartitionDistributionUtils.java: ## @@ -17,19 +17,21 @@ package

Re: [PR] IGNITE-23736 Sql. Provide ability to catch start/finish events for query [ignite-3]

2025-01-07 Thread via GitHub
korlov42 commented on code in PR #4977: URL: https://github.com/apache/ignite-3/pull/4977#discussion_r1905040519 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/Query.java: ## @@ -60,6 +60,7 @@ class Query { volatile @Nullable SqlOperation

Re: [PR] IGNITE-23867 Implement Webhook Sink for EventLog. [ignite-3]

2025-01-07 Thread via GitHub
nva merged PR #4955: URL: https://github.com/apache/ignite-3/pull/4955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.

Re: [PR] IGNITE-24164 Remove catalog usage from debug logging [ignite-3]

2025-01-07 Thread via GitHub
ivanzlenko commented on PR #5002: URL: https://github.com/apache/ignite-3/pull/5002#issuecomment-2576649921 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] IGNITE-23746: Sql. ItSetOpTest uses incorrect optimizer hints for tests with Intersect operation [ignite-3]

2025-01-07 Thread via GitHub
zstan merged PR #4775: URL: https://github.com/apache/ignite-3/pull/4775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[PR] IGNITE-23597 Cache latest term values in log manager [ignite-3]

2025-01-07 Thread via GitHub
ibessonov opened a new pull request, #5005: URL: https://github.com/apache/ignite-3/pull/5005 https://issues.apache.org/jira/browse/IGNITE-23597 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-23736 Sql. Provide ability to catch start/finish events for query [ignite-3]

2025-01-07 Thread via GitHub
korlov42 commented on code in PR #4977: URL: https://github.com/apache/ignite-3/pull/4977#discussion_r1906576432 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -445,6 +446,7 @@ private AsyncDataCursor executeExecu

Re: [PR] IGNITE-23968 Sql. Improve row count estimation for joins [ignite-3]

2025-01-07 Thread via GitHub
korlov42 merged PR #4992: URL: https://github.com/apache/ignite-3/pull/4992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig