vldpyatkov commented on code in PR #4985:
URL: https://github.com/apache/ignite-3/pull/4985#discussion_r1905354655


##########
modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/RendezvousDistributionFunction.java:
##########
@@ -284,11 +288,12 @@ public static <T extends Collection<String>> List<T> 
assignPartitions(
     }
 
     @Override
-    public List<List<String>> assignPartitions(
+    public List<Set<Assignment>> assignPartitions(
             Collection<String> nodes,
             List<List<String>> currentDistribution,
             int partitions,
-            int replicaFactor
+            int replicaFactor,
+            int consensusGroupSize
     ) {
         return assignPartitions(nodes, partitions, replicaFactor, false, null);

Review Comment:
   It seems only the first _consensusGroupSize_ assignments for each node have 
to be marked as a peer and the rest (_replicaFactor - consensusGroupSize_ ) as 
learners (isPeer=false).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to