Re: [PR] IGNITE-22036 Replace TableManager.changePeersOnRebalance by the broadcast ReplicaRequest [ignite-3]

sanpwc commented on code in PR #4446: URL: https://github.com/apache/ignite-3/pull/4446#discussion_r1867581652 ## modules/catalog-compaction/src/integrationTest/java/org/apache/ignite/internal/catalog/compaction/ItCatalogCompactionTest.java: ## @@ -51,14 +51,13 @@ import org.ap

Re: [PR] IGNITE-23440 Sql. Common internal API for canceling an operation of a certain type [ignite-3]

xtern commented on PR #4799: URL: https://github.com/apache/ignite-3/pull/4799#issuecomment-2514536933 > seems this patch lacks integration with execution service: KILL statement request must be propagated to cancellation handler Thanks, fixed. Added integration with SQL KILL statemen

Re: [PR] IGNITE-23440 Sql. Common internal API for canceling an operation of a certain type [ignite-3]

xtern commented on code in PR #4799: URL: https://github.com/apache/ignite-3/pull/4799#discussion_r1867711085 ## modules/sql-engine-api/src/main/java/org/apache/ignite/internal/sql/common/cancel/api/CancelHandlerRegistry.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache S

Re: [PR] IGNITE-23440 Sql. Common internal API for canceling an operation of a certain type [ignite-3]

xtern commented on code in PR #4799: URL: https://github.com/apache/ignite-3/pull/4799#discussion_r1867714567 ## modules/sql-engine-api/src/main/java/org/apache/ignite/internal/sql/common/cancel/api/CancelHandlerRegistry.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache S

Re: [PR] IGNITE-23440 Sql. Common internal API for canceling an operation of a certain type [ignite-3]

xtern commented on code in PR #4799: URL: https://github.com/apache/ignite-3/pull/4799#discussion_r1867714567 ## modules/sql-engine-api/src/main/java/org/apache/ignite/internal/sql/common/cancel/api/CancelHandlerRegistry.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache S

Re: [PR] IGNITE-23440 Sql. Common internal API for canceling an operation of a certain type [ignite-3]

xtern commented on code in PR #4799: URL: https://github.com/apache/ignite-3/pull/4799#discussion_r1867718634 ## modules/sql-engine-api/src/main/java/org/apache/ignite/internal/sql/common/cancel/api/CancelHandlerRegistry.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache S

Re: [PR] IGNITE-23440 Sql. Common internal API for canceling an operation of a certain type [ignite-3]

xtern commented on code in PR #4799: URL: https://github.com/apache/ignite-3/pull/4799#discussion_r1867717881 ## modules/sql-engine-api/src/main/java/org/apache/ignite/internal/sql/common/cancel/api/CancelHandlerRegistry.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache S

Re: [PR] IGNITE-23440 Sql. Common internal API for canceling an operation of a certain type [ignite-3]

xtern commented on code in PR #4799: URL: https://github.com/apache/ignite-3/pull/4799#discussion_r1867720204 ## modules/sql-engine-api/src/main/java/org/apache/ignite/internal/sql/common/cancel/api/OperationCancelHandler.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-23440 Sql. Common internal API for canceling an operation of a certain type [ignite-3]

xtern commented on code in PR #4799: URL: https://github.com/apache/ignite-3/pull/4799#discussion_r1867717881 ## modules/sql-engine-api/src/main/java/org/apache/ignite/internal/sql/common/cancel/api/CancelHandlerRegistry.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache S

[PR] IGNITE-23716 Make the use of locks in PendingComparableValuesTracker and ReplicaManager close to IgniteSpinBusyLock [ignite-3]

tkalkirill opened a new pull request, #4822: URL: https://github.com/apache/ignite-3/pull/4822 https://issues.apache.org/jira/browse/IGNITE-23716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] IGNITE-23794 Added root cause for thrown IgniteClientException on client compute task failure [ignite]

NSAmelchev merged PR #11687: URL: https://github.com/apache/ignite/pull/11687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] IGNITE-23304 [ignite-3]

ascherbakoff opened a new pull request, #4821: URL: https://github.com/apache/ignite-3/pull/4821 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] IGNITE-23829 Fix --config={} in cluster init [ignite-3]

PakhomovAlexander merged PR #4820: URL: https://github.com/apache/ignite-3/pull/4820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

Re: [PR] IGNITE-23812 Eliminate race between partition and index destruction [ignite-3]

rpuch merged PR #4816: URL: https://github.com/apache/ignite-3/pull/4816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-23716 Make the use of locks in PendingComparableValuesTracker and ReplicaManager close to IgniteSpinBusyLock [ignite-3]

ivanzlenko commented on code in PR #4822: URL: https://github.com/apache/ignite-3/pull/4822#discussion_r1867907906 ## modules/core/src/main/java/org/apache/ignite/internal/util/IgniteStripedReadWriteLock.java: ## @@ -106,7 +106,7 @@ public Lock writeLock() { * @return {@co

[PR] IGNITE-23835 Simplify ProblemBuilder [ignite-3]

valepakh opened a new pull request, #4824: URL: https://github.com/apache/ignite-3/pull/4824 https://issues.apache.org/jira/browse/IGNITE-23835 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-23716 Make the use of locks in PendingComparableValuesTracker and ReplicaManager close to IgniteSpinBusyLock [ignite-3]

tkalkirill commented on code in PR #4822: URL: https://github.com/apache/ignite-3/pull/4822#discussion_r1867941763 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -1707,4 +1707,16 @@ private static ReplicationGroupIdMessage t

Re: [PR] IGNITE-23716 Make the use of locks in PendingComparableValuesTracker and ReplicaManager close to IgniteSpinBusyLock [ignite-3]

tkalkirill commented on code in PR #4822: URL: https://github.com/apache/ignite-3/pull/4822#discussion_r1867942492 ## modules/core/src/main/java/org/apache/ignite/internal/util/IgniteStripedReadWriteLock.java: ## @@ -106,7 +106,7 @@ public Lock writeLock() { * @return {@co

Re: [PR] IGNITE-23440 Sql. Common internal API for canceling an operation of a certain type [ignite-3]

xtern commented on code in PR #4799: URL: https://github.com/apache/ignite-3/pull/4799#discussion_r1867714567 ## modules/sql-engine-api/src/main/java/org/apache/ignite/internal/sql/common/cancel/api/CancelHandlerRegistry.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache S

Re: [PR] IGNITE-23716 Make the use of locks in PendingComparableValuesTracker and ReplicaManager close to IgniteSpinBusyLock [ignite-3]

tkalkirill merged PR #4822: URL: https://github.com/apache/ignite-3/pull/4822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-23525 Prolong all leases in batch if at least one of them needs to be prolonged [ignite-3]

vldpyatkov commented on code in PR #4798: URL: https://github.com/apache/ignite-3/pull/4798#discussion_r1867973495 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java: ## @@ -631,20 +656,25 @@ private Lease writeNewLease(

Re: [PR] IGNITE-23824 Fix compute job native result type deserialization [ignite-3]

valepakh commented on code in PR #4817: URL: https://github.com/apache/ignite-3/pull/4817#discussion_r1867978225 ## modules/compute/src/main/java/org/apache/ignite/internal/compute/ComputeUtils.java: ## @@ -509,7 +510,7 @@ static ComputeJobDataHolder marshalAndWrapResult(Object

Re: [PR] IGNITE-23525 Prolong all leases in batch if at least one of them needs to be prolonged [ignite-3]

vldpyatkov commented on code in PR #4798: URL: https://github.com/apache/ignite-3/pull/4798#discussion_r1867971274 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java: ## @@ -535,6 +542,24 @@ private void updateLeaseBatchInterna

Re: [PR] IGNITE-23525 Prolong all leases in batch if at least one of them needs to be prolonged [ignite-3]

vldpyatkov commented on code in PR #4798: URL: https://github.com/apache/ignite-3/pull/4798#discussion_r1867969010 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java: ## @@ -535,6 +542,24 @@ private void updateLeaseBatchInterna

Re: [PR] IGNITE-23727 Sql. Fix SqlRowHandler to return right schema after mapping [ignite-3]

xtern commented on code in PR #4807: URL: https://github.com/apache/ignite-3/pull/4807#discussion_r1867994378 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/ModifyNode.java: ## @@ -133,7 +132,8 @@ public ModifyNode( .m

[PR] IGNITE-23820 run privileged workflow against approved commit [ignite]

raboof opened a new pull request, #11691: URL: https://github.com/apache/ignite/pull/11691 `sonar-pr-from-fork-build.yml` and `sonar-pr-from-fork-scan.yml` analyze PRs. `sonar-pr-from-fork-scan.yml` needs privileges to access the `SONARCLOUD_TOKEN` and to update the status of the PR check.

Re: [PR] IGNITE-23819 Fix the time output in "Checkpoint finished" [ignite-3]

tkalkirill merged PR #4819: URL: https://github.com/apache/ignite-3/pull/4819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-23472 Fix JavaLogger [ignite]

timoninmaxim merged PR #11615: URL: https://github.com/apache/ignite/pull/11615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

[PR] Ignite 23826: update banners [ignite-website]

hoter opened a new pull request, #188: URL: https://github.com/apache/ignite-website/pull/188 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] IGNITE-23812 Eliminate race between partition and index destruction [ignite-3]

ibessonov commented on code in PR #4816: URL: https://github.com/apache/ignite-3/pull/4816#discussion_r1867212465 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageConcurrencyTest.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to t

[PR] IGNITE-23819 Fix the time output in "Checkpoint finished" [ignite-3]

tkalkirill opened a new pull request, #4819: URL: https://github.com/apache/ignite-3/pull/4819 https://issues.apache.org/jira/browse/IGNITE-23819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] IGNITE-23827 .NET: Fix IgniteClientGroupConfiguration.Size default value [ignite-3]

ptupitsyn merged PR #4818: URL: https://github.com/apache/ignite-3/pull/4818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-23440 Sql. Common internal API for canceling an operation of a certain type [ignite-3]

xtern commented on code in PR #4799: URL: https://github.com/apache/ignite-3/pull/4799#discussion_r1863075519 ## modules/sql-engine-api/README.md: ## @@ -0,0 +1 @@ +# Apache Ignite SQL Engine API module Review Comment: Description will be added after the first round of revie

Re: [PR] IGNITE-23464 Implement cancellation in JDBC [ignite-3]

ygerzhedovich commented on code in PR #4814: URL: https://github.com/apache/ignite-3/pull/4814#discussion_r1867548448 ## modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/JdbcConnection.java: ## @@ -78,6 +79,8 @@ public class JdbcConnection implements Connection {

Re: [PR] IGNITE-23824 Fix compute job native result type deserialization [ignite-3]

ptupitsyn commented on code in PR #4817: URL: https://github.com/apache/ignite-3/pull/4817#discussion_r1867771757 ## modules/compute/src/main/java/org/apache/ignite/internal/compute/ComputeUtils.java: ## @@ -509,7 +510,7 @@ static ComputeJobDataHolder marshalAndWrapResult(Object

[PR] IGNITE-23833 Remove unneeded ProblemJsonMediaTypeCodec [ignite-3]

valepakh opened a new pull request, #4823: URL: https://github.com/apache/ignite-3/pull/4823 https://issues.apache.org/jira/browse/IGNITE-23833 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] Ignite 23826: update banners [ignite-website]

ashapkin merged PR #188: URL: https://github.com/apache/ignite-website/pull/188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

[PR] IGNITE-23808 Remove MessageFactory [ignite]

nizhikov opened a new pull request, #11692: URL: https://github.com/apache/ignite/pull/11692 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

[PR] IGNITE-23829 Fix --config={} in cluster init [ignite-3]

PakhomovAlexander opened a new pull request, #4820: URL: https://github.com/apache/ignite-3/pull/4820 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] IGNITE-12678 Fix zero size GridLongList#add [ignite]

nizhikov opened a new pull request, #11693: URL: https://github.com/apache/ignite/pull/11693 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] IGNITE-23829 Fix --config={} in cluster init [ignite-3]

valepakh commented on code in PR #4820: URL: https://github.com/apache/ignite-3/pull/4820#discussion_r1867504559 ## modules/cli/src/main/java/org/apache/ignite/internal/cli/commands/cluster/init/ClusterInitOptions.java: ## @@ -182,6 +185,16 @@ String readConfigAsPath() {

Re: [PR] IGNITE-23820 Run privileged workflow against approved commit [ignite]

raboof commented on PR #11691: URL: https://github.com/apache/ignite/pull/11691#issuecomment-2514764101 > @raboof no changes required in `sonar-pr-from-fork-build.yml` ? Good observation, I removed the explicit checkout there as well to make sure it builds the reviewed version of the

Re: [PR] IGNITE-23824 Fix compute job native result type deserialization [ignite-3]

ptupitsyn commented on code in PR #4817: URL: https://github.com/apache/ignite-3/pull/4817#discussion_r1868002584 ## modules/compute/src/main/java/org/apache/ignite/internal/compute/ComputeUtils.java: ## @@ -509,7 +510,7 @@ static ComputeJobDataHolder marshalAndWrapResult(Object

Re: [PR] IGNITE-23727 Sql. Fix SqlRowHandler to return right schema after mapping [ignite-3]

xtern commented on code in PR #4807: URL: https://github.com/apache/ignite-3/pull/4807#discussion_r1867994378 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/ModifyNode.java: ## @@ -133,7 +132,8 @@ public ModifyNode( .m

Re: [PR] IGNITE-23833 Remove unneeded ProblemJsonMediaTypeCodec [ignite-3]

PakhomovAlexander merged PR #4823: URL: https://github.com/apache/ignite-3/pull/4823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

Re: [PR] IGNITE-23835 Simplify ProblemBuilder [ignite-3]

PakhomovAlexander merged PR #4824: URL: https://github.com/apache/ignite-3/pull/4824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[PR] IGNITE-15126 Fixes cluster hanging if exception occurred during activation. [ignite]

petrov-mg opened a new pull request, #11694: URL: https://github.com/apache/ignite/pull/11694 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### T

Re: [PR] IGNITE-23525 Prolong all leases in batch if at least one of them needs to be prolonged [ignite-3]

denis-chudov commented on code in PR #4798: URL: https://github.com/apache/ignite-3/pull/4798#discussion_r1868411271 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java: ## @@ -535,6 +542,24 @@ private void updateLeaseBatchInter

Re: [PR] IGNITE-23525 Prolong all leases in batch if at least one of them needs to be prolonged [ignite-3]

denis-chudov commented on code in PR #4798: URL: https://github.com/apache/ignite-3/pull/4798#discussion_r1868289450 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java: ## @@ -631,20 +656,25 @@ private Lease writeNewLease(

Re: [PR] IGNITE-23525 Prolong all leases in batch if at least one of them needs to be prolonged [ignite-3]

denis-chudov commented on code in PR #4798: URL: https://github.com/apache/ignite-3/pull/4798#discussion_r1868289269 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java: ## @@ -535,6 +542,24 @@ private void updateLeaseBatchInter

[PR] IGNITE-23815 Fix assertion during RotatedIdPartRecord read from WAL [ignite]

skorotkov opened a new pull request, #11695: URL: https://github.com/apache/ignite/pull/11695 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### T