ygerzhedovich commented on code in PR #4814:
URL: https://github.com/apache/ignite-3/pull/4814#discussion_r1867548448
##########
modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/JdbcConnection.java:
##########
@@ -78,6 +79,8 @@ public class JdbcConnection implements Connection {
/** Statements modification mutex. */
private final Object stmtsMux = new Object();
+ private final AtomicLong tokenGenerator = new AtomicLong(Long.MIN_VALUE);
Review Comment:
Are you afraid it will be insufficient if we start from 0?
##########
modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/JdbcStatement.java:
##########
@@ -90,6 +92,8 @@ public class JdbcStatement implements Statement {
/** Current result index. */
private int curRes;
+ private volatile @Nullable Long lastCorrelationToken;
Review Comment:
why not a just simple type 'long' and special value instead of null?
##########
modules/client-common/src/main/java/org/apache/ignite/internal/client/proto/ClientOp.java:
##########
@@ -180,6 +180,9 @@ public class ClientOp {
/** Check if all tuples with the given keys collection exist. */
public static final int TUPLE_CONTAINS_ALL_KEYS = 67;
+ /** Cancels the execution of JDBC statement .*/
Review Comment:
```suggestion
/** Cancels the execution of JDBC statement. */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
