[PR] IGNITE-23643 Improve logging on ClusterManagementGroupManager startup [ignite-3]

rpuch opened a new pull request, #4693: URL: https://github.com/apache/ignite-3/pull/4693 https://issues.apache.org/jira/browse/IGNITE-23643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Ignite 23430 debug [ignite-3]

lowka closed pull request #4696: Ignite 23430 debug URL: https://github.com/apache/ignite-3/pull/4696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: no

Re: [PR] IGNITE-23644 Unmute testDropColumn and testMergeChangesAddDropAdd in ItSchemaChangeKvViewTest [ignite-3]

sanpwc merged PR #4695: URL: https://github.com/apache/ignite-3/pull/4695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

Re: [PR] IGNITE-23621 Data Streamer: report failed entries on error [ignite-3]

ptupitsyn merged PR #4691: URL: https://github.com/apache/ignite-3/pull/4691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[PR] IGNITE-23644 Unmute testDropColumn and testMergeChangesAddDropAdd in ItSchemaChangeKvViewTest [ignite-3]

sanpwc opened a new pull request, #4695: URL: https://github.com/apache/ignite-3/pull/4695 https://issues.apache.org/jira/browse/IGNITE-23644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1834067496 ## modules/core/src/main/java/org/apache/ignite/lang/CancelHandleHelper.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1834067496 ## modules/core/src/main/java/org/apache/ignite/lang/CancelHandleHelper.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1834075134 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/QueryProcessor.java: ## @@ -55,6 +58,7 @@ CompletableFuture prepareSingleAsync(SqlProperties p

Re: [PR] IGNITE-23516 : Calcite. Unify rounding of numerics v2 [ignite]

asfgit closed pull request #11644: IGNITE-23516 : Calcite. Unify rounding of numerics v2 URL: https://github.com/apache/ignite/pull/11644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] IGNITE-22759 Do not do partition SafeTime sync if previous attempt is not finished [ignite-3]

sanpwc commented on code in PR #4684: URL: https://github.com/apache/ignite-3/pull/4684#discussion_r1833909188 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -1086,16 +1097,64 @@ private void idleSafeTimeSync() { }

Re: [PR] IGNITE-22759 Do not do partition SafeTime sync if previous attempt is not finished [ignite-3]

rpuch commented on code in PR #4684: URL: https://github.com/apache/ignite-3/pull/4684#discussion_r1834117740 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/PlacementDriverManager.java: ## @@ -278,6 +278,11 @@ private void recoverInternalCom

Re: [PR] IGNITE-22733 Support transactions in Scan query [ignite]

sonarcloud[bot] commented on PR #11580: URL: https://github.com/apache/ignite/pull/11580#issuecomment-2464376427 ## [](https://sonarcl

[PR] IGNITE-23621 Data Streamer: report failed entries on error [ignite-3]

ptupitsyn opened a new pull request, #4691: URL: https://github.com/apache/ignite-3/pull/4691 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] IGNITE-22733 Support transactions in Scan query [ignite]

sonarcloud[bot] commented on PR #11580: URL: https://github.com/apache/ignite/pull/11580#issuecomment-2464039912 ## [](https://sonarcl

Re: [PR] IGNITE-20322 Add ability to pass an observable timestamp to an implicit transaction [ignite-3]

ascherbakoff commented on code in PR #2537: URL: https://github.com/apache/ignite-3/pull/2537#discussion_r1833956830 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/TransactionIds.java: ## @@ -34,8 +37,8 @@ public class TransactionIds { * @param priorit

Re: [PR] IGNITE-20322 Add ability to pass an observable timestamp to an implicit transaction [ignite-3]

ascherbakoff commented on code in PR #2537: URL: https://github.com/apache/ignite-3/pull/2537#discussion_r1833956830 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/TransactionIds.java: ## @@ -34,8 +37,8 @@ public class TransactionIds { * @param priorit

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

korlov42 commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1834191539 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/QueryExecutor.java: ## @@ -310,13 +314,26 @@ MultiStatementHandler createScriptHand

[PR] IGNITE-23624 : Calcite. Support aggregate functions BIT_AND, BIT_OR, BIT_XOR. [ignite]

Vladsz83 opened a new pull request, #11649: URL: https://github.com/apache/ignite/pull/11649 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] IGNITE-22573 Fix warnings of IpFinderCleaner [ignite]

J-Bakuli commented on code in PR #11637: URL: https://github.com/apache/ignite/pull/11637#discussion_r1834218161 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -937,8 +937,11 @@ private boolean pingNode(TcpDiscoveryNode node) {

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1834371105 ## modules/api/src/main/java/org/apache/ignite/lang/CancelHandleImpl.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1834376809 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/QueryExecutor.java: ## @@ -310,13 +314,26 @@ MultiStatementHandler createScriptHandler

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1834377060 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/KeyValueModifyPlan.java: ## @@ -141,7 +141,7 @@ public AsyncCursor execute(

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1834377337 ## modules/api/src/main/java/org/apache/ignite/lang/CancelHandleImpl.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1834378072 ## modules/api/src/main/java/org/apache/ignite/lang/CancelHandleImpl.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] IGNITE-20322 Add ability to pass an observable timestamp to an implicit transaction [ignite-3]

ascherbakoff commented on code in PR #2537: URL: https://github.com/apache/ignite-3/pull/2537#discussion_r1834007776 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/IgniteTransactionsImpl.java: ## @@ -103,8 +103,18 @@ public CompletableFuture beginAsync(

[PR] IGNITE-23317 [ignite-3]

xtern opened a new pull request, #4692: URL: https://github.com/apache/ignite-3/pull/4692 https://issues.apache.org/jira/browse/IGNITE-23317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-23472 Fix JavaLogger [ignite]

chesnokoff commented on code in PR #11615: URL: https://github.com/apache/ignite/pull/11615#discussion_r1834409657 ## modules/core/src/test/java/org/apache/ignite/logger/java/JavaLoggerTest.java: ## @@ -17,31 +17,154 @@ package org.apache.ignite.logger.java; +import java.io

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1834339446 ## modules/core/src/main/java/org/apache/ignite/lang/CancelHandleHelper.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1834343271 ## modules/api/src/main/java/org/apache/ignite/lang/CancelHandleImpl.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] IGNITE-22759 Do not do partition SafeTime sync if previous attempt is not finished [ignite-3]

rpuch commented on PR #4111: URL: https://github.com/apache/ignite-3/pull/4111#issuecomment-2464687149 Superceded by #4684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] IGNITE-22759 Do not do partition SafeTime sync if previous attempt is not finished [ignite-3]

rpuch merged PR #4684: URL: https://github.com/apache/ignite-3/pull/4684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-22759 Do not do partition SafeTime sync if previous attempt is not finished [ignite-3]

rpuch closed pull request #4111: IGNITE-22759 Do not do partition SafeTime sync if previous attempt is not finished URL: https://github.com/apache/ignite-3/pull/4111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] IGNITE-23472 Fix JavaLogger [ignite]

chesnokoff commented on code in PR #11615: URL: https://github.com/apache/ignite/pull/11615#discussion_r1834361455 ## modules/core/src/test/java/org/apache/ignite/logger/java/JavaLoggerTest.java: ## @@ -84,4 +207,13 @@ public void testLogInitialize() throws Exception {

Re: [PR] IGNITE-23472 Fix JavaLogger [ignite]

chesnokoff commented on code in PR #11615: URL: https://github.com/apache/ignite/pull/11615#discussion_r1834361455 ## modules/core/src/test/java/org/apache/ignite/logger/java/JavaLoggerTest.java: ## @@ -84,4 +207,13 @@ public void testLogInitialize() throws Exception {

Re: [PR] IGNITE-23472 Fix JavaLogger [ignite]

chesnokoff commented on code in PR #11615: URL: https://github.com/apache/ignite/pull/11615#discussion_r1834361455 ## modules/core/src/test/java/org/apache/ignite/logger/java/JavaLoggerTest.java: ## @@ -84,4 +207,13 @@ public void testLogInitialize() throws Exception {

Re: [PR] IGNITE-23472 Fix JavaLogger [ignite]

chesnokoff commented on code in PR #11615: URL: https://github.com/apache/ignite/pull/11615#discussion_r1834361455 ## modules/core/src/test/java/org/apache/ignite/logger/java/JavaLoggerTest.java: ## @@ -84,4 +207,13 @@ public void testLogInitialize() throws Exception {

Re: [PR] IGNITE-23472 Fix JavaLogger [ignite]

chesnokoff commented on code in PR #11615: URL: https://github.com/apache/ignite/pull/11615#discussion_r1834361455 ## modules/core/src/test/java/org/apache/ignite/logger/java/JavaLoggerTest.java: ## @@ -84,4 +207,13 @@ public void testLogInitialize() throws Exception {

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1834407649 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/QueryExecutor.java: ## @@ -310,13 +314,26 @@ MultiStatementHandler createScriptHandler

Re: [PR] IGNITE-23472 Fix JavaLogger [ignite]

chesnokoff commented on code in PR #11615: URL: https://github.com/apache/ignite/pull/11615#discussion_r1834409657 ## modules/core/src/test/java/org/apache/ignite/logger/java/JavaLoggerTest.java: ## @@ -17,31 +17,154 @@ package org.apache.ignite.logger.java; +import java.io

Re: [PR] IGNITE-23472 Fix JavaLogger [ignite]

timoninmaxim commented on code in PR #11615: URL: https://github.com/apache/ignite/pull/11615#discussion_r1834421285 ## modules/core/src/test/java/org/apache/ignite/logger/java/JavaLoggerTest.java: ## @@ -84,4 +153,5 @@ public void testLogInitialize() throws Exception {

Re: [PR] IGNITE-23631 Optimize NetworkMessageChunkedInput constructor [ignite-3]

rpuch commented on code in PR #4689: URL: https://github.com/apache/ignite-3/pull/4689#discussion_r1833916762 ## modules/network/src/main/java/org/apache/ignite/internal/network/netty/OutboundEncoder.java: ## @@ -98,11 +98,17 @@ private NetworkMessageChunkedInput( t

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1833917686 ## modules/api/src/main/java/org/apache/ignite/lang/CancelHandleImpl.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1833914028 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/lang/ItQueryCancelTest.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1833914539 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/QueryCancel.java: ## @@ -22,13 +22,32 @@ import java.util.concurrent.CompletableFuture; impor

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1833913438 ## modules/core/src/main/java/org/apache/ignite/lang/CancelHandleHelper.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] IGNITE-22759 Do not do partition SafeTime sync if previous attempt is not finished [ignite-3]

sanpwc commented on code in PR #4684: URL: https://github.com/apache/ignite-3/pull/4684#discussion_r1833923480 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/PlacementDriverManager.java: ## @@ -278,6 +278,11 @@ private void recoverInternalCo

Re: [PR] IGNITE-23600 Extend GLOBAL_PARTITION_STATES and LOCAL_PARTITION_STATES system views [ignite-3]

ibessonov merged PR #4681: URL: https://github.com/apache/ignite-3/pull/4681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-23571 resetPartitions improvements: do not try to recover replica factor after not manual reset [ignite-3]

alievmirza commented on code in PR #4686: URL: https://github.com/apache/ignite-3/pull/4686#discussion_r1833944704 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/DisasterRecoveryRequestSerializer.java: ## @@ -50,7 +50,7 @@ protected Disaster

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1833938786 ## modules/api/src/main/java/org/apache/ignite/lang/CancelHandleImpl.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1833938986 ## modules/api/src/main/java/org/apache/ignite/lang/CancelHandleImpl.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] IGNITE-23600 Extend GLOBAL_PARTITION_STATES and LOCAL_PARTITION_STATES system views [ignite-3]

ivanzlenko commented on PR #4681: URL: https://github.com/apache/ignite-3/pull/4681#issuecomment-2464135977 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] IGNITE-23571 resetPartitions improvements: do not try to recover replica factor after not manual reset [ignite-3]

sanpwc merged PR #4686: URL: https://github.com/apache/ignite-3/pull/4686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

Re: [PR] IGNITE-23631 Optimize NetworkMessageChunkedInput constructor [ignite-3]

rpuch commented on code in PR #4689: URL: https://github.com/apache/ignite-3/pull/4689#discussion_r1834097038 ## modules/network/src/main/java/org/apache/ignite/internal/network/netty/OutboundEncoder.java: ## @@ -98,11 +98,17 @@ private NetworkMessageChunkedInput( t

Re: [PR] IGNITE-23631 Optimize NetworkMessageChunkedInput constructor [ignite-3]

rpuch merged PR #4689: URL: https://github.com/apache/ignite-3/pull/4689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[PR] Ignite 23430 debug [ignite-3]

lowka opened a new pull request, #4696: URL: https://github.com/apache/ignite-3/pull/4696 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ###