ascherbakoff commented on code in PR #2537:
URL: https://github.com/apache/ignite-3/pull/2537#discussion_r1833956830
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/TransactionIds.java:
##########
@@ -34,8 +37,8 @@ public class TransactionIds {
* @param priority Transaction priority.
* @return Transaction ID corresponding to the provided values.
*/
- public static UUID transactionId(HybridTimestamp beginTimestamp, int
nodeId, TxPriority priority) {
- return transactionId(beginTimestamp.longValue(), nodeId, priority);
+ public static UUID transactionId(HybridTimestamp beginTimestamp, int
nodeId, boolean implicit, TxPriority priority) {
Review Comment:
I believe adding implicit flag to txId is wrong.
1. It's not related to ticket description.
2. It has no use in the product
3. It affects future backward compatibility.
Instead, it should be moved to internal tx state field:
`private boolean implicit;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
