[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226680971 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -407,70 +423,83 @@ private CompletableFuture>> querySingle0

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226702935 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -407,70 +423,83 @@ private CompletableFuture>> querySingle0

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226702935 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -407,70 +423,83 @@ private CompletableFuture>> querySingle0

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226710781 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/CacheKey.java: ## @@ -18,48 +18,34 @@ package org.apache.ignite.internal.sql.engi

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226710781 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/CacheKey.java: ## @@ -18,48 +18,34 @@ package org.apache.ignite.internal.sql.engi

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226729461 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/CacheKey.java: ## @@ -80,9 +66,6 @@ public boolean equals(Object o) { if

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226747351 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -244,7 +260,7 @@ public synchronized void start() {

[GitHub] [ignite-3] AMashenkov merged pull request #2174: IGNITE-19304 Forbid creating index on the duplicate columns

AMashenkov merged PR #2174: URL: https://github.com/apache/ignite-3/pull/2174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.

AMashenkov commented on code in PR #2140: URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1226776026 ## modules/core/src/main/java/org/apache/ignite/internal/thread/StripedThreadPoolExecutor.java: ## @@ -105,7 +106,7 @@ public void execute(Runnable cmd) { * @

[GitHub] [ignite-3] lowka commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.

lowka commented on code in PR #2140: URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1226780794 ## modules/core/src/main/java/org/apache/ignite/internal/thread/StripedThreadPoolExecutor.java: ## @@ -105,7 +106,7 @@ public void execute(Runnable cmd) { * @throw

[GitHub] [ignite-3] xtern commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

xtern commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1227149541 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -407,70 +423,83 @@ private CompletableFuture>> querySingle0(

[GitHub] [ignite-extensions] Noone-No commented on pull request #94: IGNITE-16124 change signature in method deleteAllById in spring data 2.2

Noone-No commented on PR #94: URL: https://github.com/apache/ignite-extensions/pull/94#issuecomment-1588492617 how to fix this error ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [ignite-3] ptupitsyn merged pull request #2180: IGNITE-19707 Fix AssertionError in DistributionZoneManagerScaleUpTest

ptupitsyn merged PR #2180: URL: https://github.com/apache/ignite-3/pull/2180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2171: IGNITE-19600 Removed topologyVersionedDataNodes

alievmirza commented on code in PR #2171: URL: https://github.com/apache/ignite-3/pull/2171#discussion_r1227592992 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerLogicalTopologyEventsTest.java: ## @@ -45,6 +48,9 @@

[GitHub] [ignite-3] ibessonov merged pull request #2175: IGNITE-19698 Add node name to threads in DefaultMessagingService

ibessonov merged PR #2175: URL: https://github.com/apache/ignite-3/pull/2175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] Pochatkin commented on a diff in pull request #2146: IGNITE-19517 Cache JobClassLoaders

Pochatkin commented on code in PR #2146: URL: https://github.com/apache/ignite-3/pull/2146#discussion_r1226244893 ## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/DeploymentUnitAccessor.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite] wendigo commented on pull request #10764: IGNITE-19652 Adapt to DirectByteBuffer ctor changes in JDK 21

wendigo commented on PR #10764: URL: https://github.com/apache/ignite/pull/10764#issuecomment-1586823354 @NSAmelchev ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2152: IGNITE-19522 Modify deploy unit command

sashapolo commented on code in PR #2152: URL: https://github.com/apache/ignite-3/pull/2152#discussion_r1226309820 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/raft/CmgRaftService.java: ## @@ -228,6 +228,38 @@ public Set nodeNames() {

[GitHub] [ignite-3] valepakh commented on a diff in pull request #2152: IGNITE-19522 Modify deploy unit command

valepakh commented on code in PR #2152: URL: https://github.com/apache/ignite-3/pull/2152#discussion_r1226333402 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/raft/CmgRaftService.java: ## @@ -228,6 +228,38 @@ public Set nodeNames() {

[GitHub] [ignite-3] denis-chudov opened a new pull request, #2179: IGNITE-19079 ExecutionTimeout in ItIgniteNodeRestartTest

denis-chudov opened a new pull request, #2179: URL: https://github.com/apache/ignite-3/pull/2179 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #2152: IGNITE-19522 Modify deploy unit command

PakhomovAlexander commented on code in PR #2152: URL: https://github.com/apache/ignite-3/pull/2152#discussion_r1226345268 ## modules/rest-api/openapi/openapi.yaml: ## @@ -469,29 +469,42 @@ paths: application/problem+json: schema: $ref

[GitHub] [ignite-3] PakhomovAlexander merged pull request #2169: IGNITE-19090 Don't show progress bar in case of an error

PakhomovAlexander merged PR #2169: URL: https://github.com/apache/ignite-3/pull/2169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [ignite-3] valepakh commented on a diff in pull request #2152: IGNITE-19522 Modify deploy unit command

valepakh commented on code in PR #2152: URL: https://github.com/apache/ignite-3/pull/2152#discussion_r1226365198 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/raft/CmgRaftService.java: ## @@ -228,6 +228,38 @@ public Set nodeNames() {

[GitHub] [ignite-3] PakhomovAlexander merged pull request #2151: IGNITE-19518 Validate unit after node restart

PakhomovAlexander merged PR #2151: URL: https://github.com/apache/ignite-3/pull/2151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [ignite-3] kgusakov commented on a diff in pull request #2157: IGNITE-18692 ItRebalanceTest fix

kgusakov commented on code in PR #2157: URL: https://github.com/apache/ignite-3/pull/2157#discussion_r1226381748 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -565,11 +571,17 @@ private CompletableFuture onTableCreate(Confi

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2157: IGNITE-18692 ItRebalanceTest fix

sergeyuttsel commented on code in PR #2157: URL: https://github.com/apache/ignite-3/pull/2157#discussion_r1226402939 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -565,11 +571,17 @@ private CompletableFuture onTableCreate(C

[GitHub] [ignite-3] Pochatkin commented on a diff in pull request #2146: IGNITE-19517 Cache JobClassLoaders

Pochatkin commented on code in PR #2146: URL: https://github.com/apache/ignite-3/pull/2146#discussion_r1226496748 ## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/FileDeployerService.java: ## @@ -145,7 +146,22 @@ public FileVisitResult visitFile(Pat

[GitHub] [ignite-3] alievmirza opened a new pull request, #2180: IGNITE-19707 fix an assertion error in a test

alievmirza opened a new pull request, #2180: URL: https://github.com/apache/ignite-3/pull/2180 https://issues.apache.org/jira/browse/IGNITE-19707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite-3] zstan opened a new pull request, #2181: IGNITE-19709 Sql. Get rid of starting implicit transactions for SELECT statements without FROM keyword, change mapping

zstan opened a new pull request, #2181: URL: https://github.com/apache/ignite-3/pull/2181 …T statements without FROM keyword, change mapping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2182: IGNITE-19545 .NET: Add Basic Data Streamer

ptupitsyn opened a new pull request, #2182: URL: https://github.com/apache/ignite-3/pull/2182 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [ignite-3] zstan commented on pull request #2181: IGNITE-19709 Sql. Get rid of starting implicit transactions for SELECT statements without FROM keyword, change mapping

zstan commented on PR #2181: URL: https://github.com/apache/ignite-3/pull/2181#issuecomment-1587358217 @korlov42 can u make a review ? There are exist some questionable places as for me. It`s not clear question - can Boolean hold ternary logic or only binary, i think it can ) -- This

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226680971 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -407,70 +423,83 @@ private CompletableFuture>> querySingle0

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226680971 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -407,70 +423,83 @@ private CompletableFuture>> querySingle0

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226680971 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -407,70 +423,83 @@ private CompletableFuture>> querySingle0