Pochatkin commented on code in PR #2146:
URL: https://github.com/apache/ignite-3/pull/2146#discussion_r1226496748


##########
modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/FileDeployerService.java:
##########
@@ -145,7 +146,22 @@ public FileVisitResult visitFile(Path file, 
BasicFileAttributes attrs) throws IO
      * @param version Deployment unit version.
      * @return Path to unit folder.
      */
-    public Path unitPath(String id, Version version) {
+    Path unitPath(String id, Version version, boolean checkExistence) {

Review Comment:
   Javadoc for checkExistance



##########
modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/DeploymentManagerImpl.java:
##########
@@ -101,6 +101,8 @@ public class DeploymentManagerImpl implements 
IgniteDeployment {
      */
     private final DeployTracker tracker;
 
+    private final DeploymentUnitAccessor deploymentUnitAccessor;

Review Comment:
   Javadoc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to