[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2114: IGNITE-19398 ItIgniteNodeRestartTest optimized.

2023-05-30 Thread via GitHub
tkalkirill commented on code in PR #2114: URL: https://github.com/apache/ignite-3/pull/2114#discussion_r1209813741 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -2467,9 +2467,9 @@ public CompletableFut

[GitHub] [ignite] ivandasch commented on a diff in pull request #10737: IGNITE-15629 Cache indexes force rebuild command implemented

2023-05-30 Thread via GitHub
ivandasch commented on code in PR #10737: URL: https://github.com/apache/ignite/pull/10737#discussion_r1209814734 ## modules/core/src/main/java/org/apache/ignite/internal/management/cache/CacheIndexesRebuildStatusCommand.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache S

[GitHub] [ignite] ptupitsyn commented on issue #10746: Apache Ignite Table support Schemaless ?

2023-05-30 Thread via GitHub
ptupitsyn commented on issue #10746: URL: https://github.com/apache/ignite/issues/10746#issuecomment-1567902699 It will modify only the specified field. This may require rewriting the entire object if the new value is of different size. -- This is an automated message from the Apache Git

[GitHub] [ignite] ivandasch commented on a diff in pull request #10737: IGNITE-15629 Cache indexes force rebuild command implemented

2023-05-30 Thread via GitHub
ivandasch commented on code in PR #10737: URL: https://github.com/apache/ignite/pull/10737#discussion_r1209816382 ## modules/core/src/main/java/org/apache/ignite/internal/management/cache/CacheScheduleIndexesRebuildCommand.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apach

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2114: IGNITE-19398 ItIgniteNodeRestartTest optimized.

2023-05-30 Thread via GitHub
ibessonov commented on code in PR #2114: URL: https://github.com/apache/ignite-3/pull/2114#discussion_r1209821860 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -2467,9 +2467,9 @@ public CompletableFutu

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2114: IGNITE-19398 ItIgniteNodeRestartTest optimized.

2023-05-30 Thread via GitHub
ibessonov commented on code in PR #2114: URL: https://github.com/apache/ignite-3/pull/2114#discussion_r1209821860 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -2467,9 +2467,9 @@ public CompletableFutu

[GitHub] [ignite-3] rpuch opened a new pull request, #2116: IGNITE-19386 Switch to standard scalecube-cluster

2023-05-30 Thread via GitHub
rpuch opened a new pull request, #2116: URL: https://github.com/apache/ignite-3/pull/2116 https://issues.apache.org/jira/browse/IGNITE-19386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ignite-3] ibessonov opened a new pull request, #2117: IGNITE-19563 Fixed deadlock in partition commands handler

2023-05-30 Thread via GitHub
ibessonov opened a new pull request, #2117: URL: https://github.com/apache/ignite-3/pull/2117 https://issues.apache.org/jira/browse/IGNITE-19563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [ignite-3] ibessonov merged pull request #2114: IGNITE-19398 ItIgniteNodeRestartTest optimized.

2023-05-30 Thread via GitHub
ibessonov merged PR #2114: URL: https://github.com/apache/ignite-3/pull/2114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite] siaron commented on issue #10746: Apache Ignite Table support Schemaless ?

2023-05-30 Thread via GitHub
siaron commented on issue #10746: URL: https://github.com/apache/ignite/issues/10746#issuecomment-1568012187 Ignite will also serialize the entire value object internally and then update a certain field and write it into memory? -- This is an automated message from the Apache Git Service.

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2101: IGNITE-19488 Sql. Rework statistics, reject hash index usage with enabled search bounds

2023-05-30 Thread via GitHub
korlov42 commented on code in PR #2101: URL: https://github.com/apache/ignite-3/pull/2101#discussion_r1209939749 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/IgniteTableImpl.java: ## @@ -524,35 +526,56 @@ private ColocationGroup partitionedGro

[GitHub] [ignite] ptupitsyn commented on issue #10746: Apache Ignite Table support Schemaless ?

2023-05-30 Thread via GitHub
ptupitsyn commented on issue #10746: URL: https://github.com/apache/ignite/issues/10746#issuecomment-1568027001 The data is stored in serialized form (think byte array). Ignite knows the offset of every field in this byte array. Only the modified field will be updated, other fields are not

[GitHub] [ignite-3] Flaugh24 opened a new pull request, #2118: IGNITE-19595 ItClusterManagerTest.testClusterConfigurationIsRemovedFr…

2023-05-30 Thread via GitHub
Flaugh24 opened a new pull request, #2118: URL: https://github.com/apache/ignite-3/pull/2118 …omClusterStateAfterUpdating increase timeout -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [ignite-3] Flaugh24 commented on pull request #2118: IGNITE-19595 ItClusterManagerTest.testClusterConfigurationIsRemovedFr…

2023-05-30 Thread via GitHub
Flaugh24 commented on PR #2118: URL: https://github.com/apache/ignite-3/pull/2118#issuecomment-1568039361 https://issues.apache.org/jira/browse/IGNITE-19595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [ignite-3] ibessonov merged pull request #2116: IGNITE-19386 Switch to standard scalecube-cluster

2023-05-30 Thread via GitHub
ibessonov merged PR #2116: URL: https://github.com/apache/ignite-3/pull/2116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite] nizhikov merged pull request #10737: IGNITE-15629 Cache indexes force rebuild command implemented

2023-05-30 Thread via GitHub
nizhikov merged PR #10737: URL: https://github.com/apache/ignite/pull/10737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2070: IGNITE-19405 Remove assignments from table configuration

2023-05-30 Thread via GitHub
sergeyuttsel commented on code in PR #2070: URL: https://github.com/apache/ignite-3/pull/2070#discussion_r1209958053 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java: ## @@ -1038,7 +1038,9 @@ public void testOneNodeRes

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10737: IGNITE-15629 Cache indexes force rebuild command implemented

2023-05-30 Thread via GitHub
sonarcloud[bot] commented on PR #10737: URL: https://github.com/apache/ignite/pull/10737#issuecomment-1568062022 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10675: IGNITE-15629 Management API introduced

2023-05-30 Thread via GitHub
sonarcloud[bot] commented on PR #10675: URL: https://github.com/apache/ignite/pull/10675#issuecomment-1568065844 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10740: IGNITE-15629 Cache clear/create/list commands implemented

2023-05-30 Thread via GitHub
sonarcloud[bot] commented on PR #10740: URL: https://github.com/apache/ignite/pull/10740#issuecomment-1568100569 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] ibessonov merged pull request #2117: IGNITE-19563 Fixed deadlock in partition commands handler

2023-05-30 Thread via GitHub
ibessonov merged PR #2117: URL: https://github.com/apache/ignite-3/pull/2117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite] siaron commented on issue #10746: Apache Ignite Table support Schemaless ?

2023-05-30 Thread via GitHub
siaron commented on issue #10746: URL: https://github.com/apache/ignite/issues/10746#issuecomment-1568113063 Use the key, value api to operate the table, how to update the schema of the table after dynamically adding columns -- This is an automated message from the Apache Git Service. To

[GitHub] [ignite] ptupitsyn commented on issue #10746: Apache Ignite Table support Schemaless ?

2023-05-30 Thread via GitHub
ptupitsyn commented on issue #10746: URL: https://github.com/apache/ignite/issues/10746#issuecomment-1568127310 > Use the key, value api to dynamically add colum on Cache, how to update table schema . Use `ALTER TABLE .. ADD COLUMN ..` to update the SQL schema. See the example above

[GitHub] [ignite] asfgit closed pull request #10751: IGNITE-19585 SQL Calcite: Fix performance statistics gathering

2023-05-30 Thread via GitHub
asfgit closed pull request #10751: IGNITE-19585 SQL Calcite: Fix performance statistics gathering URL: https://github.com/apache/ignite/pull/10751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10751: IGNITE-19585 SQL Calcite: Fix performance statistics gathering

2023-05-30 Thread via GitHub
sonarcloud[bot] commented on PR #10751: URL: https://github.com/apache/ignite/pull/10751#issuecomment-1568137769 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2070: IGNITE-19405 Remove assignments from table configuration

2023-05-30 Thread via GitHub
alievmirza commented on code in PR #2070: URL: https://github.com/apache/ignite-3/pull/2070#discussion_r1210054539 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -544,16 +548,60 @@ private CompletableFuture onTableCreate(Con

[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #2102: IGNITE-19476 On demand deploy units API

2023-05-30 Thread via GitHub
PakhomovAlexander commented on code in PR #2102: URL: https://github.com/apache/ignite-3/pull/2102#discussion_r1209939241 ## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/DeployTracker.java: ## @@ -55,7 +55,7 @@ public CompletableFuture track(Strin

[GitHub] [ignite-3] AMashenkov opened a new pull request, #2119: IGNITE-19592 Implement ADD/DROP COLUMN DDL commands with using Catalog

2023-05-30 Thread via GitHub
AMashenkov opened a new pull request, #2119: URL: https://github.com/apache/ignite-3/pull/2119 https://issues.apache.org/jira/browse/IGNITE-19592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite-3] Pochatkin commented on a diff in pull request #2102: IGNITE-19476 On demand deploy units API

2023-05-30 Thread via GitHub
Pochatkin commented on code in PR #2102: URL: https://github.com/apache/ignite-3/pull/2102#discussion_r1210086064 ## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/DeploymentManagerImpl.java: ## @@ -111,10 +115,38 @@ public DeploymentManagerImpl(Clus

[GitHub] [ignite-3] tkalkirill opened a new pull request, #2120: IGNITE-19053 Handle the case of changing the leader of the raft group when building the index

2023-05-30 Thread via GitHub
tkalkirill opened a new pull request, #2120: URL: https://github.com/apache/ignite-3/pull/2120 https://issues.apache.org/jira/browse/IGNITE-19053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #2102: IGNITE-19476 On demand deploy units API

2023-05-30 Thread via GitHub
PakhomovAlexander commented on code in PR #2102: URL: https://github.com/apache/ignite-3/pull/2102#discussion_r1210108258 ## modules/code-deployment/src/test/java/org/apache/ignite/deployment/metastore/DeploymentUnitStoreImplTest.java: ## @@ -58,7 +58,7 @@ public class Deploymen

[GitHub] [ignite-3] zstan commented on pull request #2101: IGNITE-19488 Sql. Rework statistics, reject hash index usage with enabled search bounds

2023-05-30 Thread via GitHub
zstan commented on PR #2101: URL: https://github.com/apache/ignite-3/pull/2101#issuecomment-1568234105 @korlov42 plz check last fixes ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [ignite-3] sergeyuttsel commented on pull request #2070: IGNITE-19405 Remove assignments from table configuration

2023-05-30 Thread via GitHub
sergeyuttsel commented on PR #2070: URL: https://github.com/apache/ignite-3/pull/2070#issuecomment-1568302440 Previously it was discussed that usage of DistributionZoneManager#topologyVersionedDataNodes method will be removed in this pr. So why it is not removed? -- This is an automated

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10735: IGNITE-19564 : Snapshot restoration metric is not always assigned when an error occurs.

2023-05-30 Thread via GitHub
sonarcloud[bot] commented on PR #10735: URL: https://github.com/apache/ignite/pull/10735#issuecomment-1568327190 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] zstan merged pull request #2101: IGNITE-19488 Sql. Rework statistics, reject hash index usage with enabled search bounds

2023-05-30 Thread via GitHub
zstan merged PR #2101: URL: https://github.com/apache/ignite-3/pull/2101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[GitHub] [ignite-3] ibessonov merged pull request #2118: IGNITE-19595 ItClusterManagerTest.testClusterConfigurationIsRemovedFr…

2023-05-30 Thread via GitHub
ibessonov merged PR #2118: URL: https://github.com/apache/ignite-3/pull/2118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite] siaron closed issue #10746: Apache Ignite Table support Schemaless ?

2023-05-30 Thread via GitHub
siaron closed issue #10746: Apache Ignite Table support Schemaless ? URL: https://github.com/apache/ignite/issues/10746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [ignite-3] kgusakov commented on a diff in pull request #2070: IGNITE-19405 Remove assignments from table configuration

2023-05-30 Thread via GitHub
kgusakov commented on code in PR #2070: URL: https://github.com/apache/ignite-3/pull/2070#discussion_r1210220957 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -1277,6 +1296,7 @@ private void dropTableLocally(long causalityTo

[GitHub] [ignite-3] kgusakov commented on a diff in pull request #2070: IGNITE-19405 Remove assignments from table configuration

2023-05-30 Thread via GitHub
kgusakov commented on code in PR #2070: URL: https://github.com/apache/ignite-3/pull/2070#discussion_r1210231112 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java: ## @@ -1038,7 +1038,9 @@ public void testOneNodeRestart

[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2070: IGNITE-19405 Remove assignments from table configuration

2023-05-30 Thread via GitHub
alievmirza commented on code in PR #2070: URL: https://github.com/apache/ignite-3/pull/2070#discussion_r1210234818 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -544,16 +548,60 @@ private CompletableFuture onTableCreate(Con

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2070: IGNITE-19405 Remove assignments from table configuration

2023-05-30 Thread via GitHub
sergeyuttsel commented on code in PR #2070: URL: https://github.com/apache/ignite-3/pull/2070#discussion_r1210247829 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java: ## @@ -1038,7 +1038,9 @@ public void testOneNodeRes

[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #2099: IGNITE-19475 Implement JobClassLoader

2023-05-30 Thread via GitHub
PakhomovAlexander commented on code in PR #2099: URL: https://github.com/apache/ignite-3/pull/2099#discussion_r1210260358 ## modules/compute/src/main/java/org/apache/ignite/internal/compute/JobClassLoaderFactory.java: ## @@ -28,26 +28,41 @@ import java.util.ArrayList; import j

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10638: IGNITE-19164 Improve message about requested partitions during snapshot restore

2023-05-30 Thread via GitHub
sonarcloud[bot] commented on PR #10638: URL: https://github.com/apache/ignite/pull/10638#issuecomment-1568457908 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] PakhomovAlexander merged pull request #2099: IGNITE-19475 Implement JobClassLoader

2023-05-30 Thread via GitHub
PakhomovAlexander merged PR #2099: URL: https://github.com/apache/ignite-3/pull/2099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10735: IGNITE-19564 : Snapshot restoration metric is not always assigned when an error occurs.

2023-05-30 Thread via GitHub
sonarcloud[bot] commented on PR #10735: URL: https://github.com/apache/ignite/pull/10735#issuecomment-1568530875 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] kgusakov commented on a diff in pull request #2070: IGNITE-19405 Remove assignments from table configuration

2023-05-30 Thread via GitHub
kgusakov commented on code in PR #2070: URL: https://github.com/apache/ignite-3/pull/2070#discussion_r1210377009 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java: ## @@ -1038,7 +1038,9 @@ public void testOneNodeRestart

[GitHub] [ignite-3] xtern commented on a diff in pull request #2108: IGNITE-19575 Extend jmh benchmarks to compare thin clients against its embedded counterparts

2023-05-30 Thread via GitHub
xtern commented on code in PR #2108: URL: https://github.com/apache/ignite-3/pull/2108#discussion_r1210356488 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/benchmark/InsertBenchmark.java: ## @@ -136,7 +159,54 @@ void executeQuery() { } /** -

[GitHub] [ignite-3] xtern commented on a diff in pull request #2119: IGNITE-19592 Implement ADD/DROP COLUMN DDL commands with using Catalog

2023-05-30 Thread via GitHub
xtern commented on code in PR #2119: URL: https://github.com/apache/ignite-3/pull/2119#discussion_r1210535149 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -205,13 +215,84 @@ public CompletableFuture dropTable(DropTableParams

[GitHub] [ignite-3] xtern commented on a diff in pull request #2119: IGNITE-19592 Implement ADD/DROP COLUMN DDL commands with using Catalog

2023-05-30 Thread via GitHub
xtern commented on code in PR #2119: URL: https://github.com/apache/ignite-3/pull/2119#discussion_r1210535149 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -205,13 +215,84 @@ public CompletableFuture dropTable(DropTableParams

[GitHub] [ignite-3] xtern commented on a diff in pull request #2119: IGNITE-19592 Implement ADD/DROP COLUMN DDL commands with using Catalog

2023-05-30 Thread via GitHub
xtern commented on code in PR #2119: URL: https://github.com/apache/ignite-3/pull/2119#discussion_r1210535149 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -205,13 +215,84 @@ public CompletableFuture dropTable(DropTableParams

[GitHub] [ignite-3] xtern commented on a diff in pull request #2119: IGNITE-19592 Implement ADD/DROP COLUMN DDL commands with using Catalog

2023-05-30 Thread via GitHub
xtern commented on code in PR #2119: URL: https://github.com/apache/ignite-3/pull/2119#discussion_r1210535149 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -205,13 +215,84 @@ public CompletableFuture dropTable(DropTableParams

[GitHub] [ignite-3] xtern commented on a diff in pull request #2119: IGNITE-19592 Implement ADD/DROP COLUMN DDL commands with using Catalog

2023-05-30 Thread via GitHub
xtern commented on code in PR #2119: URL: https://github.com/apache/ignite-3/pull/2119#discussion_r1210535149 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -205,13 +215,84 @@ public CompletableFuture dropTable(DropTableParams

[GitHub] [ignite-3] xtern commented on a diff in pull request #2119: IGNITE-19592 Implement ADD/DROP COLUMN DDL commands with using Catalog

2023-05-30 Thread via GitHub
xtern commented on code in PR #2119: URL: https://github.com/apache/ignite-3/pull/2119#discussion_r1210558019 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -205,13 +215,84 @@ public CompletableFuture dropTable(DropTableParams

[GitHub] [ignite-3] xtern commented on a diff in pull request #2119: IGNITE-19592 Implement ADD/DROP COLUMN DDL commands with using Catalog

2023-05-30 Thread via GitHub
xtern commented on code in PR #2119: URL: https://github.com/apache/ignite-3/pull/2119#discussion_r1210560522 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -205,13 +215,84 @@ public CompletableFuture dropTable(DropTableParams

[GitHub] [ignite-3] xtern commented on a diff in pull request #2119: IGNITE-19592 Implement ADD/DROP COLUMN DDL commands with using Catalog

2023-05-30 Thread via GitHub
xtern commented on code in PR #2119: URL: https://github.com/apache/ignite-3/pull/2119#discussion_r1210560522 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -205,13 +215,84 @@ public CompletableFuture dropTable(DropTableParams

[GitHub] [ignite] nizhikov opened a new pull request, #10752: IGNITE-15629 cache idle_verify command implemented

2023-05-30 Thread via GitHub
nizhikov opened a new pull request, #10752: URL: https://github.com/apache/ignite/pull/10752 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

[GitHub] [ignite-3] xtern commented on a diff in pull request #2119: IGNITE-19592 Implement ADD/DROP COLUMN DDL commands with using Catalog

2023-05-30 Thread via GitHub
xtern commented on code in PR #2119: URL: https://github.com/apache/ignite-3/pull/2119#discussion_r1210560522 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -205,13 +215,84 @@ public CompletableFuture dropTable(DropTableParams

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10752: IGNITE-15629 cache idle_verify command implemented

2023-05-30 Thread via GitHub
sonarcloud[bot] commented on PR #10752: URL: https://github.com/apache/ignite/pull/10752#issuecomment-1568778624 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] Flaugh24 opened a new pull request, #2121: IGNITE-19565 wip

2023-05-30 Thread via GitHub
Flaugh24 opened a new pull request, #2121: URL: https://github.com/apache/ignite-3/pull/2121 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2070: IGNITE-19405 Remove assignments from table configuration

2023-05-30 Thread via GitHub
vldpyatkov commented on code in PR #2070: URL: https://github.com/apache/ignite-3/pull/2070#discussion_r1210783894 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngine.java: ## @@ -187,39 +187,47 @@ pu

[GitHub] [ignite-3] alievmirza opened a new pull request, #2122: IGNITE-18963 Altering filters must recalculate data nodes

2023-05-30 Thread via GitHub
alievmirza opened a new pull request, #2122: URL: https://github.com/apache/ignite-3/pull/2122 https://issues.apache.org/jira/browse/IGNITE-18963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2122: IGNITE-18963 Altering filters must recalculate data nodes

2023-05-30 Thread via GitHub
sanpwc commented on code in PR #2122: URL: https://github.com/apache/ignite-3/pull/2122#discussion_r1211100017 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerAlterFilterTest.java: ## @@ -0,0 +1,340 @@ +/* + * Licen

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2122: IGNITE-18963 Altering filters must recalculate data nodes

2023-05-30 Thread via GitHub
sanpwc commented on code in PR #2122: URL: https://github.com/apache/ignite-3/pull/2122#discussion_r1211100708 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerAlterFilterTest.java: ## @@ -0,0 +1,340 @@ +/* + * Licen

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2122: IGNITE-18963 Altering filters must recalculate data nodes

2023-05-30 Thread via GitHub
sanpwc commented on code in PR #2122: URL: https://github.com/apache/ignite-3/pull/2122#discussion_r1211100017 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerAlterFilterTest.java: ## @@ -0,0 +1,340 @@ +/* + * Licen

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2122: IGNITE-18963 Altering filters must recalculate data nodes

2023-05-30 Thread via GitHub
sanpwc commented on code in PR #2122: URL: https://github.com/apache/ignite-3/pull/2122#discussion_r1211101912 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerAlterFilterTest.java: ## @@ -0,0 +1,340 @@ +/* + * Licen

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2122: IGNITE-18963 Altering filters must recalculate data nodes

2023-05-30 Thread via GitHub
sanpwc commented on code in PR #2122: URL: https://github.com/apache/ignite-3/pull/2122#discussion_r1211101912 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerAlterFilterTest.java: ## @@ -0,0 +1,340 @@ +/* + * Licen

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2122: IGNITE-18963 Altering filters must recalculate data nodes

2023-05-30 Thread via GitHub
sanpwc commented on code in PR #2122: URL: https://github.com/apache/ignite-3/pull/2122#discussion_r1211103160 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerAlterFilterTest.java: ## @@ -0,0 +1,340 @@ +/* + * Licen

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2122: IGNITE-18963 Altering filters must recalculate data nodes

2023-05-30 Thread via GitHub
sanpwc commented on code in PR #2122: URL: https://github.com/apache/ignite-3/pull/2122#discussion_r1211132499 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerAlterFilterTest.java: ## @@ -0,0 +1,340 @@ +/* + * Licen

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2122: IGNITE-18963 Altering filters must recalculate data nodes

2023-05-30 Thread via GitHub
sanpwc commented on code in PR #2122: URL: https://github.com/apache/ignite-3/pull/2122#discussion_r1211100017 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerAlterFilterTest.java: ## @@ -0,0 +1,340 @@ +/* + * Licen

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2122: IGNITE-18963 Altering filters must recalculate data nodes

2023-05-30 Thread via GitHub
sanpwc commented on code in PR #2122: URL: https://github.com/apache/ignite-3/pull/2122#discussion_r1211140284 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerAlterFilterTest.java: ## @@ -0,0 +1,340 @@ +/* + * Licen

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2122: IGNITE-18963 Altering filters must recalculate data nodes

2023-05-30 Thread via GitHub
sanpwc commented on code in PR #2122: URL: https://github.com/apache/ignite-3/pull/2122#discussion_r1211150053 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerAlterFilterTest.java: ## @@ -0,0 +1,340 @@ +/* + * Licen

[GitHub] [ignite] ivandasch commented on a diff in pull request #10740: IGNITE-15629 Cache clear/create/list commands implemented

2023-05-30 Thread via GitHub
ivandasch commented on code in PR #10740: URL: https://github.com/apache/ignite/pull/10740#discussion_r1211155008 ## modules/core/src/main/java/org/apache/ignite/internal/visor/verify/VisorViewCacheTask.java: ## @@ -18,45 +18,53 @@ package org.apache.ignite.internal.visor.verif

[GitHub] [ignite-3] xtern commented on a diff in pull request #2119: IGNITE-19592 Implement ADD/DROP COLUMN DDL commands with using Catalog

2023-05-30 Thread via GitHub
xtern commented on code in PR #2119: URL: https://github.com/apache/ignite-3/pull/2119#discussion_r1210535149 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -205,13 +215,84 @@ public CompletableFuture dropTable(DropTableParams

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2122: IGNITE-18963 Altering filters must recalculate data nodes

2023-05-30 Thread via GitHub
sanpwc commented on code in PR #2122: URL: https://github.com/apache/ignite-3/pull/2122#discussion_r1211172010 ## modules/distribution-zones/src/testFixtures/java/org/apache/ignite/internal/distributionzones/DistributionZonesTestUtil.java: ## @@ -443,4 +443,34 @@ public static

[GitHub] [ignite-3] xtern commented on a diff in pull request #2119: IGNITE-19592 Implement ADD/DROP COLUMN DDL commands with using Catalog

2023-05-30 Thread via GitHub
xtern commented on code in PR #2119: URL: https://github.com/apache/ignite-3/pull/2119#discussion_r1211173130 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -205,13 +215,84 @@ public CompletableFuture dropTable(DropTableParams