[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2070: IGNITE-19405 Remove assignments from table configuration

[via GitHub]

alievmirza commented on code in PR #2070:
URL: https://github.com/apache/ignite-3/pull/2070#discussion_r1210234818


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -544,16 +548,60 @@ private CompletableFuture<?> 
onTableCreate(ConfigurationNotificationEvent<TableV
         }
 
         try {
-            return createTableLocally(
+            DistributionZoneView zone =
+                    getZoneById(distributionZonesConfiguration, 
(ctx.newValue()).zoneId()).value();
+
+            List<Set<Assignment>> assignments = 
AffinityUtils.calculateAssignments(
+                    
baselineMgr.nodes().stream().map(ClusterNode::name).collect(toList()),

Review Comment:
   I see that you've removed usage of 
`DistributionZoneManager#topologyVersionedDataNodes` in a further commit, so in 
general I'm ok with using `baselineMgr.nodes()` and adding to do 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org