Re: [PR] IGNITE-22662 Snapshot check refactoring [ignite]

2025-07-18 Thread via GitHub
sonarqubecloud[bot] commented on PR #11897: URL: https://github.com/apache/ignite/pull/11897#issuecomment-3090724963 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-25950 Code-generated serializer for GridCacheEntryInfo message [ignite]

2025-07-18 Thread via GitHub
timoninmaxim merged PR #12198: URL: https://github.com/apache/ignite/pull/12198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

Re: [PR] IGNITE-25950 Code-generated serializer for GridCacheEntryInfo message [ignite]

2025-07-18 Thread via GitHub
sonarqubecloud[bot] commented on PR #12198: URL: https://github.com/apache/ignite/pull/12198#issuecomment-3090549610 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-25848 fix several Critical system error caused by Meta Storage unavailability [ignite-3]

2025-07-18 Thread via GitHub
sanpwc merged PR #6243: URL: https://github.com/apache/ignite-3/pull/6243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[PR] IGNITE-25937 Extend the configuration of metric log exporter with optional white list of enabled metric sources [ignite-3]

2025-07-18 Thread via GitHub
denis-chudov opened a new pull request, #6282: URL: https://github.com/apache/ignite-3/pull/6282 https://issues.apache.org/jira/browse/IGNITE-25937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Bump org.springframework.data:spring-data-jdbc from 3.5.1 to 3.5.2 [ignite-3]

2025-07-18 Thread via GitHub
dependabot[bot] opened a new pull request, #6281: URL: https://github.com/apache/ignite-3/pull/6281 Bumps org.springframework.data:spring-data-jdbc from 3.5.1 to 3.5.2. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency

Re: [PR] IGNITE-25848 fix several Critical system error caused by Meta Storage unavailability [ignite-3]

2025-07-18 Thread via GitHub
alievmirza commented on code in PR #6243: URL: https://github.com/apache/ignite-3/pull/6243#discussion_r2216240305 ## modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/distributionzones/ItIgniteDistributionZoneManagerNodeRestartTest.java: ## @@ -515,

Re: [PR] IGNITE-25848 fix several Critical system error caused by Meta Storage unavailability [ignite-3]

2025-07-18 Thread via GitHub
sanpwc commented on code in PR #6243: URL: https://github.com/apache/ignite-3/pull/6243#discussion_r2216227663 ## modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/distributionzones/ItIgniteDistributionZoneManagerNodeRestartTest.java: ## @@ -515,7 +5

Re: [PR] IGNITE-25848 fix several Critical system error caused by Meta Storage unavailability [ignite-3]

2025-07-18 Thread via GitHub
alievmirza commented on code in PR #6243: URL: https://github.com/apache/ignite-3/pull/6243#discussion_r2216211515 ## modules/runner/src/testFixtures/java/org/apache/ignite/internal/BaseIgniteRestartTest.java: ## @@ -139,21 +146,93 @@ void setUp(TestInfo testInfo) { public

Re: [PR] IGNITE-25848 fix several Critical system error caused by Meta Storage unavailability [ignite-3]

2025-07-18 Thread via GitHub
alievmirza commented on code in PR #6243: URL: https://github.com/apache/ignite-3/pull/6243#discussion_r2216210892 ## modules/runner/src/testFixtures/java/org/apache/ignite/internal/BaseIgniteRestartTest.java: ## @@ -139,21 +146,93 @@ void setUp(TestInfo testInfo) { public

Re: [PR] IGNITE-25872 Enable FlushConsolidationHandler for client-server IO [ignite-3]

2025-07-18 Thread via GitHub
ptupitsyn commented on code in PR #6280: URL: https://github.com/apache/ignite-3/pull/6280#discussion_r2216176319 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java: ## @@ -351,6 +352,7 @@ protected void initChannel(Channel ch) {

Re: [PR] IGNITE-25872 Enable FlushConsolidationHandler for client-server IO. [ignite-3]

2025-07-18 Thread via GitHub
ptupitsyn commented on code in PR #6280: URL: https://github.com/apache/ignite-3/pull/6280#discussion_r2216169466 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java: ## @@ -999,46 +999,14 @@ clockService, notificationSender(

[PR] IGNITE-25872 Enable FlushConsolidationHandler for client-server IO. [ignite-3]

2025-07-18 Thread via GitHub
ascherbakoff opened a new pull request, #6280: URL: https://github.com/apache/ignite-3/pull/6280 Benchmark results (on a laptop): Without consolidation: ``` Benchmark (fsync) (keysPerThread) (loadBatchSize) (offset) (partitionCount) (threads) Mode CntS

Re: [PR] IGNITE-25848 fix several Critical system error caused by Meta Storage unavailability [ignite-3]

2025-07-18 Thread via GitHub
alievmirza commented on code in PR #6243: URL: https://github.com/apache/ignite-3/pull/6243#discussion_r2216075283 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteInMemoryNodeRestartTest.java: ## @@ -85,99 +74,15 @@ public class ItIgniteI

Re: [PR] IGNITE-25848 fix several Critical system error caused by Meta Storage unavailability [ignite-3]

2025-07-18 Thread via GitHub
alievmirza commented on code in PR #6243: URL: https://github.com/apache/ignite-3/pull/6243#discussion_r2216075283 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteInMemoryNodeRestartTest.java: ## @@ -85,99 +74,15 @@ public class ItIgniteI

Re: [PR] IGNITE-25948 Reduce amount of raft logs. [ignite-3]

2025-07-18 Thread via GitHub
sanpwc commented on code in PR #6278: URL: https://github.com/apache/ignite-3/pull/6278#discussion_r2216036585 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -4061,6 +4055,23 @@ private void logConfigurationChange(final Configuration newCon

Re: [PR] IGNITE-25948 Reduce amount of raft logs. [ignite-3]

2025-07-18 Thread via GitHub
alievmirza commented on code in PR #6278: URL: https://github.com/apache/ignite-3/pull/6278#discussion_r2215957653 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -4061,6 +4055,23 @@ private void logConfigurationChange(final Configuration ne

Re: [PR] IGNITE-25571 Configuration compatibility. Support Named lists in configuration snapshot [ignite-3]

2025-07-18 Thread via GitHub
AMashenkov merged PR #6264: URL: https://github.com/apache/ignite-3/pull/6264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-25716 Change TIME dynamic parameter default precision to 6 [ignite-3]

2025-07-18 Thread via GitHub
xtern commented on code in PR #6274: URL: https://github.com/apache/ignite-3/pull/6274#discussion_r2215985352 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java: ## @@ -128,6 +128,7 @@ public class IgniteSqlValidator extends

Re: [PR] IGNITE-25948 Reduce amount of raft logs. [ignite-3]

2025-07-18 Thread via GitHub
sanpwc commented on code in PR #6278: URL: https://github.com/apache/ignite-3/pull/6278#discussion_r2215970307 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -3068,7 +3062,7 @@ public void run(final Status status) { private void preVote

Re: [PR] IGNITE-25948 Reduce amount of raft logs. [ignite-3]

2025-07-18 Thread via GitHub
sanpwc commented on code in PR #6278: URL: https://github.com/apache/ignite-3/pull/6278#discussion_r2215969226 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -1187,19 +1190,10 @@ private boolean initBallotBox() { // TODO: uncomment

Re: [PR] IGNITE-25948 Reduce amount of raft logs. [ignite-3]

2025-07-18 Thread via GitHub
sanpwc commented on code in PR #6278: URL: https://github.com/apache/ignite-3/pull/6278#discussion_r2215968383 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -1608,7 +1602,7 @@ else if (this.state.compareTo(State.STATE_TRANSFERRING) <= 0) {

Re: [PR] IGNITE-25948 Reduce amount of raft logs. [ignite-3]

2025-07-18 Thread via GitHub
sanpwc commented on code in PR #6278: URL: https://github.com/apache/ignite-3/pull/6278#discussion_r2215965942 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -1066,7 +1068,7 @@ public boolean init(final NodeOptions opts) { Requi

Re: [PR] IGNITE-25948 Reduce amount of raft logs. [ignite-3]

2025-07-18 Thread via GitHub
denis-chudov commented on code in PR #6278: URL: https://github.com/apache/ignite-3/pull/6278#discussion_r2215932466 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -3068,7 +3062,7 @@ public void run(final Status status) { private void p

Re: [PR] IGNITE-25921 Fix treating RO txn as applicable for direct mapping [ignite-3]

2025-07-18 Thread via GitHub
ascherbakoff commented on code in PR #6272: URL: https://github.com/apache/ignite-3/pull/6272#discussion_r2215904427 ## modules/client/src/main/java/org/apache/ignite/internal/client/tx/DirectTxUtils.java: ## @@ -256,7 +256,7 @@ public static CompletableFuture resolveChannel(

Re: [PR] IGNITE-25774 Extension to write CDC data to PostgreSQL [ignite-extensions]

2025-07-18 Thread via GitHub
timoninmaxim commented on code in PR #311: URL: https://github.com/apache/ignite-extensions/pull/311#discussion_r2215846389 ## modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/IgniteToPostgreSqlCdcApplier.java: ## @@ -0,0 +1,661 @@ +/* + * Licensed to the Apache So

Re: [PR] IGNITE-25921 Fix treating RO txn as applicable for direct mapping [ignite-3]

2025-07-18 Thread via GitHub
korlov42 commented on code in PR #6272: URL: https://github.com/apache/ignite-3/pull/6272#discussion_r2215869562 ## modules/client/src/main/java/org/apache/ignite/internal/client/tx/DirectTxUtils.java: ## @@ -256,7 +256,7 @@ public static CompletableFuture resolveChannel(

Re: [PR] IGNITE-25921 Fix treating RO txn as applicable for direct mapping [ignite-3]

2025-07-18 Thread via GitHub
ascherbakoff closed pull request #6272: IGNITE-25921 Fix treating RO txn as applicable for direct mapping URL: https://github.com/apache/ignite-3/pull/6272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] IGNITE-25947 Add 'created' flag to RocksDB-based log storage [ignite-3]

2025-07-18 Thread via GitHub
rpuch merged PR #6273: URL: https://github.com/apache/ignite-3/pull/6273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-25716 Change TIME dynamic parameter default precision to 6 [ignite-3]

2025-07-18 Thread via GitHub
zstan commented on code in PR #6274: URL: https://github.com/apache/ignite-3/pull/6274#discussion_r2215845282 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java: ## @@ -128,6 +128,7 @@ public class IgniteSqlValidator extends

Re: [PR] IGNITE-25716 Change TIME dynamic parameter default precision to 6 [ignite-3]

2025-07-18 Thread via GitHub
zstan commented on code in PR #6274: URL: https://github.com/apache/ignite-3/pull/6274#discussion_r2215845282 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java: ## @@ -128,6 +128,7 @@ public class IgniteSqlValidator extends

Re: [PR] IGNITE-25921 Fix treating RO txn as applicable for direct mapping [ignite-3]

2025-07-18 Thread via GitHub
ptupitsyn commented on code in PR #6272: URL: https://github.com/apache/ignite-3/pull/6272#discussion_r2215821310 ## modules/client/src/main/java/org/apache/ignite/internal/client/tx/DirectTxUtils.java: ## @@ -256,7 +256,7 @@ public static CompletableFuture resolveChannel(

Re: [PR] IGNITE-25129 : Calcite. TPC-H query #5: performance drop on scale 0.01 V2 [ignite]

2025-07-18 Thread via GitHub
alex-plekhanov commented on code in PR #12113: URL: https://github.com/apache/ignite/pull/12113#discussion_r2215766713 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/IgniteMdRowCount.java: ## @@ -282,9 +288,21 @@ private static IntM

Re: [PR] IGNITE-25571 Configuration compatibility. Support Named lists in configuration snapshot [ignite-3]

2025-07-18 Thread via GitHub
AMashenkov commented on code in PR #6264: URL: https://github.com/apache/ignite-3/pull/6264#discussion_r2215761783 ## modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigurationTreeComparatorSelfTest.java: ## @@ -406,10 +397,8 @@ v

[PR] IGNITE-24984 Added YEAR in TIMESTAMP literal validation [ignite-3]

2025-07-18 Thread via GitHub
xtern opened a new pull request, #6279: URL: https://github.com/apache/ignite-3/pull/6279 https://issues.apache.org/jira/browse/IGNITE-24984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-21614 Fixes incorrect BindException handling in ClientHandlerModule [ignite-3]

2025-07-18 Thread via GitHub
rpuch merged PR #6262: URL: https://github.com/apache/ignite-3/pull/6262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-25950 Code-generated serializer for GridCacheEntryInfo message [ignite]

2025-07-18 Thread via GitHub
timoninmaxim commented on code in PR #12198: URL: https://github.com/apache/ignite/pull/12198#discussion_r2215710847 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheEntryInfo.java: ## @@ -98,10 +99,10 @@ public CacheObject value() { }

Re: [PR] IGNITE-25571 Configuration compatibility. Support Named lists in configuration snapshot [ignite-3]

2025-07-18 Thread via GitHub
zstan commented on code in PR #6264: URL: https://github.com/apache/ignite-3/pull/6264#discussion_r2215694163 ## modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigurationTreeComparatorSelfTest.java: ## @@ -406,10 +397,8 @@ void t

Re: [PR] IGNITE-22662 Snapshot check refactoring [ignite]

2025-07-18 Thread via GitHub
timoninmaxim commented on code in PR #11897: URL: https://github.com/apache/ignite/pull/11897#discussion_r2215550767 ## modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerTest.java: ## @@ -750,7 +751,7 @@ public void testState() throws Exception {

Re: [PR] IGNITE-22662 Snapshot check refactoring [ignite]

2025-07-18 Thread via GitHub
timoninmaxim commented on code in PR #11897: URL: https://github.com/apache/ignite/pull/11897#discussion_r2215554048 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyHandler.java: ## @@ -288,14 +276,15 @@ priv

Re: [PR] IGNITE-25821 Improve error handling for node config REST API [ignite-3]

2025-07-18 Thread via GitHub
Pochatkin merged PR #6205: URL: https://github.com/apache/ignite-3/pull/6205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-25871 Fix CdcCommandLineStartup interruption [ignite]

2025-07-18 Thread via GitHub
timoninmaxim merged PR #12179: URL: https://github.com/apache/ignite/pull/12179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

Re: [PR] IGNITE-25871 Fix CdcCommandLineStartup interruption [ignite]

2025-07-18 Thread via GitHub
sonarqubecloud[bot] commented on PR #12179: URL: https://github.com/apache/ignite/pull/12179#issuecomment-3088659620 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-25951 .NET: Fix Gradle commands in JavaServer [ignite-3]

2025-07-18 Thread via GitHub
ptupitsyn merged PR #6277: URL: https://github.com/apache/ignite-3/pull/6277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-25950 Code-generated serializer for GridCacheEntryInfo message [ignite]

2025-07-18 Thread via GitHub
timoninmaxim commented on code in PR #12198: URL: https://github.com/apache/ignite/pull/12198#discussion_r2215387124 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheEntryInfo.java: ## @@ -17,16 +17,13 @@ package org.apache.ignite.internal.pr

[PR] IGNITE-25948 Reduce amount of raft logs. [ignite-3]

2025-07-18 Thread via GitHub
sanpwc opened a new pull request, #6278: URL: https://github.com/apache/ignite-3/pull/6278 https://issues.apache.org/jira/browse/IGNITE-25948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] IGNITE-25943 Add basic JMH benchmark for sorted indexes [ignite-3]

2025-07-18 Thread via GitHub
ibessonov merged PR #6271: URL: https://github.com/apache/ignite-3/pull/6271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-25947 Add 'created' flag to RocksDB-based log storage [ignite-3]

2025-07-18 Thread via GitHub
ibessonov commented on code in PR #6273: URL: https://github.com/apache/ignite-3/pull/6273#discussion_r2215292971 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/RocksDbSharedLogStorage.java: ## @@ -162,21 +174,29 @@ public class RocksDbSharedLogStorag

Re: [PR] IGNITE-25944 Use MessageSerializer for SessionChannelMessage [ignite]

2025-07-18 Thread via GitHub
timoninmaxim merged PR #12196: URL: https://github.com/apache/ignite/pull/12196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

[PR] IGNITE-25951 .NET: Fix Gradle commands in JavaServer [ignite-3]

2025-07-18 Thread via GitHub
ptupitsyn opened a new pull request, #6277: URL: https://github.com/apache/ignite-3/pull/6277 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] IGNITE-25944 Use MessageSerializer for SessionChannelMessage [ignite]

2025-07-18 Thread via GitHub
sonarqubecloud[bot] commented on PR #12196: URL: https://github.com/apache/ignite/pull/12196#issuecomment-3088144922 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-22662 Snapshot check refactoring [ignite]

2025-07-18 Thread via GitHub
sonarqubecloud[bot] commented on PR #11897: URL: https://github.com/apache/ignite/pull/11897#issuecomment-3088082646 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

[PR] IGNITE-25950 Code-generated serializer for GridCacheEntryInfo message [ignite]

2025-07-18 Thread via GitHub
shishkovilja opened a new pull request, #12198: URL: https://github.com/apache/ignite/pull/12198 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ##